[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-07-11 Thread Julian Edwards
** Changed in: maas/1.2 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-22 Thread Raphaël Badin
** Changed in: maas/1.2 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-21 Thread Raphaël Badin
Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. More importantly, fixing this upsteam is better because it means that the monkey patching code and the code stolen from django 14 gets exercised when we run the test suite on a

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-21 Thread Raphaël Badin
** Also affects: maas/1.2 Importance: Undecided Status: New ** No longer affects: maas ** Changed in: maas/1.2 Assignee: (unassigned) = Raphaël Badin (rvb) ** Changed in: maas/1.2 Importance: Undecided = Critical ** Changed in: maas/1.2 Status: New = In Progress --

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-21 Thread Raphaël Badin
** Branch linked: lp:~rvb/maas/generic-field-1.2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
** Changed in: maas Assignee: Raphaël Badin (rvb) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
I'm not sure fixing this in the packaging is the right solution here. If we have a patch to add the new classes (plural, there is the field model and the form model), then we will have to update the upstream code to match that (everywhere where it's imported plus in all the migration files where

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
Julian suggested another way to do this: carry a packaging patch with the field and the changes required to the source to use it. My main concern is that this field (as a string 'django.db.models.fields.GenericIPAddressField') is used by South in the migration code and, although this solution is

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Dave Walker
Does it make sense to monkey patch if django required version? Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. Thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 03:54 PM, Dave Walker wrote: Does it make sense to monkey patch if django required version? It's also a possibility, but given the way Django plays with imports, this could be a dangerous game. Either way, this shouldn't be solved in packaging.. it's core support needed in

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Andres Rodriguez
Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu.

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 08:32 PM, Andres Rodriguez wrote: Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. Good point, that's another argument in favor of the monkey patch solution. -- You

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Raphaël Badin
On 02/20/2013 04:11 PM, Raphaël Badin wrote: On 02/20/2013 03:54 PM, Dave Walker wrote: Does it make sense to monkey patch if django required version? It's also a possibility, but given the way Django plays with imports, this could be a dangerous game. That being said, the monkey patch

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-20 Thread Julian Edwards
On Wednesday 20 Feb 2013 19:54:21 Raphaël Badin wrote: On 02/20/2013 08:32 PM, Andres Rodriguez wrote: Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. Good point, that's

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-19 Thread Julian Edwards
In that case, this bug is not a MAAS bug, it's a packaging bug. ** Changed in: maas Status: New = Invalid ** Also affects: maas (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-19 Thread Julian Edwards
I think we just need to move the patch I did for the Django package right into the maas package (with file path changes etc etc) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232

[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-19 Thread Andres Rodriguez
Hi Julian, This bug does not belong to the packaging nor MAAS *in* Ubuntu, because GenericIpAddressField patch is not in django nor applied int he packaging of any Ubuntu packages in the Archives. This is a bug that affects upstream MAAS and Upstream packaging. For this reason, this does not

Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.

2013-02-19 Thread Julian Edwards
Hey Andres, Upstream doesn't have packaging really. The packaging branch that's there belongs to Ubuntu, it just happens to be owned by Maas maintainers. Cheers Andres Rodriguez andres...@ubuntu-pe.org wrote: Hi Julian, This bug does not belong to the packaging nor MAAS *in* Ubuntu, because