[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

This bug was fixed in the package freeradius - 2.1.12+dfsg-1.2ubuntu8.1 --- freeradius (2.1.12+dfsg-1.2ubuntu8.1) trusty; urgency=medium * Manage process in upstart properly and fix logrotate reload (LP: #1406105) -- Robert C Jennings Tue, 04 Aug

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

I verified that the bug is fixed in version 2.1.12+dfsg-1.2ubuntu8.1 and that the upgrade process (restart) works as intended. Thank you very much for your efforts in fixing this bug. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1406105 Title: Broken logrotate script in

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Thanks! This looks good. I particularly appreciate the effort you took to figure through any upgrade path issues and the comprehensive coverage you have of that in the Regression Potential section. This gives me much more confidence in sponsoring this. One very minor nitpick - I used version

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Hello Sebastian, or anyone else affected, Accepted freeradius into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/freeradius/2.1.12+dfsg-1.2ubuntu8.1 in a few hours, and then in the -proposed repository. Please help us by testing this new

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Branch linked: lp:ubuntu/trusty-proposed/freeradius -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1406105 Title: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Robie, can you review the patch in comment #10 for this fix? Thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1406105 Title: Broken logrotate script in

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Updated the patch. The post-install scripts will restart the daemon so that an upgrade will restart the daemon so that future reloads do work. This addresses the 3rd scenario in comment #7. There would be no regression for users on upgrade. If the service has been reloaded prior to the upgrade

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Changed in: freeradius (Ubuntu Trusty) Status: New = Triaged ** Changed in: freeradius (Ubuntu Trusty) Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report.

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Also affects: freeradius (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: freeradius (Ubuntu Vivid) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Changed in: freeradius (Ubuntu Vivid) Status: New = Invalid -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1406105 Title: Broken logrotate script in

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Marking vivid as invalid as the this affects trusty (upstart) only not systemd based releases (vivid/wily) ** Changed in: freeradius (Ubuntu) Status: In Progress = Invalid ** Changed in: freeradius (Ubuntu Trusty) Status: Triaged = In Progress ** Changed in: freeradius (Ubuntu

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Description changed: + [Impact] + + * freeradius can not be reloaded, upstart will lose track of the + process and leave the original process running (blocking future service + starts) + + * log rotation will not function as intended. The service is not + reloaded and the file handles for

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Back to the prior patch to reduce scope by removing changes for 'init.d' - 'service' for force-reload operations in postinst scripts if invoke- rc.d is not available. This is not changed as we can assume invoke-rc.d is installed and the SRU change needs to be minimal. ** Patch added:

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Here is a debdiff to show how we can manage the process properly in an upstart job (missing exec) so that a restart or reload works as we would expect. The patch also fixes the logrotate script to use the upstart controls rather than the systemv init script (which should not have been shipped

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Wily is using the systemV init scripts and is not affected by this bug. Trusty is using upstart which lacks a reload function currently. Changing the logrotate postrotate script on trusty to call 'service freeradius reload' will not work without explicitly creating a reload function in the

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

** Changed in: freeradius (Ubuntu) Assignee: (unassigned) = Robert C Jennings (rcj) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1406105 Title: Broken logrotate script in

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Robie / Chris, Can you review comment #6 for the proposed patch and upgrade issue/strategy? The upstart config for freeradius is bad; reload(8) or restart(8) will lose track of the process. A reload won't send SIGHUP to the right process and a restart(8) will not stop the existing freeradius

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: freeradius (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to freeradius in Ubuntu.

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

I just realized that there is a better solution for the logrotate script: By using service freeradius reload, the script will work when Upstart is used but also when the traditional init script is used. ** Patch added: Revised patch for the logrotate script

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

The attachment Suggested patch for logrotate script seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu- reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned