[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
I filed https://jira.mongodb.org/browse/SERVER-23460 fwiw -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
I made a smaller testcase: http://paste.ubuntu.com/15573440/. I still have no idea what's going on, but I think the patch in Curtis' branch is a reasonable response to the issue. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Something very odd is going on with the problem offset-outside-of-
bounds.patch is addressing. I hacked the offending source file down to
http://paste.ubuntu.com/15573220/.
This fails to compile with -O2:
ubuntu@promonarchy-remi:~/xenial-mongodb-3.2$ g++ -o foo.o -c -O2 -Werror
-std=c++11 -Ibuild/opt -Isrc src/mongo/bson/bson_obj_test.cpp
In file included from src/mongo/db/jsobj.h:49:0,
from src/mongo/bson/bson_obj_test.cpp:28:
src/mongo/bson/bsonelement.h: In member function ‘virtual void
{anonymous}::UnitTest__BSONObj__getFields::_doTest()’:
src/mongo/bson/bsonelement.h:231:23: error: offset outside bounds of constant
string [-Werror]
return data + 1;
^
cc1plus: all warnings being treated as errors
It succeeds with -O1 though. It _also_ succeeds with -O1 and all the
-fxxx flags that -O2 implies on top of -O1. It _also_ succeeds if almost
any line is removed from the file. But if you remove a few lines and
change it to -O3, it fails again. So I guess some threshold-based
optimization eventually transforms the code in the file into something
that triggers the warning. I'm not quite confident enough to call this a
compiler bug, but it's certainly user hostile.
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to juju-mongodb in Ubuntu.
https://bugs.launchpad.net/bugs/1557852
Title:
[needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Hi Robie Attached are my changes. that I pushed to lp:~sinzui/ubuntu/xenial/juju-mongodb3.2/xenial-mongodb-3.2 > Thank you for the update. I've reviewed the patches now they have > headers so I can follow what's going on. Most look OK. I'm unhappy > with two: 1. arm64-immediate-delete-should-wait-cursor.patch IMHO > inappropriately disables a test that correctly tests positive. This > should be fixed properly, or allowed to FTBFS on arm64, or arm64 > builds need to be disabled. Happy to follow Ubuntu archive admin or > release team guidance. I revisited upstream bugs, commits and commits from other repos. I found a patch that affected the failing test. In my experience, only arm64 was failing, but the upstream report implies the tests can fail on many types of hardware. https://github.com/mongodb/mongo/commit/b6d309a15215a9243f21eb33cc6bcb6fbca58e56.patch I successfully built and tested xenial arm64, amd64, and ppc64el. > 2. offset-outside-of-bounds.patch: tests disabled due to GCC-5. As > noted this should be fixed properly and upstreamed. Perhaps this > should be combined into disable-warnings.patch? Not sure if this is OK > to upload or not. Happy to follow Ubuntu archive admin or release team > guidance. I can file an bug upstream. I am not inclined attempt this fix myself as I have other tasks that I am told are higher priority. > The changelog needs updating to match changes made based on 2.6 - I I updated the changelog to match what I propose for juju-mongodb2.6 ** Patch added: "changes for review" https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+attachment/4618927/+files/juju-mongodb3.2-review1.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
To clarify, points 1 and 2 in my comment 6 above need fixing or otherwise to be addressed somehow. Once done, I'm happy to upload. ** Changed in: juju-mongodb (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Minor omission: changelog entry should close this bug. I can fix when uploading, just leaving a note for myself here. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Thank you for the update. I've reviewed the patches now they have headers so I can follow what's going on. Most look OK. I'm unhappy with two: 1. arm64-immediate-delete-should-wait-cursor.patch IMHO inappropriately disables a test that correctly tests positive. This should be fixed properly, or allowed to FTBFS on arm64, or arm64 builds need to be disabled. Happy to follow Ubuntu archive admin or release team guidance. 2. offset-outside-of-bounds.patch: tests disabled due to GCC-5. As noted this should be fixed properly and upstreamed. Perhaps this should be combined into disable-warnings.patch? Not sure if this is OK to upload or not. Happy to follow Ubuntu archive admin or release team guidance. The changelog needs updating to match changes made based on 2.6 - I don’t think it’s accurate any more. Ideally it would include changes not uploaded to the archive, so perhaps rebase on 2.6 and squash into previous PPA entry? rbasak is happy to do this before upload when the other items are resolved (so he doesn’t have to keep changing the description of what changed as we change things). I've not tested build since resolving above items may influence outcome. My tree (with some additional changes) is at https://git.launchpad.net/~racb/+git/juju- mongodb/log/?h=sinzui-3.2-fixes -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Hi Curtis, Again, this looks good on the whole. As discussed on IRC, please add dep3 headers to the quilt patches to help me review and so that we can maintain this better going forward. debian/copyright also probably needs a glance for both this and the 2.6 package, but as discussed I'll leave that between you and the archive admin. I've not completed review yet, but the other changes look fairly straightforward to me. Hopefully this is enough to unblock you. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
*** This is an automated message *** This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs- packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist. ** Changed in: juju-mongodb (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
Thank you for the feedback Robie. Attached is a diff of my dep-3 changes. I also updated the control arch to any per Dimitri's desire to build every where possible ** Patch added: "dep-3 and arch any" https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+attachment/4603773/+files/juju-mongodb3.2-review-1.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1557852] Re: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty
A diff of the patch changes for juju-mongodb3.2. It is easier to read the actual patches then to read this diff of a patch. ** Patch added: "juju-mongodb3.2-patches.diff" https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+attachment/4600708/+files/juju-mongodb3.2-patches.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to juju-mongodb in Ubuntu. https://bugs.launchpad.net/bugs/1557852 Title: [needs-packaging] juju-mongodb3.2 in xenial, wily, and trusty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/juju-mongodb/+bug/1557852/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
