[Bug 539663] Re: FFE for php 5.3.2
5.3.2 has been uploaded. ** Changed in: php5 (Ubuntu) Status: Incomplete = Fix Released -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
OK, so admittedly I still don't understand what this patch is doing, but it might not really have to do anything with flock(), since both close() and program termination automatically release locks. I targetted bug 544052 for lucid, thanks Ondřej! -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
OK, so admittedly I still don't understand what this patch is doing Me neither, but my guess is that upstream don't understand it too, since lock_flag is unused variable (greped in whole src tree): ./main/streams/plain_wrapper.c: int lock_flag; /* stores the lock state */ ./main/streams/plain_wrapper.c: self-lock_flag = LOCK_UN; ./main/streams/plain_wrapper.c: self-lock_flag = LOCK_UN; ./main/streams/plain_wrapper.c: self-lock_flag = LOCK_UN; ./main/streams/plain_wrapper.c: self-lock_flag = LOCK_UN; ./main/streams/plain_wrapper.c: data-lock_flag = value; So unless there is some hidden C magick, they just set it and never use its value. So I think the underlying logic for this patch was: Ah, we don't need to set it to LOCK_UN here, since we are closing anyway. If it bothers you, somebody could write to Tony or Ilya and ask them (I'm not doing that). -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 539663] Re: FFE for php 5.3.2
Ondřej Surý [2010-03-23 14:21 -]: Me neither, but my guess is that upstream don't understand it too, since lock_flag is unused variable (greped in whole src tree): LOL. OK, I'm relieved then, thanks for investigating. :-) Martin -- Martin Pitt| http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
** Changed in: php5 (Ubuntu) Importance: High = Medium -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
The changelog looks very reasonable mostly. The only thing that made me raise eyebrows is * Removed automatic file descriptor unlocking happening on shutdown and/or stream close (on all OSes). (Tony, Ilia) This sounds like a behaviour change which is not obviously a bug fix, but the description is not verbose enough to say what it really does. Would you mind digging up some bug references, detailled changelogs, etc. about this? E. g. the usual behaviour of flock() is that locks are dropped on program shutdown (I don't even think that it's possible to disable that behaviour, and it really shouldn't be). Now, this is probably not directly related to flock(), but it'd still be interesting to see what it does. Thanks! -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
** Changed in: php5 (Ubuntu) Status: New = Incomplete -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
Unfortunately there doesnt seem to be any public discussion about this. i only found the cvs commit about it: http://svn.php.net/viewvc?view=revisionrevision=292632 but this change also appeared to make it in 5.2.13 as well. Regards chuck -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
The change should be fairly safe, since it's inside php something_close function. flock locks should be release on fclose() on fd, and lock flag is set to LOCK_UN on next something_fdopen_something call. I do however urge you to cause extra caution when doing the FFE and not ignore lintian errors such as in #544052, which would hint you about empty package. -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
** Attachment added: changelog.txt http://launchpadlibrarian.net/41028449/changelog.txt -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
** Attachment added: debdiff http://launchpadlibrarian.net/41028654/debdiff -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 539663] Re: FFE for php 5.3.2
** Attachment added: debdiff.gz http://launchpadlibrarian.net/41028663/debdiff.gz ** Changed in: php5 (Ubuntu) Importance: Undecided = High -- FFE for php 5.3.2 https://bugs.launchpad.net/bugs/539663 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
