[Bug 604717] Re: Please convert init script to upstart
This debdiff adds an upstart job for ntp. Upstart job does the same thing SysV script does. In addition, it adds two features that are common requirement in production: 1) does one off sync before starting ntpd in foreground - off by default 2) syncs hardware clock after the one off sync - off by default Many services, OpenStack's nova comes to mind, require time to be synced, rather ntpd started. By doing one off sync before starting ntpd, system will have correct time before nova-* services start. Nova service then needs to depend on started ntpd. Hardware clock sync might be an overkill, but, IMHO, doing it right after we synced the OS time seems the best place to do it. ** Patch added: ntp-final.debdiff https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+attachment/3662421/+files/ntp-final.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/604717 Title: Please convert init script to upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
Found few typos. Fixed. ** Changed in: ntp (Ubuntu) Assignee: (unassigned) = Ante Karamatić (ivoks) ** Patch added: ntp-final.debdiff https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+attachment/3662422/+files/ntp-final.debdiff ** Patch removed: ntp-final.debdiff https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+attachment/3662421/+files/ntp-final.debdiff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/604717 Title: Please convert init script to upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
The ntp package provides /usr/sbin/ntp-wait NTP can use this, or a similar technique, to emit an Upstart event when the time is synchronised. It would be nice to be able to react to this (although maybe not to block daemon startup indefinitely). -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in Ubuntu. https://bugs.launchpad.net/bugs/604717 Title: Please convert init script to upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
Ill fix up all of these mistakes and resubmit the debdiff, I did test them but I guess I didnt hit these problems while testng them. chuck -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
+ test -f /etc/default/ntp ./etc/default/ntp || true Missing a space between '.' and '/etc/default/ntp'. This is probably why you had to add the '|| true' - remove that. Also, to match the init script this should be test -r not test -f. + test -e /var/lib/ntp.conf.dhcp NTPD_OPTS=$NTPD_OPTS -c /var/lib/ntp/ntp.conf.dhcp The first filename is typoed - should be /var/lib/ntp/ntp.conf.dhcp. You only seem to have ported part of the locking code over. You need the backgrounded lockfile-touch and the kill as well (otherwise the lock could time out on a very slow start), although quite how you're going to get the pid of the lockfile-touch process across to the post-start script I'm not quite sure. Please try to avoid the use of a pidfile. Upstart's process tracking should be sufficient. The apparmor code in the Upstart job appears to be new relative to the init script. Why? -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
The last point may be skew between what I was reviewing and current Maverick - a number of packages have been converted to dh_apparmor. I haven't looked into exactly what's involved here. -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
I agree with David's comment. -invoke-rc.d --quiet ntp start /dev/null 21 || true +start stop /dev/null 21 || true This is wrong - should be 'start ntp'. (Incomplete review; I still need to look at the job itself.) -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
Should the dh_installinit really be marked upstart only? I am thinking more about merging back to Debian or even backporting where upstart may not be in use. Otherwise I think this patch looks fine, and I may try a test build to verify it. I happen to agree ntp should migrate to upstart. -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
** Tags added: patch -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
** Changed in: ntp (Ubuntu) Status: Confirmed = Triaged -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
** Changed in: ntp (Ubuntu) Importance: Undecided = Wishlist ** Changed in: ntp (Ubuntu) Status: New = Confirmed -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 604717] Re: Please convert init script to upstart
** Attachment added: patch http://launchpadlibrarian.net/51793594/patch -- Please convert init script to upstart https://bugs.launchpad.net/bugs/604717 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ntp in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
