[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Tags added: testcase -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in Ubuntu. https://bugs.launchpad.net/bugs/659532 Title: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/659532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
This bug was fixed in the package vm-builder - 0.12.4-0ubuntu0.2 --- vm-builder (0.12.4-0ubuntu0.2) lucid-security; urgency=low * debian/patches/0001-lp659532.patch: supply disk format in libvirt XML for converted disks otherwise non-raw disks (eg, 'qcow2', the default in vm-builder) won't show up in the guest with patched libvirt in lucid-security or libvirt 0.8.3 and higher. - LP: #659532 -- Jamie Strandboge ja...@ubuntu.com Wed, 13 Oct 2010 08:08:07 -0500 ** Changed in: vm-builder (Ubuntu Lucid) Status: Fix Committed = Fix Released -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
This bug was fixed in the package vm-builder - 0.12.4-0ubuntu1.1 --- vm-builder (0.12.4-0ubuntu1.1) maverick-proposed; urgency=low * debian/patches/0001-lp659532.patch: supply disk format in libvirt XML for converted disks otherwise non-raw disks (eg, 'qcow2', the default in vm-builder) won't show up in the guest with libvirt 0.8.3 and newer - LP: #659532 -- Jamie Strandboge ja...@ubuntu.com Tue, 12 Oct 2010 17:21:56 -0500 ** Changed in: vm-builder (Ubuntu Maverick) Status: Fix Committed = Fix Released -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Branch linked: lp:ubuntu/maverick-proposed/vm-builder -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Accepted vm-builder into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Changed in: vm-builder (Ubuntu Maverick) Status: In Progress = Fix Committed ** Tags added: verification-needed -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Installed 0.12.4-0ubuntu1.1 from maverick-proposed and both test cases work properly. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
This bug was fixed in the package vm-builder - 0.12.4-0ubuntu1.1 --- vm-builder (0.12.4-0ubuntu1.1) maverick-proposed; urgency=low * debian/patches/0001-lp659532.patch: supply disk format in libvirt XML for converted disks otherwise non-raw disks (eg, 'qcow2', the default in vm-builder) won't show up in the guest with libvirt 0.8.3 and newer - LP: #659532 -- Jamie Strandboge ja...@ubuntu.com Tue, 12 Oct 2010 17:21:56 -0500 ** Changed in: vm-builder (Ubuntu Maverick) Status: Fix Committed = Fix Released -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Pocket copied to natty to make sure that new updates to the package don't drop this patch. ** Changed in: vm-builder (Ubuntu Maverick) Status: Fix Released = Fix Committed ** Changed in: vm-builder (Ubuntu Natty) Status: Triaged = Fix Released -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Uploaded 0.12.4-0ubuntu0.2 to security PPA for lucid to prepare for pending libvirt update. ** Changed in: vm-builder (Ubuntu Lucid) Status: Triaged = Fix Committed -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Tags added: verification-done ** Tags removed: verification-needed ** Tags added: verification-needed -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Description changed: Binary package hint: vmbuilder libvirt 0.8.3 and later (and the upcoming libvirt update for lucid- security) does not probe qemu disks for the image format and defaults to 'raw' when the format is not specified in the XML. This breaks vmbuilder because the version in maverick does not specify a format in the XML. WORKAROUND: After creating, use '/usr/sbin/libvirt-migrate-qemu-disks'. TEST CASE 1 (in maverick release): $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system $ virsh start ubuntu $ virt-viewer ubuntu At this point the VM has started, but shows 'No bootable devices'. - TEST CASE 2 (don't regress --raw (first delete the previos 'ubuntu' domain)): + TEST CASE 2 (don't regress --raw (first delete the previous 'ubuntu' domain)): $ qemu-img create /tmp/foo.img 5G $ sudo /sbin/losetup /dev/loop1 /tmp/foo.img - $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw=/tmp/foo.img + $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw=/dev/loop1 $ virsh --connect=qemu:///system start ubuntu $ virt-viewer --connect=qemu:///system ubuntu At this point the VM should be started and running. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Got soren to review the patch in IRC (#ubuntu-server) and he ACK'd the patch: 07:34 jdstrand soren: hi! would you mind looking at and commenting on my patch for bug #659532 ? 07:41 soren jdstrand: Looks lovely. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Description changed: Binary package hint: vmbuilder - libvirt 0.8.3 and later (and the upcoming libvirt update for lucid- + SRU + + 1. libvirt 0.8.3 and later (and the upcoming libvirt update for lucid- security) does not probe qemu disks for the image format and defaults to 'raw' when the format is not specified in the XML. This breaks vmbuilder because the version in maverick does not specify a format in the XML. WORKAROUND: After creating, use '/usr/sbin/libvirt-migrate-qemu-disks'. - TEST CASE 1 (in maverick release): + 2. this is not yet fixed upstream (or Natty), but is ACKd by upstream + + 3. Patch adjusts VMbuilder/disk.py to have a new 'self.format_type' + attribute. This attribute will normally be 'None', but will be set when + a disk is convert()ed. + VMbuilder/plugins/libvirt/templates/libvirtxml*.tmpl is then adjusted to + supply the proper qemu image format to libvirt if the format_type is set + for the disk. Since libvirt defaults to 'raw' for unspecified format + types, this covers the default 'qcow2' case and avoids setting the + format type when using --raw. + + 4a. TEST CASE 1 (in maverick release): $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system $ virsh start ubuntu $ virt-viewer ubuntu - At this point the VM has started, but shows 'No bootable devices'. + At this point the VM will have started, but shows 'No bootable devices' + if unpatched. If patched, it should boot up fine. - TEST CASE 2 (don't regress --raw (first delete the previous 'ubuntu' domain)): + 4b. TEST CASE 2 (don't regress --raw (first delete the previous 'ubuntu' domain)): $ qemu-img create /tmp/foo.img 5G $ sudo /sbin/losetup /dev/loop1 /tmp/foo.img $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw=/dev/loop1 $ virsh --connect=qemu:///system start ubuntu $ virt-viewer --connect=qemu:///system ubuntu At this point the VM should be started and running. + + 5. Risk of regression is considered low. Patch is not intrusive and only + will add the extra XML only if a disk is converted, so it should affect + no other parts of libvirt. Since vm-builder with libvirt and qcow2 disks + (the default) are currently broken, there is no risk of regression in + the libvirt code. Tests show that --raw still works properly too. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Uploaded 0.12.4-0ubuntu1.1 to maverick-proposed. ** Changed in: vm-builder (Ubuntu Lucid) Assignee: (unassigned) = Jamie Strandboge (jdstrand) ** Changed in: vm-builder (Ubuntu Maverick) Assignee: (unassigned) = Jamie Strandboge (jdstrand) ** Changed in: vm-builder (Ubuntu Natty) Assignee: (unassigned) = Jamie Strandboge (jdstrand) ** Changed in: vm-builder (Ubuntu Maverick) Milestone: None = maverick-updates -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Description changed: Binary package hint: vmbuilder libvirt 0.8.3 and later (and the upcoming libvirt update for lucid- security) does not probe qemu disks for the image format and defaults to 'raw' when the format is not specified in the XML. This breaks vmbuilder because the version in maverick does not specify a format in the XML. WORKAROUND: After creating, use '/usr/sbin/libvirt-migrate-qemu-disks'. Should be able to also use the '--raw' option when running vmbuilder (need to create the disk first when using '--raw', eg: 'qemu-img create foo.img 2G'), but I can't seem to get this to work right. TEST CASE (in maverick release): $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system - $ virsh start ubuntu - $ virt-viewer ubuntu + $ virsh --connect=qemu:///system start ubuntu + $ virt-viewer --connect=qemu:///system ubuntu At this point the VM has started, but shows 'No bootable devices' ** Changed in: vm-builder (Ubuntu Maverick) Status: Triaged = In Progress -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
** Description changed: Binary package hint: vmbuilder libvirt 0.8.3 and later (and the upcoming libvirt update for lucid- security) does not probe qemu disks for the image format and defaults to 'raw' when the format is not specified in the XML. This breaks vmbuilder because the version in maverick does not specify a format in the XML. WORKAROUND: - After creating, use '/usr/sbin/libvirt-migrate-qemu-disks'. Should be able to also use the '--raw' option when running vmbuilder (need to create the disk first when using '--raw', eg: 'qemu-img create foo.img 2G'), but I can't seem to get this to work right. + After creating, use '/usr/sbin/libvirt-migrate-qemu-disks'. - TEST CASE (in maverick release): + TEST CASE 1 (in maverick release): $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system + $ virsh start ubuntu + $ virt-viewer ubuntu + + At this point the VM has started, but shows 'No bootable devices'. + + TEST CASE 2 (don't regress --raw (first delete the previos 'ubuntu' domain)): + $ qemu-img create /tmp/foo.img 5G + $ sudo /sbin/losetup /dev/loop1 /tmp/foo.img + $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw=/tmp/foo.img $ virsh --connect=qemu:///system start ubuntu $ virt-viewer --connect=qemu:///system ubuntu - At this point the VM has started, but shows 'No bootable devices' + At this point the VM should be started and running. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Attached is a preliminary patch for vm-builder on maverick which adjusts VMbuilder/disk.py to have a new 'self.format_type' attribute. This attribute will normally be 'None', but will be set when a disk is convert()ed. VMbuilder/plugins/libvirt/templates/libvirtxml*.tmpl is then adjusted to supply the proper qemu image format to libvirt if the format_type is set for the disk. Since libvirt defaults to 'raw' for unspecified format types, this covers the default 'qcow2' case and avoids setting the format type when using --raw. Tested using: $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system $ sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw /dev/loop1 ** Patch added: vm-builder_0.12.4-0ubuntu1.1.debdiff https://bugs.launchpad.net/ubuntu/+source/vm-builder/+bug/659532/+attachment/1689824/+files/vm-builder_0.12.4-0ubuntu1.1.debdiff -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
I also tested with: sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw /dev/loop1p1 after using fdisk on /dev/loop0 and using kpartx -av /tmp/foo.img. -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 659532] Re: vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices)
Err, obviously I meant: sudo vmbuilder kvm ubuntu --suite lucid --flavour virtual --arch i386 -o --libvirt qemu:///system --raw /dev/loop0p1 -- vmbuilder XML is incomplete with libvirt 0.8.3 (No bootable devices) https://bugs.launchpad.net/bugs/659532 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to vm-builder in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
