[Bug 922645] Re: ubuntu template should fail on error
Verified using test case on oneiric. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
This bug was fixed in the package lxc - 0.7.5-0ubuntu8.4 --- lxc (0.7.5-0ubuntu8.4) oneiric-proposed; urgency=low * 0022-fix-lxc-destroy-bugs.patch: - don't delete a running container - handle case where rootfs is not specififed in config (or config is corrupt or has been deleted) - fix broken detection of lvm backing store * 0030-ubuntu-template-fail.patch: make lxc-ubuntu template fail on error (LP: #922645) -- Serge Hallyn serge.hal...@ubuntu.com Sat, 28 Jan 2012 12:25:39 -0600 ** Changed in: lxc (Ubuntu Oneiric) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
Hello Serge, or anyone else affected, Accepted lxc into oneiric-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Changed in: lxc (Ubuntu Oneiric) Status: Triaged = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
** Branch linked: lp:ubuntu/oneiric-proposed/lxc -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
** Description changed: lxc-create should fail if parts of the ubuntu container setup failed. + + TEST CASE: + + 1. make sure /var/cache/lxc is empty + 2. lxc-create -n test -t ubuntu -- oneiric + 3. edit /var/cache/lxc/oneiric/etc/resolv.conf , set DNS server to unroutable IP (192.168.200.99) + 4. lxc-create -n test2 -t ubuntu -- oneiric + 5. verify exit code is 0 (echo $?) + 6. chroot /var/lib/lxc/test2/rootfs dpkg -l lxcguest # verify that no lxcguest is installed + 7. lxc-destroy -n test2 + 7. Install updated lxc + 8. Repeat step 4 + 9. verify exit code is not 0 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
** Branch linked: lp:ubuntu/lxc -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
Actually the extra changes weren't as crucial as I'd thought, but the one part was badly behaving when config was not yet written (as it might not if lxc-ubuntu exits early), so it's nice to have. The new version (correctly) exits with 1 and cleans up when i mess up networking for the container so that it can't install lxcguest. Pushed to oneiric-proposed. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
lxc-create does a good job now of cleaning up after failures. So just adding 'set -e' to the top of lxc-ubuntu seems to be working for me. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
** Branch linked: lp:~serge-hallyn/ubuntu/precise/lxc/fix-resolvconf -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
This bug was fixed in the package lxc - 0.7.5-3ubuntu14 --- lxc (0.7.5-3ubuntu14) precise; urgency=low * debian/control: add btrfs-tools to lxc Suggests (LP: #942241) * 0030-ubuntu-template-fail.patch: make lxc-ubuntu template fail on error (LP: #922645) * 0031-ubuntu-template-resolvconf.patch: handle /etc/resolv.conf being a symlink as is now done by resolvconf by default. (LP: #922706) * debian/lxcguest.lxcmount.upstart: emit mounted MOUNTPOINT=/run to make resolvconf start. (LP: #922706) -- Serge Hallyn serge.hal...@ubuntu.com Fri, 27 Jan 2012 11:13:26 -0600 ** Changed in: lxc (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 922645] Re: ubuntu template should fail on error
Simple change, I think its worth backporting to oneiric. ** Also affects: lxc (Ubuntu Oneiric) Importance: Undecided Status: New ** Changed in: lxc (Ubuntu Oneiric) Status: New = Triaged ** Changed in: lxc (Ubuntu Oneiric) Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 922645] Re: ubuntu template should fail on error
Quoting Clint Byrum (cl...@fewbar.com): Simple change, I think its worth backporting to oneiric. I'm happy to SRU it, but note that precise has already had some changes to lxc-create and lxc-destroy which allowed this to be a two-line change. So for oneiric it'll be a bit (but not too much) bigger. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/922645 Title: ubuntu template should fail on error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/922645/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
