[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

** Merge proposal unlinked:
   
https://code.launchpad.net/~kstenerud/ubuntu/+source/amavisd-new/+git/amavisd-new/+merge/362855

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

** Merge proposal unlinked:
   
https://code.launchpad.net/~kstenerud/ubuntu/+source/amavisd-new/+git/amavisd-new/+merge/361780

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

** Changed in: amavisd-new (Ubuntu Bionic)
 Assignee: (unassigned) =>  Christian Ehrhardt  (paelzer)

** Changed in: amavisd-new (Ubuntu Bionic)
   Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

Which one, @michaelbibby? Have you tried one of the tree mentioned in
comment #9?

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

Thanks for the summary, @sdeziel

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

Would you be able to start a discussion about this new patch in the
amavis-users mailing list?

https://lists.amavis.org/cgi-bin/mailman/listinfo/amavis-users

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

Confirmed fedora is using the first (one-liner) patch:

$ cat amavisd-new-2.11.0-detect_originating_email.patch 
>From giovanni at paclan.it  Fri Jul  1 09:35:49 2016
From: giovanni at paclan.it (Giovanni)
Date: Fri, 1 Jul 2016 07:35:49 + (UTC)
Subject: dkim not working after upgrading to 2.11.0
Message-ID: 

Hi,
after upgrading to 2.11.0, DKIM signing does not work anymore because
the email is no more detected as ORIGINATING.
This diff fixes the issue.
 Cheers
  Giovanni


--- amavisd.origTue Apr 26 21:24:33 2016
+++ amavisd Fri Jul  1 01:03:15 2016
@@ -34338,6 +34329,7 @@ sub collect_some_dkim_info($) {
 $sig_ind++;
   }
   Amavis::load_policy_bank($_,$msginfo) for @bank_names;
+  $msginfo->originating(c('originating'));
   $msginfo->dkim_signatures_valid(\@signatures_valid)  if @signatures_valid;
 # if (ll(5) && $sig_ind > 0) {
 #   # show which header fields are covered by which signature

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1770532] Re: DKIM signing not working in bionic

[Andreas Hasenack]

There are two patches floating out there:

a) https://lists.amavis.org/pipermail/amavis-users/2016-July/004428.html (the 
one you applied I believe)
--- amavisd.origTue Apr 26 21:24:33 2016
+++ amavisd Fri Jul  1 01:03:15 2016
@@ -34338,6 +34329,7 @@ sub collect_some_dkim_info($) {
 $sig_ind++;
   }
   Amavis::load_policy_bank($_,$msginfo) for @bank_names;
+  $msginfo->originating(c('originating'));
   $msginfo->dkim_signatures_valid(\@signatures_valid)  if @signatures_valid;
 # if (ll(5) && $sig_ind > 0) {
 #   # show which header fields are covered by which signature


b) https://lists.amavis.org/pipermail/amavis-users/2018-February/005297.html
--- amavisd.origTue Apr 26 21:24:33 2016
+++ amavisd Fri Aug  5 12:32:39 2016
@@ -22806,6 +22806,7 @@ sub process_smtp_request() {
 }
 # load policy banks from the 'client_ipaddr_policy' lookup
 Amavis::load_policy_bank($_,$msginfo) for @bank_names_cl;
+$msginfo->originating(c('originating'));
 
 $msginfo->client_addr($cl_ip);  # ADDR
 $msginfo->client_port($cl_port);# PORT
@@ -34338,6 +34330,7 @@ sub collect_some_dkim_info($) {
 $sig_ind++;
   }
   Amavis::load_policy_bank($_,$msginfo) for @bank_names;
+  $msginfo->originating(c('originating'));
   $msginfo->dkim_signatures_valid(\@signatures_valid)  if @signatures_valid;  
# if (ll(5) && $sig_ind > 0) {
 #   # show which header fields are covered by which signature


It's unfortunate upstream is no longer responsive.

Would you perhaps be able to comment on or even test the second patch?

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1770532

Title:
  DKIM signing not working in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/amavisd-new/+bug/1770532/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs