[Bug 1814532] Re: Big samba memory leak fixed upstream
No, we would need a new bug report for trusty. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1814532] Re: Big samba memory leak fixed upstream
With the bionic packages: *** 2:4.7.6+dfsg~ubuntu-0ubuntu2.6 500 500 http://br.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages Running: smbclient //localhost/pub -U ubuntu%ubuntu -c "pwd;dir;cd dir1;dir;pwd;cd dir11; pwd; dir; cd /; cd dir2; pwd; dir; cd /" Server valgrind report: ==3887== LEAK SUMMARY: ==3887==definitely lost: 72 bytes in 7 blocks ==3887==indirectly lost: 0 bytes in 0 blocks ==3887== possibly lost: 125,212 bytes in 488 blocks ==3887==still reachable: 117,607 bytes in 901 blocks ==3887== suppressed: 0 bytes in 0 blocks After update: ==7133== LEAK SUMMARY: ==7133==definitely lost: 24 bytes in 1 blocks ==7133==indirectly lost: 0 bytes in 0 blocks ==7133== possibly lost: 125,212 bytes in 488 blocks ==7133==still reachable: 117,607 bytes in 901 blocks ==7133== suppressed: 0 bytes in 0 blocks I was hoping the original reported would have tried the updated packages, since he seemed quite affected by this memleak. But in the meantime, this is the verification I can do. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1814532] Re: Big samba memory leak fixed upstream
I'm not sure this is robust enough as a test case, that's why I'm adding it here instead of in the test caseh, but I ran smbd under valgrind before and after the update, and less bytes were lost for the same smbclient connection: before: ==3977== LEAK SUMMARY: ==3977==definitely lost: 72 bytes in 7 blocks After: ==5438== LEAK SUMMARY: ==5438==definitely lost: 24 bytes in 1 blocks The client command was (with a suitable smb.conf and /pub directory): smbclient //localhost/pub -U ubuntu%ubuntu -c "pwd;dir;cd dir1;dir;pwd;cd dir11; pwd; dir; cd /; cd dir2; pwd; dir; cd /" ** Changed in: samba (Ubuntu Bionic) Assignee: (unassigned) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu Bionic) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1814532] Re: Big samba memory leak fixed upstream
** Description changed: [Impact] - * An explanation of the effects of the bug on users and - - * justification for backporting the fix to the stable release. - - * In addition, it is helpful, but not required, to include an -explanation of how the upload fixes this bug. + There is a memory leak in vfswrap_getwd() that, depending on the server + usage, can become severe and trigger an OOM killer. [Test Case] - - * detailed instructions how to reproduce the bug - - * these should allow someone who is not familiar with the affected -package to reproduce the bug and verify that the updated package fixes -the problem. - + It's hard to come up with a test case for memory leaks, because they can take a while to manifest. + [Regression Potential] - - * discussion of how regressions are most likely to manifest as a result - of this change. - - * It is assumed that any SRU candidate patch is well-tested before -upload and has a low overall risk of regression, but it's important -to make the effort to think about what ''could'' happen in the -event of a regression. - - * This both shows the SRU team that the risks have been considered, -and provides guidance to testers in regression-testing the SRU. + Patch is sane and has been applied upstream. It's already present in cosmic and later. The code that frees the pointer is only reached if the pointer isn't NULL. [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + None at this time. [Original Description] There is a big memory leak bug in Samba 4.1 - 4.7.6. Depending on the circumstances all memory of the Ubuntu server will be eaten by Samba sooner or later. Then Linux Oom - killer will kill Samba which will either restart or hang. On our Ubuntu Server 14.04.5 I need to restart Samba 1 - 2 times a week. This bug probably affects also Ubuntu 18.04 if this fix has not yet been backported. This bug has been fixed upstream in Samba 4.7.7. The fix is only two lines of code and the bug is caused by a single misplaced "if" when releasing memory. This upstream commit fixes the bug: https://gitlab.com/samba- team/samba/commit/461a1172ff819692aa0a2dc5ce7fc5379c8a529e This is the Samba bug report: https://bugzilla.samba.org/show_bug.cgi?id=13372 And here the author apologizes for the bug :) https://lists.samba.org/archive/samba-technical/2018-April/126937.html Please backport this fix to Ubuntu 14.04 and 18.04, thanks :) ProblemType: Bug DistroRelease: Ubuntu 14.04 Package: samba 2:4.3.11+dfsg-0ubuntu0.14.04.19 ProcVersionSignature: Ubuntu 3.13.0-164.214-generic 3.13.11-ckt39 Uname: Linux 3.13.0-164-generic x86_64 ApportVersion: 2.14.1-0ubuntu3.29 Architecture: amd64 BothFailedConnect: Yes Date: Mon Feb 4 11:34:06 2019 InstallationDate: Installed on 2014-09-25 (1592 days ago) InstallationMedia: Ubuntu-Server 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140722.3) SambaServerRegression: Yes SmbConfIncluded: No SourcePackage: samba UpgradeStatus: No upgrade log present (probably fresh install) upstart.samba-ad-dc.override: manual -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1814532] Re: Big samba memory leak fixed upstream
** Description changed: + [Impact] + + * An explanation of the effects of the bug on users and + + * justification for backporting the fix to the stable release. + + * In addition, it is helpful, but not required, to include an +explanation of how the upload fixes this bug. + + [Test Case] + + * detailed instructions how to reproduce the bug + + * these should allow someone who is not familiar with the affected +package to reproduce the bug and verify that the updated package fixes +the problem. + + [Regression Potential] + + * discussion of how regressions are most likely to manifest as a result + of this change. + + * It is assumed that any SRU candidate patch is well-tested before +upload and has a low overall risk of regression, but it's important +to make the effort to think about what ''could'' happen in the +event of a regression. + + * This both shows the SRU team that the risks have been considered, +and provides guidance to testers in regression-testing the SRU. + + [Other Info] + + * Anything else you think is useful to include + * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board + * and address these questions in advance + + [Original Description] + There is a big memory leak bug in Samba 4.1 - 4.7.6. Depending on the circumstances all memory of the Ubuntu server will be eaten by Samba sooner or later. Then Linux Oom - killer will kill Samba which will either restart or hang. On our Ubuntu Server 14.04.5 I need to restart Samba 1 - 2 times a week. This bug probably affects also Ubuntu 18.04 if this fix has not yet been backported. This bug has been fixed upstream in Samba 4.7.7. The fix is only two lines of code and the bug is caused by a single misplaced "if" when releasing memory. This upstream commit fixes the bug: https://gitlab.com/samba- team/samba/commit/461a1172ff819692aa0a2dc5ce7fc5379c8a529e This is the Samba bug report: https://bugzilla.samba.org/show_bug.cgi?id=13372 And here the author apologizes for the bug :) https://lists.samba.org/archive/samba-technical/2018-April/126937.html Please backport this fix to Ubuntu 14.04 and 18.04, thanks :) ProblemType: Bug DistroRelease: Ubuntu 14.04 Package: samba 2:4.3.11+dfsg-0ubuntu0.14.04.19 ProcVersionSignature: Ubuntu 3.13.0-164.214-generic 3.13.11-ckt39 Uname: Linux 3.13.0-164-generic x86_64 ApportVersion: 2.14.1-0ubuntu3.29 Architecture: amd64 BothFailedConnect: Yes Date: Mon Feb 4 11:34:06 2019 InstallationDate: Installed on 2014-09-25 (1592 days ago) InstallationMedia: Ubuntu-Server 14.04.1 LTS "Trusty Tahr" - Release amd64 (20140722.3) SambaServerRegression: Yes SmbConfIncluded: No SourcePackage: samba UpgradeStatus: No upgrade log present (probably fresh install) upstart.samba-ad-dc.override: manual -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1814532] Re: Big samba memory leak fixed upstream
Fixed in cosmic and later. ** Also affects: samba (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: samba (Ubuntu Cosmic) Importance: Undecided Status: New ** No longer affects: samba (Ubuntu Cosmic) ** Changed in: samba (Ubuntu) Status: New => Fix Released ** Changed in: samba (Ubuntu Bionic) Status: New => Triaged ** Changed in: samba (Ubuntu Bionic) Importance: Undecided => High ** Tags added: server-next -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to samba in Ubuntu. https://bugs.launchpad.net/bugs/1814532 Title: Big samba memory leak fixed upstream To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1814532/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
