This debdiff adds an upstart job for ntp. Upstart job does the same
thing SysV script does. In addition, it adds two features that are
common requirement in production:
1) does one off sync before starting ntpd in foreground - off by default
2) syncs hardware clock after the one off sync - off by
Found few typos. Fixed.
** Changed in: ntp (Ubuntu)
Assignee: (unassigned) = Ante Karamatić (ivoks)
** Patch added: ntp-final.debdiff
https://bugs.launchpad.net/ubuntu/+source/ntp/+bug/604717/+attachment/3662422/+files/ntp-final.debdiff
** Patch removed: ntp-final.debdiff
The ntp package provides /usr/sbin/ntp-wait
NTP can use this, or a similar technique, to emit an Upstart event when
the time is synchronised. It would be nice to be able to react to this
(although maybe not to block daemon startup indefinitely).
--
You received this bug notification because you
Ill fix up all of these mistakes and resubmit the debdiff, I did test
them but I guess I didnt hit these problems while testng them.
chuck
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug notification because you are a member of Ubuntu
Server
+ test -f /etc/default/ntp ./etc/default/ntp || true
Missing a space between '.' and '/etc/default/ntp'. This is probably
why you had to add the '|| true' - remove that. Also, to match the init
script this should be test -r not test -f.
+ test -e /var/lib/ntp.conf.dhcp
The last point may be skew between what I was reviewing and current
Maverick - a number of packages have been converted to dh_apparmor. I
haven't looked into exactly what's involved here.
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug
I agree with David's comment.
-invoke-rc.d --quiet ntp start /dev/null 21 || true
+start stop /dev/null 21 || true
This is wrong - should be 'start ntp'.
(Incomplete review; I still need to look at the job itself.)
--
Please convert init script to upstart
Should the dh_installinit really be marked upstart only? I am
thinking more about merging back to Debian or even backporting where
upstart may not be in use. Otherwise I think this patch looks fine, and
I may try a test build to verify it. I happen to agree ntp should
migrate to upstart.
--
** Tags added: patch
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to ntp in ubuntu.
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
** Changed in: ntp (Ubuntu)
Status: Confirmed = Triaged
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to ntp in ubuntu.
--
Ubuntu-server-bugs mailing
** Changed in: ntp (Ubuntu)
Importance: Undecided = Wishlist
** Changed in: ntp (Ubuntu)
Status: New = Confirmed
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug notification because you are a member of Ubuntu
Server Team, which is
** Attachment added: patch
http://launchpadlibrarian.net/51793594/patch
--
Please convert init script to upstart
https://bugs.launchpad.net/bugs/604717
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to ntp in ubuntu.
--
12 matches
Mail list logo
