Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-03 into lp:ubuntu-filemanager-app

2015-03-16 Thread Carlos Jose Mazieri
Thanks, That has been changed on MP 09 - https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09/+merge/252979 which finishes authentication stuff. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-03/+merge/252219 Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:401 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/489/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2363 deb:

[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot

2015-03-16 Thread Victor Thompson
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-revert-worker into lp:ubuntu-weather-app/reboot

2015-03-16 Thread Victor Thompson
Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-revert-worker into lp:ubuntu-weather-app/reboot. Commit message: * Revert WorkerScript, but still initialize app with stored data. Requested reviews: Ubuntu Weather Developers (ubuntu-weather-dev) Related bugs:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-01 into lp:ubuntu-filemanager-app

2015-03-16 Thread Carlos Jose Mazieri
Thanks, I will fix that. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-01/+merge/252216 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-03 into lp:ubuntu-filemanager-app

2015-03-16 Thread Carlos Jose Mazieri
Small typo in method name, otherwise fine. Let me know where so I can fix that. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-03/+merge/252219 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-03 into lp:ubuntu-filemanager-app

2015-03-16 Thread Arto Jalkanen
Small typo in method name, otherwise fine. Let me know where so I can fix that. Yeah sorry, those inlined comments are really hard to find. It's this: bool LocationsFactory::lastUrlNeedsAuthencation() const - bool LocationsFactory::lastUrlNeedsAuthentication() const --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:128 http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/126/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2357 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-rssreader-app/just_for_test into lp:ubuntu-rssreader-app

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:372 http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/328/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2358 deb:

[Ubuntu-touch-coreapps-reviewers] [Bug 1431365] Re: Tests fail at warning dialog A topic with that name already exists

2015-03-16 Thread Carla Sella
Looks like the problem is another one: http://jenkins.qa.ubuntu.com/job /vivid-touch-mako-smoke- daily/400/artifact/clientlogs/shorts_app/test_results.subunit/*view*/ If you look at the images of the failed tests with trv you can see most are stuck on inserting the feed URL:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-rssreader-app/just_for_test into lp:ubuntu-rssreader-app

2015-03-16 Thread Carla Sella
Test. -- https://code.launchpad.net/~carla-sella/ubuntu-rssreader-app/just_for_test/+merge/253122 Your team Ubuntu RSS Feed Reader Developers is requested to review the proposed merge of lp:~carla-sella/ubuntu-rssreader-app/just_for_test into lp:ubuntu-rssreader-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-02 into lp:ubuntu-filemanager-app

2015-03-16 Thread Carlos Jose Mazieri
The code already in place prevents this by setting the last item to null before parsing a new url/path, see http://bazaar.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-02/view/head:/src/plugin/folderlistmodel/locationsfactory.cpp#L109 and

[Ubuntu-touch-coreapps-reviewers] [Bug 1431365] Re: Tests fail at warning dialog A topic with that name already exists

2015-03-16 Thread Alan Pope 
It's certainly possible there's a network firewall in place. Have asked someone from Ci to comment. -- You received this bug notification because you are a member of Ubuntu RSS Feed Reader Developers, which is subscribed to Ubuntu RSS Feed Reader App. Matching subscriptions: Ubuntu RSS Reader

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app

2015-03-16 Thread Carlos Jose Mazieri
Carlos Jose Mazieri has proposed merging lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-final into lp:ubuntu-filemanager-app with lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-13 as a prerequisite. Commit message: It allows the filemager to browse Samba items by entering

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-09 into lp:ubuntu-filemanager-app

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:397 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/488/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2362 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-01 into lp:ubuntu-filemanager-app

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:387 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/485/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2359 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~flscogna/ubuntu-terminal-app/fix-1431558 into lp:ubuntu-terminal-app

2015-03-16 Thread Stefano Verzegnassi
Review: Approve LGTM! Great work Filippo, this fixes the issue! -- https://code.launchpad.net/~flscogna/ubuntu-terminal-app/fix-1431558/+merge/253011 Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~flscogna/ubuntu-terminal-app/fix-1431558 into

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-11 into lp:ubuntu-filemanager-app

2015-03-16 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:398 http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/484/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2356 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/edit-note-improvements into lp:reminders-app

2015-03-16 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/edit-note-improvements into lp:reminders-app has been updated. Commit Message changed to: Further improve edit dialog. More space for the actual content, implicitly save the note. For more details, see: