Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/qmltest1 into lp:reminders-app

2015-03-19 Thread Leo Arias
you rule. I'll review it tomorrow. Thanks! -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/qmltest1/+merge/239466 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post t

[Ubuntu-touch-coreapps-reviewers] [Bug 1228575] Re: Slider's tooltip too small sometimes

2015-03-19 Thread Nekhelesh Ramananthan
** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Confirmed => In Progress ** Changed in: ubuntu-ui-toolkit (Ubuntu) Assignee: (unassigned) => Nekhelesh Ramananthan (nik90) ** Branch linked: lp:~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width -- You received this bug notification be

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-weather-app/improved-settings-page into lp:ubuntu-weather-app/reboot

2015-03-19 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:21 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/54/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/24 SUCCESS: http://91.189.93.70:8080/job/ubuntu-

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-weather-app/improved-settings-page into lp:ubuntu-weather-app/reboot

2015-03-19 Thread Nekhelesh Ramananthan
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-weather-app/improved-settings-page into lp:ubuntu-weather-app/reboot. Commit message: Converted the settings page list items to the design followed by the clock app. In the process, the settings options are now properly translatable.

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/reenable-alarm-tests into lp:ubuntu-clock-app

2015-03-19 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:226 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/630/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2382 deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app

2015-03-19 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:296 http://91.189.93.70:8080/job/reminders-app-ci/723/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2381/console FAILURE: http://91.189.93.70:8080/job/reminders-app-uto

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/qmltest1 into lp:reminders-app

2015-03-19 Thread Michael Zanetti
Elopio, I took this and did some fixes and more tests on top of it. Mainly I wanted to set up an environment to test the full app in offline mode with qmltests. Seems to work quite nicely. If you have time, it'd be great to get a review. https://code.launchpad.net/~mzanetti/reminders-app/qmltes

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app

2015-03-19 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app has been updated. Description changed to: This uses elopio's branch for qmltests and adds some more. For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/qmltest2/+merge/253598 -- Your team Ubu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app

2015-03-19 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app. Commit message: Add some qmltests Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/qmltest2/+merge/25

[Ubuntu-touch-coreapps-reviewers] [Bug 1228575] Re: Slider's tooltip too small sometimes

2015-03-19 Thread Michal Predotka
Wanted to report a bug about this very problem but I see it's already reported. I'm attaching my screenshot anyway. ** Attachment added: "Screenshot at 22-13-39.png" https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1228575/+attachment/4350339/+files/Screenshot%20at%2022-13-39.p

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-19 Thread drizzle
Thank yuo for the quick feedback! I think I got the changes. Please let me know. :) -- https://code.launchpad.net/~darran-kelinske/music-app/lp_bug_1428454/+merge/253566 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-cor

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-19 Thread Andrew Hayzen
Review: Needs Fixing Looks good so far :) Just a few inline comments... L65, L75, L188 and possibly L140 - Could you remove this extra blank lines? (See PEP8 styling on this [0] - 2 lines for a class def and 1 for a method) L102 - Is there any reason for renaming this var and method call? Could

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-19 Thread noreply
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 -- Your te

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-19 Thread drizzle
drizzle has proposed merging lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app. Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1428454 in Ubuntu Music App: "Autopilot Testcase Needed: Delete a playlist" https://bugs.launchpad.net/music-app/+bug/1428

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-19 Thread Bartosz Kosiorek
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 -- Y

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app

2015-03-19 Thread noreply
The proposal to merge lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/underline-highlight/+merge/253284 -- Your team Ubuntu Reminders app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app

2015-03-19 Thread noreply
The proposal to merge lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/remove-sorting-close-button/+merge/253296 -- Your team Ubuntu Reminders a

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app

2015-03-19 Thread Alan Pope 
The proposal to merge lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/remove-sorting-close-button/+merge/253296 -- Your team Ubuntu Remin

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app

2015-03-19 Thread Alan Pope 
The proposal to merge lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/underline-highlight/+merge/253284 -- Your team Ubuntu Reminders app develop

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~flscogna/ubuntu-terminal-app/fix-1431558 into lp:ubuntu-terminal-app

2015-03-19 Thread Alan Pope 
The proposal to merge lp:~flscogna/ubuntu-terminal-app/fix-1431558 into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~flscogna/ubuntu-terminal-app/fix-1431558/+merge/253011 -- Your team Ubuntu Terminal Developers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-rssreader-app/unique-random-topic into lp:ubuntu-rssreader-app

2015-03-19 Thread Alan Pope 
Review: Approve Nice one, thanks Carla! -- https://code.launchpad.net/~carla-sella/ubuntu-rssreader-app/unique-random-topic/+merge/253281 Your team Ubuntu RSS Feed Reader Developers is subscribed to branch lp:ubuntu-rssreader-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-r

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~flscogna/ubuntu-terminal-app/fix-1431558 into lp:ubuntu-terminal-app

2015-03-19 Thread noreply
The proposal to merge lp:~flscogna/ubuntu-terminal-app/fix-1431558 into lp:ubuntu-terminal-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~flscogna/ubuntu-terminal-app/fix-1431558/+merge/253011 -- Your team Ubuntu Terminal Developers is re

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-sorting-close-button into lp:reminders-app

2015-03-19 Thread Alan Pope 
Review: Approve LGTM -- https://code.launchpad.net/~mzanetti/reminders-app/remove-sorting-close-button/+merge/253296 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app

2015-03-19 Thread Alan Pope 
Review: Approve LGTM -- https://code.launchpad.net/~mzanetti/reminders-app/underline-highlight/+merge/253284 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-co

[Ubuntu-touch-coreapps-reviewers] [Bug 1341681] Re: Autopilot tests should stop using deprecated emulators module

2015-03-19 Thread Launchpad Bug Tracker
This bug was fixed in the package unity8 - 8.02+15.04.20150318-0ubuntu1 --- unity8 (8.02+15.04.20150318-0ubuntu1) vivid; urgency=medium [ Albert Astals Cid ] * Add some context to tr calls (LP: #1431497) * Require binaries and .pc files we call from code * Test: More stubborn