[Ubuntu-touch-coreapps-reviewers] ubuntu-touch-coreapps-reviewers joined help-app-dev

2015-03-23 Thread Ubuntu Help app developers
Hello Ubuntu Core Apps Reviewers, Nicholas Skaggs (nskaggs) added Ubuntu Core Apps Reviewers (ubuntu- touch-coreapps-reviewers) (which you are a member of) as a member of Ubuntu Help app developers (help-app-dev). https://launchpad.net/~help-app-dev -- You received this email because

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:853 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-23 Thread Andrew Hayzen
The proposal to merge lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app has been updated. Commit Message changed to: * Added a test case for deleting a playlist For more details, see: https://code.launchpad.net/~darran-kelinske/music-app/lp_bug_1428454/+merge/253566 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app

2015-03-23 Thread SirVer
Sorry to interject in this code review, but the Widelands team is currently investigating using test bots on Launchpad that check pull requests. Your team seem to have managed to do that, could you share some insights/configuration hints/documentation about the process? Are you using a

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app

2015-03-23 Thread Riccardo Padovani
Review: Approve Okay, then looks good to me, thanks for the explanation! -- https://code.launchpad.net/~mzanetti/reminders-app/improve-error-handling/+merge/252227 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app

2015-03-23 Thread Riccardo Padovani
The proposal to merge lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-error-handling/+merge/252227 -- Your team Ubuntu Reminders app

[Ubuntu-touch-coreapps-reviewers] [Bug 1188713] Re: Autopilot Testcase Needed: Test feed list view

2015-03-23 Thread Nicholas Skaggs
@Carla, it sounds like this can be closed so I will do so. Thanks for following up. @drizzle, ideally we would have a mocked feed so we could validate correct entries etc. This has been explored in the past, but was found to be difficult due to the use of the google feed api. I imagine someone

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Andrew Hayzen
Note this pulls in lp:~ahayzen/music-app/async-loader-pages as well. -- https://code.launchpad.net/~ahayzen/music-app/refactor-pull-now-playing-sidebar/+merge/253839 Your team Music App Developers is requested to review the proposed merge of

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:848 http://91.189.93.70:8080/job/music-app-refactor-ci/49/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2398 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434125 into lp:help-app

2015-03-23 Thread Daniel Holbach
Ignore the last change. Overwrote the branch with old contents again. -- https://code.launchpad.net/~dholbach/help-app/1434125/+merge/253658 Your team Ubuntu Help app developers is subscribed to branch lp:help-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Andrew Hayzen
Andrew Hayzen has proposed merging lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor. Commit message: * Make NowPlaying into a conditional sidebar Requested reviews: Music App Developers (music-app-dev) For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434415 into lp:help-app

2015-03-23 Thread Daniel Holbach
Daniel Holbach has proposed merging lp:~dholbach/help-app/1434415 into lp:help-app. Requested reviews: Ubuntu Help app developers (help-app-dev) Related bugs: Bug #1434415 in Ubuntu Help App: Build fails on utopic https://bugs.launchpad.net/help-app/+bug/1434415 For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:849 http://91.189.93.70:8080/job/music-app-refactor-ci/50/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2399 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434125 into lp:help-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:131 http://91.189.93.70:8080/job/help-app-ci/4/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/help-app-utopic-amd64-ci/4/console FAILURE:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app

2015-03-23 Thread noreply
The proposal to merge lp:~mzanetti/reminders-app/improve-error-handling into lp:reminders-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-error-handling/+merge/252227 -- Your team Ubuntu Reminders app

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot

2015-03-23 Thread Bartosz Kosiorek
Review: Approve Looks ok to me. -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixBlankIcons/+merge/252544 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/DefDateTime into lp:ubuntu-calendar-app

2015-03-23 Thread noreply
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefDateTime into lp:ubuntu-calendar-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefDateTime/+merge/253451 -- Your team Ubuntu Calendar

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixBlankIcons/+merge/252544 -- Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Autolanding. More details in the following jenkins job: http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-autolanding/81/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2400 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-calendar-app/dayview-test-default-view into lp:ubuntu-calendar-app

2015-03-23 Thread Carla Sella
Reported bug #1435542 as in Italy Sunday is the first day of the week and yesterday, 22nd March the week number was 12 and not 11, so this test failed, but should not have: Traceback (most recent call last): File /usr/lib/python3/dist-packages/calendar_app/tests/test_dayview.py, line 77, in

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot

2015-03-23 Thread Bartosz Kosiorek
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixBlankIcons/+merge/252544 -- Your team Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app

2015-03-23 Thread Carlo Giordano
Carlo Giordano has proposed merging lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app. Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app

2015-03-23 Thread Carlo Giordano
Carlo Giordano has proposed merging lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app. Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Bug 1431368] Re: Add feed test fails

2015-03-23 Thread Felix Wilke
Hello, I have the BQ phone. And adding feed fails. What works: click add feed. search for feed. choose right feed what does not work: - choose topic for feed. - I can choose a topic or add a new one, but nothing happens. -- You received this bug notification because you are a member of Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app

2015-03-23 Thread Filippo Scognamiglio
Review: Approve Thank you Carlo! -- https://code.launchpad.net/~developersw/ubuntu-terminal-app/CarloSpenguinFix/+merge/253864 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~dholbach/help-app/1434415 into lp:help-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:122 No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app

2015-03-23 Thread Carlo Giordano
Carlo Giordano has proposed merging lp:~developersw/ubuntu-terminal-app/CarloSpenguinFix into lp:ubuntu-terminal-app. Requested reviews: Ubuntu Terminal Developers (ubuntu-terminal-dev) For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-23 Thread Andrew Hayzen
Review: Approve Awesome, thanks for submitting this :) Looks good to me! -- https://code.launchpad.net/~darran-kelinske/music-app/lp_bug_1428454/+merge/253566 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:297 http://91.189.93.70:8080/job/reminders-app-ci/730/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2401/console FAILURE:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar into lp:music-app/refactor

2015-03-23 Thread Victor Thompson
Currently there are issues with app rotation in vivid. These are fixed with the full implementation of shell rotation (which has not yet landed). This MP is more or less blocked from using autorotation until that lands in vivid and vivid becomes the stable channel. --

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/force-focus-dialogs into lp:music-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:850 http://91.189.93.70:8080/job/music-app-ci/1283/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2403 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration -- https://code.launchpad.net/~darran-kelinske/music-app/lp_bug_1428454/+merge/253566 Your team Music App Developers is subscribed to branch lp:music-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app

2015-03-23 Thread noreply
The proposal to merge lp:~darran-kelinske/music-app/lp_bug_1428454 into lp:music-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~darran-kelinske/music-app/lp_bug_1428454/+merge/253566 -- Your team Music App Developers is subscribed to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-force-focus-dialogs into lp:music-app/refactor

2015-03-23 Thread Victor Thompson
Victor Thompson has proposed merging lp:~vthompson/music-app/refactor-force-focus-dialogs into lp:music-app/refactor. Commit message: Force active focus to dialogs Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1435260 in Ubuntu Music App: TextFields in most

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-force-focus-dialogs into lp:music-app/refactor

2015-03-23 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:847 http://91.189.93.70:8080/job/music-app-refactor-ci/51/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2404 deb: