Review: Approve
Looks good to me, testing on krillin. Nice work!
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-setting-listitem/+merge/252930
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:250
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/642/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2595
deb:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:226
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/641/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2594
deb:
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/improved-bottomedge-header into lp:ubuntu-clock-app.
Commit message:
Improves the bottom edge header by showing the back button chevron pointing
downwards as suggested by design.
Requested reviews:
Ubuntu Clock Developers
Review: Needs Fixing
It might be all that's needed, I didn't do that yet as I didn't know if paths
wouldn't need to be changed for the tests to actually work (there are also some
unit tests there). The CMake seems to need some tweaking though.
--
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:123
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/195/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2596
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:164
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/302/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2598/console
FAILURE:
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/fixApDirectory into
lp:ubuntu-calculator-app.
Commit message:
Move AP directory to the root
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
Review: Needs Fixing
Without that path it is impossible to run autopilot tests locally.
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixApDirectory/+merge/256175
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
To fix autopilot tests please apply following patch:
=== modified file 'tests/autopilot/ubuntu_calculator_app/tests/__init__.py'
--- tests/autopilot/ubuntu_calculator_app/tests/__init__.py 2015-01-10
14:16:24 +
+++ tests/autopilot/ubuntu_calculator_app/tests/__init__.py 2015-04-14
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-fix-loosing-textfield-focus-during-using-keyboard
into lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Stefano Verzegnassi has proposed merging
lp:~verzegnassi-stefano/ubuntu-docviewer-app/landscape-support into
lp:ubuntu-docviewer-app.
Commit message:
Enabled landscape support
Requested reviews:
Ubuntu Document Viewer Developers (ubuntu-docviewer-dev)
Related bugs:
Bug #1428721 in Ubuntu
Thanks for the review. I'm fixing the autopilot test, which fails because I
removed a typo in the code (VerticalView Y origin was set to 560 instead of 0)
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/landscape-support/+merge/256146
Your team Ubuntu Document Viewer
Review: Approve continuous-integration
PASSED: Continuous integration, rev:124
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/196/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2597
deb:
Review: Approve
Works nicely on Meizu device. Thanks Stefano.
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/landscape-support/+merge/256146
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
The proposal to merge lp:~nik90/ubuntu-clock-app/improved-bottomedge-header
into lp:ubuntu-clock-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/improved-bottomedge-header/+merge/256129
--
Your team Ubuntu Clock
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-fix-loosing-textfield-focus-during-using-keyboard
into lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-fix-loosing-textfield-focus-during-using-keyboard
into lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/reboot-fix-loosing-textfield-focus-during-using-keyboard
into lp:ubuntu-calculator-app has been updated.
Status: Approved = Needs review
For more details, see:
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/fixApDirectory into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixApDirectory/+merge/256175
--
Your team Ubuntu
Review: Approve
Looks good indeed, thanks guys! We already poked the right people to actually
make phablet-click-test-setup a bit smarter (and the CI autopilot smoketesting
infrastructure as well), but until that happens this is actually a fix that
works.
Cheers!
--
The proposal to merge lp:~nik90/ubuntu-clock-app/improve-setting-listitem into
lp:ubuntu-clock-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/improve-setting-listitem/+merge/252930
--
Your team Ubuntu Clock
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-location-error-msg into
lp:ubuntu-clock-app has been updated.
Description changed to:
This MP removes the Location service error message which is shown when the
user denies clock app location access and also when the location service does
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-location-error-msg into lp:ubuntu-clock-app.
Commit message:
Removed the Location service error message which is shown when the user
denies clock app location access and also when the location service does not
work when
Review: Approve continuous-integration
PASSED: Continuous integration, rev:253
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/644/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2608
deb:
25 matches
Mail list logo
