Review: Needs Information
added inline comment
Diff comments:
>
> === modified file 'MonthComponentDateDelegate.qml'
> --- MonthComponentDateDelegate.qml2015-09-05 05:30:23 +
> +++ MonthComponentDateDelegate.qml2016-01-12 18:02:54 +
> @@ -9,20 +9,21 @@
> property bool
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Rejected => Needs review
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280405
--
Your team Ubuntu Calendar
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/280405
--
Your team Ubuntu Calendar
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1476032
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: "[Calendar] New
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: "[Calendar] New event defaults to
"Personal"
removed new event action from tray, this should resolve icon overlap issue
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Uitk1_3/+merge/276338
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
added a comment, otherwise code looks fine
Diff comments:
>
> === modified file 'TimeLineBase.qml'
> --- TimeLineBase.qml 2015-08-20 12:27:59 +
> +++ TimeLineBase.qml 2015-11-27 01:49:25 +
> @@ -221,28 +221,27 @@
> if (event.endDateTime - day == 0)
> return;
>
Thanks :), this changes seems fine to me, but need to test is once and then
approve it
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
I think easiest option is 2), and Yes I agree, there ware many ways to create
new event, but only one way to go to today. So I guess we should keep go to
today available and move new event to menu.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/Uitk1_3/+merge/276338
Your team
Seems like some jenkins issue "jenkins job parameter
[use_description_for_commit]: not found"
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekView-Scrolling/+merge/269564
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/Uitk1_3
into lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1508363
Migrating to UITK 1.3
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Calendar Developers (ubuntu
** Branch linked: lp:~pkunal-parmar/ubuntu-calendar-app/Uitk1_3
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1508363
Title:
Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/DefView
into lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1494394
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/SyncSelection into lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1475747
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~pkunal-parmar
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/WeekView-Scrolling into
lp:ubuntu-calendar-app.
Commit message:
Changed week view scrolling to resolve Bug #1473682
Requested reviews:
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot):
continuous
Please check once more, I tried to adjust some parameters
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/MonthView-Indicator/+merge/266655
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/LongPressToCreate into
lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1473679
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1473679 in Ubuntu Calendar App: [Calendar
Thanks, I updated the MR
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefCalendar/+merge/264990
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/MonthView-Indicator into
lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1479533
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1479533 in Ubuntu Calendar App: Monthly
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week into
lp:ubuntu-calendar-app.
Commit message:
By default no selection in weekview, this is current implementation in
MonthView as well
Requested reviews:
Ubuntu Calendar Developers (ubuntu
as its been approved by mihir I am top approving it
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat/+merge/264488
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat/+merge/264488
--
Your team Ubuntu
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal/+merge/261075
--
Your team Ubuntu Calendar
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
--
Your team Ubuntu
Text conflict in EventDetails.qml
1 conflicts encountered.
bzr: ERROR: Conflicts from merge
Jenkins is set to merge this once it's fixed.
Thanks nick, I will do the needful
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal/+merge/261075
Your team Ubuntu
AP fails does not seem like regression from this MR, but not sure why testcases
are failing ramdomly
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefCalendar into lp:ubuntu-calendar-app.
Commit message:
resolves Bug #1369543
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1369543 in Ubuntu Calendar App: [Calendar] New event
Thanks Gang65,
Seems like some issue with AP, I will have a look and try to fix it.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/ReminderRepeat into
lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1470583
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~pkunal-parmar
Just so that I don't forget.
We need to see how this behave in case of Edit event case
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal/+merge/261075
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Thanks kunal.
Two more issues.
Swipe between months, I'd expect no day to be hi-lighted, but the 1st of the
month always is.
Sometimes I can trigger a situation where a day is hi-lighted with grey box
_and_ has orange in-fill... *and* today is highlighted in orange too. Not
quite sure
so I added debug logs to analyse the issue, it seems the patch from EDS is not
available or installed in jenkins.
which is why calendar is not able to read extended
property(collection-readonly) from EDS and test cases are failing.
qml: Personal undefined
qml: Personal undefined
ok, I was able to test it, to me this seems EDS issue. see below log
Following is start and end date time for All day event for single day
qml: Thu Jun 11 00:00:00 2015 GMT+0900---Thu Jun 11 00:00:00 2015 GMT+0900
We get following start and end date time for recurrent all day event
qml: Thu Jun
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/ReadOnlyCal into lp:ubuntu-calendar-app.
Commit message:
resolves bug #1347836
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1347836 in Ubuntu Calendar App: Events saved
I am not sure, when I tried to add all day event on my desktop. I see below
start and end date and see only one all day event.
qml: Thu Jun 4 00:00:00 2015 GMT+0900---Thu Jun 4 00:00:00 2015 GMT+0900
-
var key = Qt.formatDateTime(d, dd-MMM-);
if(
Review: Approve
looks good to me
--
https://code.launchpad.net/~popey/ubuntu-calendar-app/fix_weekview/+merge/260689
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Could you try to make the list item at least the same size as the
others account items. And the google icon the same size as the
calendar color rectangle.
Hi, I tried to address your comment, can you have another look
--
Hi Andrea, Your comment was very helpful.
Now I modified the code, can you have a another look.
Thanks
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/EventColorOnMonth into
lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1454657
Color changed to Black for event on MonthView
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/MonthHighlight into
lp:ubuntu-calendar-app.
Commit message:
Resolves #1432640
First tap set the highlight and then react to tap
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see
We need proper UI design for this
What should happen if cell is both selected and today, how should highlight
look.
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/MonthHighlight/+merge/259323
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/WeekViewHighlight into
lp:ubuntu-calendar-app.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekViewHighlight
The proposal to merge
lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449
The proposal to merge
lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
performance tuning
For more details, see:
http://pastebin.ubuntu.com/11130951/
for reference
--
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation/+merge/255234
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~pkunal-parmar/ubuntu-calendar-app/UrlInvocation into
The proposal to merge
lp:~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449
Review: Approve
looks good to me, thanks for MR
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
sorry forgot about this MR, I will test this today night before calendar
meeting and approve.
--
https://code.launchpad.net/~gary-wzl77/ubuntu-calendar-app/dynamic_creation_perf_tunning/+merge/258449
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekNumber/+merge/255078
--
Your team Ubuntu Calendar
Review: Approve
looks fine to me
--
https://code.launchpad.net/~ken-vandine/ubuntu-calendar-app/url_settings_fix/+merge/257571
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Originally we were destroying Pages to conserve memory, but it that's not issue
anymore. Then this MR looks good to me.
I will test some more and approve it.
Thanks for MR and taking your time to improve calendar
--
@Kunal: Great! Thanks that's very useful. I have only one doubt though: I have
set locale en_US on my desktop but the firstDayOfWeek property is equal to 0 I
would expect it to be 6. If I set locale to it_IT firstDayOfWeek property
equals 1, I would expect it to be 0.
I can fix the code to
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/DefReminderTime into
lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1419001
Setting default reminder time to 15 min
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1419001
Was this visuals specified by the Designers? I would prefer to have a add
new button on the header. What do you think?
We were requested to put button below the list, so yes. But using google's icon
was not part of it.
If using google's icon is not preferable then I can remove it.
--
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekNumber into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/WeekNumber/+merge/255078
--
Your team Ubuntu Calendar
Review: Needs Fixing
I added comment inline, anyway I am proposing another MR for this fix.
Diff comments:
=== modified file 'EventRepetition.qml'
--- EventRepetition.qml 2014-10-22 14:03:01 +
+++ EventRepetition.qml 2015-04-03 16:45:43 +
@@ -100,8 +100,23 @@
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/Monthly-YearlyEvent into
lp:ubuntu-calendar-app.
Commit message:
resolves https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1438910
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/482/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2485
deb: http://91.189.93.70:8080/job/generic-mediumtests-
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/CalendarIcon into
lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/CalendarIcon/+merge/254178
--
Your team Ubuntu
Tapping created an event at 21:26, I think it should create an event which
locks to the nearest 30 minutes.
As per current implementation we are truncating minutes and creating event for
currently touched hour.
It should have created event rounding to hour, for your case it should have
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent into
lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1378380
Add event on tap
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1378380 in Ubuntu Calendar App
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/bug_1413462 into lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1413462
Resetting seconds to 0 before setting the date
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see
Review: Approve code review
Code wise patch seems good
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
64 matches
Mail list logo
