[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snap-mir into lp:reminders-app

2017-02-10 Thread Michael Zanetti
The proposal to merge lp:~renatofilho/reminders-app/snap-mir into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/reminders-app/snap-mir/+merge/316876 -- Your team Ubuntu Notes app developers is subscribed

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snap-mir into lp:reminders-app

2017-02-10 Thread Michael Zanetti
The proposal to merge lp:~renatofilho/reminders-app/snap-mir into lp:reminders-app has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~renatofilho/reminders-app/snap-mir/+merge/316876 -- Your team Ubuntu Notes app developers is subscribed

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snap-mir into lp:reminders-app

2017-02-10 Thread Michael Zanetti
Review: Approve lgtm -- https://code.launchpad.net/~renatofilho/reminders-app/snap-mir/+merge/316876 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2016-11-08 Thread Michael Zanetti
** Changed in: reminders-app (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app

2016-07-12 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/ubuntu-filemanager-app/share-files into lp:ubuntu-filemanager-app. Commit message: Add support for sharing files via contenthub on longpress Requested reviews: Ubuntu File Manager Developers (ubuntu-filemanager-dev) Related bugs: Bug

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/reminders-app/crossbuild_fixes into lp:reminders-app

2016-07-07 Thread Michael Zanetti
Review: Approve lgtm -- https://code.launchpad.net/~fboucault/reminders-app/crossbuild_fixes/+merge/299206 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~fboucault/reminders-app/crossbuild_fixes into lp:reminders-app

2016-07-07 Thread Michael Zanetti
The proposal to merge lp:~fboucault/reminders-app/crossbuild_fixes into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fboucault/reminders-app/crossbuild_fixes/+merge/299206 -- Your team Ubuntu Notes app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mterry/reminders-app/no-ubuntucolors into lp:reminders-app

2016-06-06 Thread Michael Zanetti
The proposal to merge lp:~mterry/reminders-app/no-ubuntucolors into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mterry/reminders-app/no-ubuntucolors/+merge/295460 -- Your team Ubuntu Notes app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/translations-fixes into lp:reminders-app

2016-05-28 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/translations-fixes into lp:reminders-app. Commit message: update translations Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/translations

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~timo-jyrinki/reminders-app/stop_depending_on_transitional_packages into lp:reminders-app

2016-05-18 Thread Michael Zanetti
Review: Approve ack. thanks! -- https://code.launchpad.net/~timo-jyrinki/reminders-app/stop_depending_on_transitional_packages/+merge/295043 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~timo-jyrinki/reminders-app/stop_depending_on_transitional_packages into lp:reminders-app

2016-05-18 Thread Michael Zanetti
The proposal to merge lp:~timo-jyrinki/reminders-app/stop_depending_on_transitional_packages into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/section-separator into lp:reminders-app

2016-05-03 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/section-separator into lp:reminders-app. Commit message: Add a separator to section headers Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mzanetti/reminders-app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/textarea into lp:reminders-app

2016-04-30 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/textarea into lp:reminders-app has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/textarea/+merge/253286 -- Your team Ubuntu Notes app developers is requested to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/textarea into lp:reminders-app

2016-04-30 Thread Michael Zanetti
this change was done with another branch -- https://code.launchpad.net/~mzanetti/reminders-app/textarea/+merge/253286 Your team Ubuntu Notes app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/textarea into lp:reminders-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app

2016-04-30 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/fix-1576139 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 -- Your team Ubuntu Notes app developers is subscribed to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576139 into lp:reminders-app

2016-04-30 Thread Michael Zanetti
Review: Approve as james said, good to go -- https://code.launchpad.net/~popey/reminders-app/fix-1576139/+merge/293298 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1576140 into lp:reminders-app

2016-04-30 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/fix-1576140 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1576140/+merge/293288 -- Your team Ubuntu Notes app developers is requested to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app

2016-04-30 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/improve-tags-dialog into lp:reminders-app. Commit message: Improve tags dialog Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Ubuntu Notes app developers (notes-app-dev) Related bugs

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-edit-button into lp:reminders-app

2016-04-29 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-edit-button into lp:reminders-app. Commit message: fix the edit button Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-edit-button

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/remove-stale-lock-files into lp:reminders-app

2016-04-29 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/remove-stale-lock-files into lp:reminders-app. Commit message: Cleanup stale .lock files. This might happen if the app is stopped in the middle of processing a note and would cause it to wait for the lock release forever on next

[Ubuntu-touch-coreapps-reviewers] [Bug 1554621] Re: Invalid use of palette apparent with new SDK

2016-04-01 Thread Michael Zanetti
** Changed in: tagger Status: New => Fix Released ** Changed in: tagger Assignee: (unassigned) => Michael Zanetti (mzanetti) -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Ma

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

2016-03-07 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mardy/reminders-app/new-api into lp:reminders-app. Commit message: Use the new Online Accounts API and hook format Requested reviews: Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app

2016-03-02 Thread Michael Zanetti
The proposal to merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 -- Your team Ubuntu Notes app developers is subscribed to

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mpt/reminders-app/1551780-setup into lp:reminders-app

2016-03-02 Thread Michael Zanetti
The proposal to merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app has been updated. Commit Message changed to: update some strings For more details, see: https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658 -- Your team Ubuntu Notes app developers is

[Ubuntu-touch-coreapps-reviewers] [Bug 1552100] Re: Move to .snap

2016-03-02 Thread Michael Zanetti
** Changed in: telegram-app Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1552100

[Ubuntu-touch-coreapps-reviewers] [Bug 1552100] Re: Move to .snap

2016-03-02 Thread Michael Zanetti
** Changed in: telegram-app Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail https://bugs.launchpad.net/bugs/1552100

[Ubuntu-touch-coreapps-reviewers] [Bug 1508363] Re: Coordinated migration to UITK 1.3

2016-01-28 Thread Michael Zanetti
** Changed in: tagger Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Shorts Developers, which is subscribed to Ubuntu Shorts App. Matching subscriptions: Ubuntu RSS Reader Bugmail https://bugs.launchpad.net/bugs/1508363 Title:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-calculator-app/fix-icon-in-layout into lp:ubuntu-calculator-app

2015-11-27 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/ubuntu-calculator-app/fix-icon-in-layout into lp:ubuntu-calculator-app. Commit message: fix Icon in layout The Icon seems a bit picky when it comes to sizing. RowLayout doesn't care about the size of items, it overwrites them. The combination

[Ubuntu-touch-coreapps-reviewers] [Bug 1520160] Re: File Manager app without authentication

2015-11-26 Thread Michael Zanetti
ah nice. So a submission would be very straight forward. The bigger issue (even if not particularly big either) is keeping it up to date. So we'd need someone that submits the terminal app to the open store each time it is updated in the official store. -- You received this bug notification

[Ubuntu-touch-coreapps-reviewers] [Bug 1520160] Re: File Manager app without authentication

2015-11-26 Thread Michael Zanetti
sorry, I obviously meant file manager app... (I would happily hand over submission of the terminal app to someone else too btw.) -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

2015-11-20 Thread Michael Zanetti
Putting it to Work in Proress because this triggers a bug in QML in some cases. Better not having the nice animations than breaking sometimes. TODO: On Qt upgrades of the platform enable this and test if deleting items behaves properly and doesn't mess up the list. Maybe we can land it some

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app

2015-11-20 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app has been updated. Commit Message changed to: workaround to disable the buggy two column mode on nexus 7 for now. The whole 2-column logic currently is a self-made thing that is subject to be replaced with

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

2015-11-20 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/animated-delete/+merge/261904 -- Your team Ubuntu Notes app developers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app

2015-11-20 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/no-2-cols-on-flo into lp:reminders-app. Commit message: workaround to disable the buggy two column mode on nexus 7 for now. The whole 2-column logic currently is a self-made thing that is subject to be replaced

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/new-notebook-input into lp:reminders-app

2015-11-13 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/new-notebook-input into lp:reminders-app. Commit message: Fix the input field for new notebook in regard to predictive OSK Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app

2015-11-03 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/bump-framework/+merge/275621 -- Your team Ubuntu Notes app developers is

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/qmltest2 into lp:reminders-app

2015-11-02 Thread Michael Zanetti
> Bah, this should work now, but: > > Merging 'lp:reminders-app' in to 'build_dir'. > Text conflict in src/app/qml/components/NoteHeader.qml > Text conflict in src/app/qml/components/SortingDialog.qml merged -- https://code.launchpad.net/~mzanetti/reminders-app/qmltest2/+merge/253598 Your team

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app

2015-10-24 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app has been updated. Commit Message changed to: bump to framework 15.04.1 ... now that the framework exists and we're using uitk 1.3 For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app

2015-10-24 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/bump-framework into lp:reminders-app. Commit message: bump to framework 15.04.1 ... now that the framework exists and we're using uitk 1.3 Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/detect-qtmm-version into lp:ubuntu-clock-app

2015-10-22 Thread Michael Zanetti
fixed the inline comment. For me, the volume controls during preview were working fine. Probably the issue was because before it was using the "alert" role, which seems to be wrong in any case. As written in the description, I'm not really sure if we should merge this branch, or instead just

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app

2015-10-22 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app has been updated. Commit Message changed to: drop alarm preview's audioRole This doesn't really work as expected anyways and would cause issues with an upcoming API change after upstreaming the roles

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app

2015-10-22 Thread Michael Zanetti
Thanks Bartosz. I've added a more explicit hint to Qt 5.5 to the commit message. -- https://code.launchpad.net/~mzanetti/ubuntu-clock-app/drop-audioRole/+merge/275179 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app

2015-10-21 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app. Commit message: drop alarm preview's audioRole This doesn't really work as expected anyways and would cause issues with an upcoming API change after upstreaming the roles patch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app

2015-10-21 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/ubuntu-clock-app/drop-audioRole into lp:ubuntu-clock-app has been updated. Description changed to: This is a somewhat radical approach to get past the upcoming api breakage. A more sophisticated approach can be found here:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/fix-predictive-text into lp:reminders-app

2015-10-08 Thread Michael Zanetti
Review: Approve thanks! -- https://code.launchpad.net/~rpadovani/reminders-app/fix-predictive-text/+merge/271839 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/fix-predictive-text into lp:reminders-app

2015-10-08 Thread Michael Zanetti
The proposal to merge lp:~rpadovani/reminders-app/fix-predictive-text into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/reminders-app/fix-predictive-text/+merge/271839 -- Your team Ubuntu Notes app

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/update-pot-sep15 into lp:reminders-app

2015-09-21 Thread Michael Zanetti
Review: Approve thanks Riccardo! -- https://code.launchpad.net/~rpadovani/reminders-app/update-pot-sep15/+merge/271841 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/update-pot-sep15 into lp:reminders-app

2015-09-21 Thread Michael Zanetti
The proposal to merge lp:~rpadovani/reminders-app/update-pot-sep15 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/reminders-app/update-pot-sep15/+merge/271841 -- Your team Ubuntu Notes app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mardy/reminders-app/new-api into lp:reminders-app

2015-09-17 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mardy/reminders-app/new-api into lp:reminders-app. Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mardy/reminders-app/new-api/+merge/271505 -- Your team Ubuntu Notes app developers

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/align-imports into lp:reminders-app

2015-09-15 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/align-imports into lp:reminders-app. Commit message: align all sdk imports to 1.3 Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/align

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app

2015-09-10 Thread Michael Zanetti
The proposal to merge lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rpadovani/reminders-app/predictiveTextTagInsertion/+merge/266215 -- Your team Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-textfields into lp:reminders-app

2015-09-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-textfields into lp:reminders-app with lp:~rpadovani/reminders-app/predictiveTextTagInsertion as a prerequisite. Commit message: fix predictive text input Requested reviews: Ubuntu Notes app developers (notes-app-dev

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-edit-focus into lp:reminders-app

2015-09-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/improve-edit-focus into lp:reminders-app. Commit message: Improve focus handling when entering EditNoteView Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https://code.launchpad.net

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app

2015-09-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app. Commit message: Fix the missing icon for unchecked checkboxes in EditNoteView Requested reviews: Ubuntu Notes app developers (notes-app-dev) For more details, see: https

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app

2015-09-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-missing-checkbox into lp:reminders-app with lp:~mzanetti/reminders-app/workaround-oxide-race as a prerequisite. Commit message: Fix the missing icon for unchecked checkboxes in EditNoteView Requested reviews: Ubuntu Notes

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/workaround-oxide-race into lp:reminders-app

2015-09-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/workaround-oxide-race into lp:reminders-app. Commit message: workaround oxide race condition Requested reviews: Ubuntu Notes app developers (notes-app-dev) Related bugs: Bug #1471779 in Ubuntu Notes app: "WebView.loa

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app

2015-08-25 Thread Michael Zanetti
interesting... no idea where that message comes from. -- https://code.launchpad.net/~mzanetti/reminders-app/fix-writeback-issue/+merge/263848 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/revert-copyright-header-change into lp:ubuntu-clock-app

2015-08-24 Thread Michael Zanetti
Hi, not that I'd have big problems with you reusing my code (I find it quite awesome actually) but in order to be *correct* with licensing it is probably better to fix this indeed. So thanks for that. Some comments: * I think the This file is part of ... can be dropped. The important parts to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app

2015-08-23 Thread Michael Zanetti
Diff comments: === modified file 'CMakeLists.txt' --- CMakeLists.txt2015-06-14 23:34:29 + +++ CMakeLists.txt2015-07-05 19:26:31 + @@ -20,7 +20,7 @@ set(AUTOPILOT_DIR reminders) set(APP_HARDCODE reminders) set(MAIN_QML ${APP_HARDCODE}.qml) -set(EXEC reminders %u)

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app

2015-07-29 Thread Michael Zanetti
Thanks a lot. I believe there are more of this throughout the app. Mind walking through them? I'm thinking of create/rename notebook, search for notes etc. -- https://code.launchpad.net/~rpadovani/reminders-app/predictiveTextTagInsertion/+merge/266215 Your team Ubuntu Reminders app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app

2015-07-24 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/uitk-1.3 into lp:reminders-app. Commit message: update to Ubuntu.Components 1.3 this allows us to use uitk's TextArea and finally enable copy/paste Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-label-wrapping into lp:reminders-app

2015-07-24 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-label-wrapping into lp:reminders-app. Commit message: fix label growing out of place Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https://code.launchpad.net/~mzanetti

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app

2015-07-05 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-writeback-issue into lp:reminders-app. Commit message: some improvements in job handling: * treat write operations with highest priority * don't dedupe or reorder write operations * don't update the local note after a write

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-viewer into lp:reminders-app

2015-06-21 Thread Michael Zanetti
[Tablet mode] Choose a note, then choose another note, the note preview goes over the header. fixed You forgot to remove a reference to a componenent you delete: src/app/qml/ui/EditNoteView.qml:35: ReferenceError: notebookSelector is not defined fixed. [Tablet mode] Cannot create a

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

2015-06-15 Thread Michael Zanetti
Hmm... not so sure about this one any more. Problem is that it seems to mess up the notes list because of the section headers... -- https://code.launchpad.net/~mzanetti/reminders-app/animated-delete/+merge/261904 Your team Ubuntu Reminders app developers is subscribed to branch

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app

2015-06-13 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/animated-delete into lp:reminders-app. Commit message: Add an animation when deleting things Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https://code.launchpad.net/~mzanetti

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/improve-edit-tags into lp:reminders-app

2015-06-12 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/improve-edit-tags into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/improve-edit-tags/+merge/261779 -- Your team Ubuntu Reminders app developers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/enable-deleting-notebooks-and-tags into lp:reminders-app

2015-06-11 Thread Michael Zanetti
There are a lot of warnings due your changes: http://paste.ubuntu.com/11698283/ Also, there is a strange warning in qml when you delete a tag which has notes attached: it says `Sync: Save tag job finished, but tag can't be found any more` This is really a minor issue, but as console

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-count-when-sorting into lp:reminders-app

2015-06-11 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-count-when-sorting into lp:reminders-app. Commit message: fix section count when sorting by something else than created date Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/store-local-resources-in-infofile into lp:reminders-app

2015-06-03 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/store-local-resources-in-infofile into lp:reminders-app. Commit message: Store locally attached resources into the info file Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1461622

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-rename into lp:reminders-app

2015-06-01 Thread Michael Zanetti
Review: Approve As agreed on etherpad and IRC :) Thanks -- https://code.launchpad.net/~popey/reminders-app/fix-rename/+merge/260690 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-rename into lp:reminders-app

2015-06-01 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/fix-rename into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-rename/+merge/260690 -- Your team Ubuntu Reminders app developers is subscribed to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread Michael Zanetti
Review: Approve yeehaa! I propose following plan: a) Build a package with the 3 critical fixes, the rename and the icon b) Distribute it for testing to some known users c) Contact Evernote to update the key's name from Reminders to Notes --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-28 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/fix-1434500 into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/fix-1434500/+merge/253651 -- Your team Ubuntu Reminders app developers is subscribed to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

2015-05-27 Thread Michael Zanetti
Review: Needs Fixing Diff comments: === modified file 'com.ubuntu.reminders.desktop.in.in' --- com.ubuntu.reminders.desktop.in.in2014-09-28 08:31:38 + +++ com.ubuntu.reminders.desktop.in.in2015-03-20 11:17:24 + @@ -1,6 +1,6 @@ [Desktop Entry] -_Name=Reminders

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-empty-title into lp:reminders-app

2015-05-27 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-empty-title into lp:reminders-app. Commit message: Don't break when there's a note with an empty title Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1449130 in Ubuntu Notes app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/cleanup-pages into lp:reminders-app

2015-05-27 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/cleanup-pages into lp:reminders-app. Commit message: don't create pages manually as the pageStack won't delete them This caused us to leak all the pages and cause weird issues in the editnoteview Requested reviews: Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/save-on-inactive into lp:reminders-app

2015-05-27 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/save-on-inactive into lp:reminders-app. Commit message: save the note when the app becomes inactive Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1459430 in Ubuntu Notes app: Closing

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/reminders-app/update-icon into lp:reminders-app

2015-05-21 Thread Michael Zanetti
The proposal to merge lp:~popey/reminders-app/update-icon into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~popey/reminders-app/update-icon/+merge/259752 -- Your team Ubuntu Reminders app developers is requested to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1418648 into lp:ubuntu-docviewer-app

2015-05-15 Thread Michael Zanetti
Review: Needs Fixing Diff comments: === modified file 'po/com.ubuntu.docviewer.pot' --- po/com.ubuntu.docviewer.pot 2015-04-13 15:56:00 + +++ po/com.ubuntu.docviewer.pot 2015-04-15 16:13:49 + @@ -8,7 +8,7 @@ msgstr Project-Id-Version: \n Report-Msgid-Bugs-To: \n

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app

2015-05-08 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 -- Your team Ubuntu Reminders app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app

2015-05-08 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-renderwidth/+merge/258564 -- Your team Ubuntu Reminders app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app

2015-05-08 Thread Michael Zanetti
The proposal to merge lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 -- Your team Ubuntu Reminders

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~canonical-platform-qa/reminders-app/update_token into lp:reminders-app

2015-05-08 Thread Michael Zanetti
Review: Approve pass! -- https://code.launchpad.net/~canonical-platform-qa/reminders-app/update_token/+merge/258646 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

2015-05-08 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566 -- Your team Ubuntu Reminders app developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

2015-05-07 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app. Commit message: do it manually.. AbstractButton is not clever enough... Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1452907 in Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app

2015-05-07 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-renderwidth into lp:reminders-app. Commit message: Fix setting the note's renderwidth Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1452898 in Ubuntu Reminders app: Photos

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

2015-05-07 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app with lp:~mzanetti/reminders-app/fix-renderwidth as a prerequisite. Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1452907 in Ubuntu Reminders app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app

2015-04-27 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app. Commit message: Take the focus on closing for real Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https://code.launchpad.net/~mzanetti

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/update-translations into lp:reminders-app

2015-04-16 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/update-translations into lp:reminders-app. Commit message: update translations Requested reviews: Riccardo Padovani (rpadovani) Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot): continuous-integration For more

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/first-start-localization into lp:reminders-app

2015-04-13 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/first-start-localization into lp:reminders-app. Commit message: Fix first start dialog localization Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) Related bugs: Bug #1442614 in Ubuntu Reminders app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app

2015-04-10 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app. Commit message: fix data loss because of stale -qt tags in the markup Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app

2015-04-10 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app has been updated. Description changed to: I caught a data loss bug that happened with a note of mine. Afaiu, this can happen if you create a note with reminders and just add some empty lines (paragraphs).

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app

2015-04-10 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/fix-stale-qt-tags into lp:reminders-app has been updated. Description changed to: I caught a data loss bug that happened with a note of mine. Afaiu, this can happen if you create a note with reminders and just add some empty lines (paragraphs).

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-autocorrection-formatting into lp:reminders-app

2015-04-09 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/fix-autocorrection-formatting into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/fix-autocorrection-formatting/+merge/255736 -- Your team Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/confirm-autocorrection-on-save into lp:reminders-app

2015-04-09 Thread Michael Zanetti
The proposal to merge lp:~mzanetti/reminders-app/confirm-autocorrection-on-save into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/confirm-autocorrection-on-save/+merge/255730 -- Your team Ubuntu

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-autocorrection-formatting into lp:reminders-app

2015-04-09 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-autocorrection-formatting into lp:reminders-app with lp:~mzanetti/reminders-app/confirm-autocorrection-on-save as a prerequisite. Commit message: fix formatting with autocorrection enabled Requested reviews: Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/bottom-edge-hint into lp:reminders-app

2015-04-08 Thread Michael Zanetti
Actually, don't you have to update the .pot file too? I thought nowadays we do one translation update right before putting out the call for translators. Decreases risk of conflicts between branches. -- https://code.launchpad.net/~mzanetti/reminders-app/bottom-edge-hint/+merge/255240 Your team

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/reminders-app/improveListItemSwipe into lp:reminders-app

2015-04-05 Thread Michael Zanetti
The proposal to merge lp:~rpadovani/reminders-app/improveListItemSwipe into lp:reminders-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rpadovani/reminders-app/improveListItemSwipe/+merge/254748 -- Your team Ubuntu Reminders app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/bottom-edge-hint into lp:reminders-app

2015-04-05 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/bottom-edge-hint into lp:reminders-app. Commit message: Update the hint on how to create new notes when there are no notes. Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see: https

  1   2   >