Review: Needs Fixing
Note: This review was done BEFORE rev 493. I will test rev 493 tonight and
comment tomorrow.
As mentioned by Bartosz earlier, after testing I feel that the behaviour is
still a bit finicky. Here are a couple of issues that I noticed while testing,
1. In the stopwatch
Review: Needs Fixing
Hi Eran, Thanks for your patch!
Don't get me wrong, but moving the edit action which is an important action to
the trailing edge feels like a crime :P. I feel it would be best to improve the
current situation by increasing the touch area of the switch. This way we fix
the
Review: Needs Fixing
I have to say this is quite impressive :) to think of this way to implement a
feature that is not supported by the backend. I'm still trying to wrap my mind
around the logic to see if I can find any loop holes where it might not work. I
will test this feature for 2-3 days
Hello, thanks a lot for the patch. Let me try to explain why the
preventStealing: true line is present considering that I wrote it several
months ago. The whole laps list is inside a MouseArea object to ensure that the
laps listview does not conflict with the mainpage listview which houses
Review: Approve
I suppose disabling them when they are not visible seems appropriate and works
nicely. Frankly I would like to see the SDK provide a way to unload unused
headers either by supporting QML Loaders, since these kind of issues shouldn't
be there in the first place.
--
Review: Approve code
LGTM!
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903/+merge/291142
Your team Ubuntu Document Viewer Developers is requested to review the proposed
merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1566903 into
Review: Needs Information
Why not load the textfield dynamically. This way when it is loaded, it
automatically gets focus and shows OSK, and when it is unloaded, the OSK also
hides. And you save a tiny memory footprint :P. Also this way you don't need to
force focus on the scrollView on
Review: Approve testing
Works as expected and fixed the bug! LGTM!
--
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1539982/+merge/290035
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
> > On testing on the device, I found that clicking the event in the indicator
> > opens the calendar app in the Day View (nice!) rather than the
> month/year/week
> > view. It also nicely positions the hours close to the event. However it does
> > not show the event details page which is critical
> > On testing on the device, I found that clicking the event in the indicator
> > opens the calendar app in the Day View (nice!) rather than the
> month/year/week
> > view. It also nicely positions the hours close to the event. However it does
> > not show the event details page which is critical
Review: Approve
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1439049/+merge/289198
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Information
--
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1556946/+merge/289838
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Szymon is working on the new event page and has already fixed the issues in
this MP. The only thing still left is for him to merge trunk (fix conflicts)
and then approve. His MP can be found at
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page/+merge/288637.
Renato
Review: Needs Fixing
@nikwen, Hi there, we're looking to release calendar v0.5 with OTA-10. I would
like to get this bug fix into trunk before that. Can we work on getting this
done?
I have two questions,
1. why at all do we need i18n.tr() calls? Can we just do "%1 %2".arg().arg()
which
The proposal to merge lp:~dpniel/ubuntu-calendar-app/ScrollView2 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~dpniel/ubuntu-calendar-app/ScrollView2/+merge/285027
--
Your team Ubuntu Calendar
Review: Needs Fixing
On testing on the device, I found that clicking the event in the indicator
opens the calendar app in the Day View (nice!) rather than the month/year/week
view. It also nicely positions the hours close to the event. However it does
not show the event details page which is
The proposal to merge lp:~renatofilho/ubuntu-calendar-app/fix-1470583 into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1470583/+merge/289705
--
Your team Ubuntu Calendar
Review: Approve
Code makes sense and looks good. On testing, it does work as expected as well.
Approving!
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-1470583/+merge/289705
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
I just clean wiped and reflashed my Nexus4 test device running rc-proposed
channels. Even if with the store version, I'm unable to reproduce this bug :/.
However I understand this MP ensures that audible reminders are saved with 0
repetition and that's what I am reviewing this MP for.
--
The proposal to merge lp:~nik90/ubuntu-clock-app/ota-10-design-polish into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
- Fixed world city list item vertical centering
- Replaced hex color codes with UbuntuColors counterparts
- Updated framework to ubuntu-sdk-15.04.4 and
The proposal to merge lp:~nik90/ubuntu-clock-app/ota-10-design-polish into
lp:ubuntu-clock-app has been updated.
Description changed to:
- Fixed world city list item vertical centering
- Replaced hex color codes with UbuntuColors counterparts
- Updated framework to ubuntu-sdk-15.04.4 and base
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/ota-10-design-polish into lp:ubuntu-clock-app.
Commit message:
- Fixed world city list item vertical centering
- Replaced hex color codes with UbuntuColors counterparts
Requested reviews:
Ubuntu Clock Developers (ubuntu
** Changed in: ubuntu-clock-app
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
** Changed in: ubuntu-clock-app
Status: Confirmed => In Progress
** Changed in: ubuntu-clock-app
Milestone: None => 3.8
** Changed in: ubuntu-clock-app
Assignee: (unassigned) => Ken VanDine (ken-vandine)
--
You received this bug notification because you are a member of Ubuntu
Tested and the fix looks good.
--
https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Fixed remaining issues.
--
https://code.launchpad.net/~nik90/ubuntu-calendar-app/revamp-eventdetails-page/+merge/288492
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of lp:~nik90/ubuntu-calendar-app/revamp-eventdetails-page into
lp:ubuntu-calendar-app.
--
Review: Needs Fixing
Thanks for the fix. When we migrated to UC 1.3, I did notice the issue, but
wasn't aware of ContentHub 1.3 import. Could you please update debian changelog?
--
https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246
Your team Ubuntu Clock Developers
The proposal to merge lp:~ken-vandine/ubuntu-clock-app/lp1554621 into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ken-vandine/ubuntu-clock-app/lp1554621/+merge/289246
--
Your team Ubuntu Clock Developers is
Review: Approve code-review & testing
LGTM. Awesome work. We can finish of the new design implementation for the
Guests feature when we get design specs for it in another MP.
@renato, You can go ahead test this and top-approve. It fixes the label color
issue that bill pointed out as well.
--
Review: Needs Fixing
Almost there, just noticed one minor issue. In the Event reminders page, the
option "No Reminder" is hidden by the page header. I had a quick look at it,
and is quite easy to fix -> http://paste.ubuntu.com/15391380/
--
Review: Needs Fixing
Nice work! It is *almost* ready. Just few minor touch ups to do and then we are
set to land this MP.
1. In the old guest design layout, I notice 3 minor issues ( refer to
http://imgur.com/HC4JAcs )
a) Remove the listitem dividers of the guests listitem
b) set the guest
The proposal to merge lp:~nik90/ubuntu-calendar-app/new-event-style into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-calendar-app/new-event-style/+merge/287324
--
Your team Ubuntu Calendar
Added commit message to fix failed autolanding.
--
https://code.launchpad.net/~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1554610/+merge/288969
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
The proposal to merge
lp:~artmello/ubuntu-calendar-app/ubuntu-calendar-app-fix_1554610 into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
Add support to set a default reminder value time from settings page
For more details, see:
The proposal to merge lp:~majster-pl/ubuntu-calendar-app/new-event-page into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-event-page/+merge/288637
--
Your team Ubuntu
Review: Needs Fixing
I'm setting this MP as a work in progress since it is. I have added inline
comments of all things that needs fixing. This is just a preliminary check
since I suspect more changes.
Do note that when I click the add guest button, I get ,
@Renator Replied to your inline comments.
Diff comments:
>
> === modified file 'EventDetails.qml'
> --- EventDetails.qml 2016-03-02 19:55:52 +
> +++ EventDetails.qml 2016-03-09 18:35:25 +
> @@ -32,45 +31,44 @@
>
> property var event
> property var model
> +property var
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-calendar-app/revamp-eventdetails-page into
lp:ubuntu-calendar-app.
Commit message:
- Transitioned EventsDetails.qml to PageHeader
- Removed uses of deprecated ListItems like Subtitled, Header etc
- Fixed translator comments and removed
Review: Approve
--
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/add-jenkins-info/+merge/288158
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve
LGTM! Thanx for the quick fix. Works as expected.
--
https://code.launchpad.net/~renatofilho/ubuntu-calendar-app/fix-event-creation/+merge/288326
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Review: Approve
LGTM! Nice work syzmon
--
https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/new-agenda-view/+merge/287792
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/add-jenkins-info into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/add-jenkins-info/+merge/288158
--
Your team Ubuntu Calendar
The proposal to merge
lp:~ubuntu-calendar-dev/ubuntu-calendar-app/new-agenda-view into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/new-agenda-view/+merge/287792
--
Your
Review: Approve
Not too happy with removing existing tests, but I suppose if we can get QML
tests up and running then its a good thing.
--
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
Your team Ubuntu Calendar Developers is subscribed to branch
The proposal to merge lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/reduce-ap-tests/+merge/287972
--
Your team Ubuntu Calendar
I think you forgot to add lp:~nskaggs/ubuntu-calendar-app/reduce-ap-tests as a
prerequisite to this branch :)
--
https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/add-jenkins-info/+merge/288158
Your team Ubuntu Calendar Developers is requested to review the proposed merge
of
The proposal to merge lp:~nskaggs/ubuntu-clock-app/add-jenkins-info into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/add-jenkins-info/+merge/288157
--
Your team Ubuntu Clock Developers is
Review: Approve
LGTM. Thnx
--
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/add-jenkins-info/+merge/288157
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
Added 3 stopwatch tests,
 - Tests to checking adding/deleting laps
 - Test to check if stopwatch state meets design during run, pause and stop
state
-
** Changed in: ubuntu-clock-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
The proposal to merge lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
Added 3 stopwatch tests,
- Tests to checking adding/deleting laps
- Test to check if stopwatch state meets design during run, pause and stop
state
-
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into lp:ubuntu-clock-app with
lp:~nik90/ubuntu-clock-app/fix-failing-ap-tests as a prerequisite.
Commit message:
Added stopwatch tests
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot
** Changed in: ubuntu-clock-app
Status: In Progress => Triaged
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
The proposal to merge lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/add-stopwatch-ap-tests/+merge/287919
--
Your team Ubuntu
The proposal to merge lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into
lp:ubuntu-clock-app has been updated.
Description changed to:
Added stopwatch tests
IMPORTANT NOTE: In order to detect that stopwatchPage has fully loaded in
Autopilot, it was necessary to rewrite the page switch
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into lp:ubuntu-clock-app with
lp:~nik90/ubuntu-clock-app/fix-failing-ap-tests as a prerequisite.
Commit message:
Added stopwatch tests
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev
The proposal to merge lp:~nik90/ubuntu-clock-app/add-stopwatch-ap-tests into
lp:ubuntu-clock-app has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/add-stopwatch-ap-tests/+merge/287917
--
Your team Ubuntu Clock
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-failing-ap-tests into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-failing-ap-tests/+merge/287866
--
Your team Ubuntu Clock
The proposal to merge lp:~nik90/ubuntu-clock-app/dynamic-load-listview into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/dynamic-load-listview/+merge/287831
--
Your team Ubuntu Clock
At 1% CPU, it is painfully slow..hell the clock animations are non-existent
;)..that said w.r.t to the expandable list item, the height slowly
increases/decreases to match the contents of the listview as expected. Never
able to reproduce a scenario where the listitem has loaded and the height
I checked with clock app visual designer and she wants all vertical overrides
to be removed and follow the default behaviour set by the listitemlayouts.
I also made the expandablelistloader async. However not sure how to doublecheck
that the binding on height is working as expected.
--
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-failing-ap-tests into lp:ubuntu-clock-app with
lp:~nik90/ubuntu-clock-app/dynamic-load-listview as a prerequisite.
Commit message:
Fixed all failing AP tests.
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/dynamic-load-listview into lp:ubuntu-clock-app.
Commit message:
Improved ExpandableListItem by dynamically loading/unloading its ListView. Also
removed Column from ExpandableListItem to make it lighter.
Requested reviews
The proposal to merge lp:~majster-pl/ubuntu-calendar-app/new-agenda-view into
lp:ubuntu-calendar-app has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-agenda-view/+merge/287448
--
Your team Ubuntu
Review: Disapprove
This MP has been superseded by
https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/new-agenda-view/+merge/287792.
Thereby rejecting this Mp.
--
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-agenda-view/+merge/287448
Your team Ubuntu Calendar
Nekhelesh Ramananthan has proposed merging
lp:~ubuntu-calendar-dev/ubuntu-calendar-app/new-agenda-view into
lp:ubuntu-calendar-app with lp:~renatofilho/ubuntu-calendar-app/optimize as a
prerequisite.
Commit message:
Implemented new agenda view as per the new design spec at
https
** Also affects: ubuntu-clock-app
Importance: Undecided
Status: New
** Changed in: ubuntu-clock-app
Importance: Undecided => Low
** Changed in: ubuntu-clock-app
Status: New => Triaged
** Changed in: ubuntu-clock-app
Milestone: None => 3.x.backlog
--
You received this
The proposal to merge lp:~nik90/ubuntu-clock-app/minor-last-design-fixes into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/minor-last-design-fixes/+merge/287771
--
Your team Ubuntu Clock
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/minor-last-design-fixes into lp:ubuntu-clock-app.
Commit message:
Minor last minute design changes which include,
- Increase font size of labels from Small to Medium
- Ensured all labels respect the color specified
b) General structure of a QML Object is (notice the blank lines),
Object {
id
objectName
property declarations
signal declarations
JavaScript functions
object properties
child objects
states
transitions
}
--
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-clock-ota10-sdk-issues
into lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-clock-ota10-sdk-issues/+merge/287414
--
Your team Ubuntu
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-clock-ota10-sdk-issues
into lp:ubuntu-clock-app has been updated.
Commit Message changed to:
- Fixed FastScroll and ActionButton colors being broken with the latest UITK
Silo 50 which brings new palette colors.
- Replaced deprecated
The proposal to merge lp:~nik90/ubuntu-clock-app/migrate-clock-pageheaders into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
- Migrated all page.head to the new PageHeaders except for SoundPeerPicker.qml
(since it uses ContentPeerPicker that uses UC 1.2. Mixing 1.2 and 1.3
Also update copyright of AgendaView.qml to 2013-2016
--
https://code.launchpad.net/~majster-pl/ubuntu-calendar-app/new-agenda-view/+merge/287448
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
The proposal to merge lp:~nik90/ubuntu-weather-app/fix-ota10-sdk-issues into
lp:ubuntu-weather-app has been updated.
Commit Message changed to:
- Migrated Settings Page (and its child settings pages) to ListItemLayouts and
PageHeader which fixes lot of the colouring issues. Also, in UC 1.3,
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-weather-app/fix-ota10-sdk-issues into lp:ubuntu-weather-app.
Commit message:
- Migrated Settings Page (and its child settings pages) to ListItemLayouts and
PageHeader which fixes lot of the colouring issues. Also, in UC 1.3
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-clock-ota10-sdk-issues
into lp:ubuntu-clock-app has been updated.
Description changed to:
Fixes FastScroll and ActionButton colors being broken with the latest UITK Silo
50 which brings new palette colors.
Old: http://imgur.com/HBLNmD5
New:
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/migrate-clock-pageheaders into lp:ubuntu-clock-app.
Commit message:
Migrated all page.head to the new PageHeaders except for SoundPeerPicker.qml
(since it uses ContentPeerPicker that uses UC 1.2. Mixing 1.2 and 1.3
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-clock-ota10-sdk-issues into lp:ubuntu-clock-app.
Commit message:
Fixes FastScroll and ActionButton colors being broken with the latest UITK Silo
50 which brings new palette colors.
Requested reviews:
Ubuntu Clock
The proposal to merge lp:~nik90/sudoku-app/uc1.3-migrate into lp:sudoku-app has
been updated.
Description changed to:
This MP does the following,
- Migrates to Ubuntu.Components 1.3 (including Popups 1.3)
- Updated framework to 15.04.3-qml
- Updated QtQuick import to 2.4
- Migrated to
Nekhelesh Ramananthan has proposed merging lp:~nik90/sudoku-app/uc1.3-migrate
into lp:sudoku-app.
Commit message:
This MP does the following,
- Migrates to Ubuntu.Components 1.3 (including Popups 1.3)
- Updated framework to 15.04.3-qml
- Updated QtQuick import to 2.4
- Migrated to PageHeaders
The proposal to merge lp:~nik90/ubuntu-calendar-app/migrate-listitemlayout into
lp:ubuntu-calendar-app has been updated.
Commit Message changed to:
- Changed the app background color to #FF (as per new design spec)
- Switches the following pages to listitemlayout
- SettingsPage.qml
The proposal to merge lp:~nskaggs/ubuntu-clock-app/fix-clock-launching into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238
--
Your team Ubuntu Clock
Review: Approve
ooh lots of red color..love the code removal. The debian changelog hasn't been
updated, but I will do that in my upcoming bottom edge MP. Thanks for this.
--
https://code.launchpad.net/~nskaggs/ubuntu-clock-app/fix-clock-launching/+merge/287238
Your team Ubuntu Clock Developers
The proposal to merge lp:~nik90/ubuntu-clock-app/new-bottom-edge into
lp:ubuntu-clock-app has been updated.
Description changed to:
Use the new bottom edge
The new SDK Bottom edge allows us to remove the PageWithBottomEdge custom
component.
For more details, see:
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/new-bottom-edge into lp:ubuntu-clock-app.
Commit message:
Use the new bottom edge
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Bug #1543496 in Ubuntu Clock App: "‘Shutter’ effect anim
The proposal to merge
lp:~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design into
lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-new-design/+merge/281972
> It seems that run time of Clock application are the same with new Design
> (around 4,697s)
Really? That's surprising considering that we removed the background image and
are using the new listitem layouts etc. I didnt expect a huge reduction in
startup time, but a small decrease of maybe 1-2%
** Changed in: ubuntu-clock-app
Importance: Undecided => Medium
** Changed in: ubuntu-clock-app
Status: New => Triaged
** Changed in: ubuntu-clock-app
Milestone: None => 3.8
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is
Review: Needs Fixing
Please merge
https://code.launchpad.net/~fboucault/ubuntu-clock-app/fix_startup_animation_and_performance/+merge/282839
and resolve any code conflicts. That branch changes the animation and clock
face shadow implementation which affects the changes made in this branch.
--
@ahayzen, thanks for helping fix the AP tests. They have been ignored for a
while.
Looking at the log, it seems 4 of the tests are failing with the following
statement,
autopilot.exceptions.StateNotFoundError: Object not found with name 'Label' and
properties {'objectName': 'alarmDay0'}
** Changed in: ubuntu-clock-app
Milestone: None => 3.7
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1508363
Title:
Tiny little detail, the comment "It is important to keep the alarm list in
order of occurrence (also for disabled alarms)." is not true. That if loop does
not affect the alarm list order. Can you remove that statement?
--
Review: Approve
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-disabled-alarm-fix/+merge/274661
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
I have updated the bug report to reflect the decision and the way to move
forward with this issue.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix/+merge/274183
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
> Ok. I understand that it needs extensive testing.
>
> Can we move this patch to the next Clock release then?
It would be better if the fix for this issue came from QtUbuntu [1] rather than
patching it in the clock app. Downstream QT Patches are done in QtUbuntu (and
upstream after a while).
Review: Needs Fixing
Could you fix the debian changelog with just the bug title since the "Order
alarm list according the time of occurrence" is incorrect.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-order-fix/+merge/274270
Your team Ubuntu Clock Developers is
The proposal to merge
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-order-fix into
lp:ubuntu-clock-app has been updated.
Description changed to:
Disable alarms which have passed due to timezone changes made by the user (LP:
#1505522)
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-order-fix into
lp:ubuntu-clock-app has been updated.
Commit Message changed to:
Disable alarms which have passed due to timezone changes made by the user (LP:
#1505522)
For more details, see:
Review: Needs Fixing
Also you will have to create a new branch without the code from
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-australia-display-fix since that
was rejected.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-order-fix/+merge/274270
Your team
1 - 100 of 309 matches
Mail list logo
