Nekhelesh, would you mind having a look at this again? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Finished merging. Thank you for your patience, Nekhelesh! :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Hey Nekhelesh,
I'm sorry for being a bit late.
The reason why I put the i18n.tr() calls in there is because there might be
languages in which it is "2016 April" instead of "April 2016". I'm not sure
about whether there are any such languages, but if we are already fixing
translation issues,
No ideas?
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thanks, Evan!
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/splash-screen/+merge/285673
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Fixing
Thank you, Evan, for going through the old bugs and trying to fix them!
Here are two screenshots comparing the old and the newer version:
https://drive.google.com/file/d/0B19TeQHX9rTYOVVIT0pPRmU2MW8/view?usp=sharing
Review: Needs Fixing
I just skimmed through the code and one thing I noticed is that we would
probably want the CTRL key to be translatable, so please remove the "text"
attributes from the keyboard layouts and use the "id" attribute instead.
Furthermore, I'm not sure whether we would want to
Hi Bart,
In my opinion the patch looks way better than a lot of first-time QML patches.
Congrats on that!
Regarding your questions: I guess we can give you a helping hand here. ;)
I'll try to answer the translation question right now.
Translations are handled by JsonTranslator.qml. It contains
Oh, and I'll set up an email to Alan regarding the mailing list thing. :)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
Review: Needs Fixing
Thank you for the patch! The code looks good to me and I assume Stefano tested
it already.
However, I'm sorry that I am _that_ guy again. :p
For comments we usually put a whitespace after the two leading slashes.
Additionally, we only put semi-colons after QML properties
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-copy into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
--
Your team Ubuntu
Review: Approve
Yes, it is. You'll really come to appreciate QML after a while.
Furthermore, thanks for fixing it. Let's get this merged now. Good job! :)
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-copy/+merge/285287
Your team Ubuntu Terminal Developers is
I should have made it a bit clearer what I've been referring to with the
semicolons. :D
We do use semicolons for executions of commands, e.g. in JavaScript code blocks
surrounded by {} and in other execution blocks like onTriggered or onClicked
listeners.
We do not use semicolons for QML
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/color-scheme-name-mapping into
lp:ubuntu-terminal-app.
Commit message:
Display proper translatable names for color schemes instead of their file names
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Ubuntu
Here we go:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/color-scheme-name-mapping/+merge/285297
:)
--
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-terminal-app/ubuntu-color-scheme/+merge/285170
Your team Ubuntu Terminal Developers is subscribed to branch
@Stefano: I compared them earlier today due to line 161 of the diff and it
looks like those two colors confused me. However, you're right about the
background color and the red/blue thing also isn't that much of an issue.
Hence, I support renaming the Dark Pastels scheme to the name you
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable_paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable_paste/+merge/285280
--
Your team Ubuntu
@Stefano: Will Launchpad build the pot file itself in that case or how will it
pick up new translatable strings then?
--
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
So I'll also top-level approve this one. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/fix-default-color-scheme/+merge/285273
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
Fixed the merge conflicts. Would you mind looking into it again, please? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n/+merge/279509
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/font-size-fix
into lp:ubuntu-terminal-app.
Commit message:
Make font size relative to "medium" fontSize for Labels
Default font size is set to be the same as that of gnome-terminal on a Unity 7
desktop
Request
While working on this I found
https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1542668.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/font-size-fix/+merge/285272
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/fix-default-color-scheme into
lp:ubuntu-terminal-app.
Commit message:
Fix the color scheme to be set to "Ubuntu" again by default
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Jenkins Bot (ubuntu
Review: Approve
Thank you for fixing this, Evan! The MP looks very good. :)
@Stefano: You make a really good point with (1). Let's keep that in mind when
we continue to add features. :)
[Another note regarding pot file conflicts: If you have already committed stuff
which causes a merge
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/disable-paste into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/disable-paste/+merge/283244
--
Your team Ubuntu
Review: Approve
Thanks for fixing that! I think the reason why nobody came back to you earlier
was that Launchpad doesn't always send notifications for everything.
The best way probably is to either send people a short email (alternatively
ping them on IRC) or to write a small message on the
The proposal to merge lp:~mcintire-evan/ubuntu-calendar-app/fix_readme_typo
into lp:ubuntu-calendar-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-calendar-app/fix_readme_typo/+merge/280670
--
Your team Ubuntu
Looks like there have been a few changes in trunk since you branched off your
tree. Here is how to resolve this:
$ bzr branch lp:~mcintire-evan/ubuntu-terminal-app/disable-paste
$ bzr branch lp:ubuntu-terminal-app trunk
$ cd disable-paste
$ bzr merge ../trunk
$ bzr conflicts
** Changed in: ubuntu-filemanager-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
Review: Needs Fixing
Thanks for changing this. :)
However, there are four lines in the pot file which seem to stem from a merge
error. We need to fix this before we can merge the MP. The easiest way to do
that would probably be to just run it once again from the Ubuntu SDK and then
commit the
Review: Needs Fixing
Thank you for the patch!
I really see why you want to implement this feature. However, there are some
issues with the code.
What this currently does is the following: it hides the paste option when the
user has selected some text and shows it if there is no selection. So
The proposal to merge lp:~mcintire-evan/ubuntu-terminal-app/change-auth into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change-auth/+merge/283240
--
Your team Ubuntu Terminal
Thank you for looking into this, Alan! :)
I haven't looked at the code myself yet, but please change the commit message
to something that you would want to see in the bazaar history. "Adding commit
message as required by fussy jenkins bot" probably won't tell you two years
down the road what
Review: Approve
I think we need to kick off the landing here. Thank you for the patch and for
fixing the typo. :)
(Sadly, I didn't get any notification that you updated the MP so that's why I
didn't respond earlier ...)
--
Thank you for your contribution!
Please see my inline comment. If you fix it, we can happily merge this. ;)
Diff comments:
>
> === modified file 'src/app/qml/AuthenticationDialog.qml'
> --- src/app/qml/AuthenticationDialog.qml 2015-07-13 20:25:21 +
> +++
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/bracket-paste-fix/+merge/279368
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thank you, Kunal and David, for looking into this.
@David, to clear this up a bit:
qsTr() is responsible only for the format string here. i18n.tr() delivers the
translated format string while qsTr() in combination with the arg() calls then
goes ahead and replaces %1 and %2 with the arguments,
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n into
lp:ubuntu-calendar-app.
Commit message:
Fix bad month translations for some languages, e.g. Polish
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into
lp:ubuntu-calendar-app.
Commit message:
Remove unnecessary i18n.tr() calls
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
For more details, see:
https
Thank you for merging then. I hope to fix the other issue soon. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/paste-zero-fix/+merge/276011
Your team Ubuntu Calculator Developers is requested to review the proposed
merge of lp:~nikwen/ubuntu-calculator-app/paste-zero-fix into
Thank you for your review, Bartosz. I'll fix the brackets thing as soon as
possible.
However, I'm incredibly busy at the moment and it will take at least one and a
half weeks until I have time for that again.
Regarding the autopilot tests: I don't know how to fit them into my schedule at
the
Review: Approve
Thank you for the patch, Bartosz! :)
I gave it a try and couldn't manage to find any regressions. :p I can confirm
that the bug this is supposed to fix is indeed fixed and that the autopilot
tests ran fine on my machine.
Looking at math.js's issue list on Github, I can also not
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/paste-zero-fix into lp:ubuntu-calculator-app.
Commit message:
Fix issue due to which the zero would not be pasted when using Ctrl+V
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details
Here's the fix for the zero pasting issue:
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/paste-zero-fix/+merge/276011
Evil one! :D
Regarding the changelog: To me this looks as if it is automatically generated
somehow. Is this true? If it is, how can I generate it from the bzr
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-math-2.4-upgrade into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
Hi Bartosz,
Thank you for your review! :)
Given that you merged it before I had the chance to add a changelog entry, I'll
add another MP for that. ;)
The 0.1 struggle is real though! It looks as if pasting 0 fails in general.
I'll have a look at it. :)
Thanks again,
Niklas
--
The proposal to merge
lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into
lp:ubuntu-filemanager-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909
--
The proposal to merge
lp:~nikwen/ubuntu-filemanager-app/remove-popover-workaround into
lp:ubuntu-filemanager-app has been updated.
Description changed to:
Remove popover workaround for LP: #1395118.
This is becoming rather urgent now that the SDK team is creating a new set of
popover/dialog
Review: Needs Information
Looks good to me. Well done! ;)
See my inline comments for a few remarks. Some of them are questions though as
you might have a reason why you did things differently.
Nevertheless, I'd like someone who is more familiar with the clock app code to
review this as well.
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Fixed now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
I resolved the conflicts. Should be ready for merging now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
I'll get to them. Thank you for reviewing this one as well. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layout-i18n/+merge/264620
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/layouts-click-full-width/+merge/27
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thanks for merging. :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
--
Your team Ubuntu Terminal
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update
into lp:ubuntu-terminal-app.
Commit message:
Update to the new UI Toolkit
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
Bug #1474114 in Ubuntu Terminal App: Upgrade the Ubuntu
The proposal to merge
lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix into
lp:ubuntu-calculator-app has been updated.
Description changed to:
Fix physical delete and backspace keys, implement proper copy support for the
desktop
(This is one of two MPs resulting from splitting
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/desktop-paste-support into
lp:ubuntu-calculator-app with
lp:~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix as a prerequisite.
Commit message:
Add proper paste support on the desktop
Requested reviews:
Ubuntu
Should be ready for merging now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/uitk-update/+merge/25
Your team Ubuntu Terminal Developers is requested to review the proposed merge
of lp:~nikwen/ubuntu-terminal-app/uitk-update into lp:ubuntu-terminal-app.
--
Mailing list:
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/layouts-click-full-width into
lp:ubuntu-terminal-app.
Commit message:
Allow triggering the layout enabled switch by clicking anywhere on the ListItem
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev
Hi, I'm sorry for the late reply. Thanks a lot for reviewing this. :)
I have now split the MP as requested:
1)
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
2)
Niklas Wenzel has proposed merging lp:~nikwen/ubuntu-terminal-app/uitk-update
into lp:ubuntu-terminal-app.
Commit message:
Update to the new UI Toolkit
Requested reviews:
Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
Bug #1474114 in Ubuntu Terminal App: Upgrade the Ubuntu
The proposal to merge lp:~nikwen/ubuntu-terminal-app/uitk-update into
lp:ubuntu-terminal-app has been updated.
Description changed to:
Update to the new UI Toolkit
I decided not to switch to the new ListItem component this time as it does not
seem to be ready yet. (Check out this thread:
No problem. ;)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-copy-paste-fix/+merge/264621
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thanks for approving. Can we merge it? :)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/delete-backspace-copy-fix/+merge/20
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Thanks a lot for the clarification, Zsombor!
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1124071
Title:
[tabs] Cannot add
Just found something while looking through the diff. Will fix it. :)
Diff comments:
=== modified file 'src/app/qml/KeyboardRows/jsonParser.js'
--- src/app/qml/KeyboardRows/jsonParser.js2015-02-14 12:46:38 +
+++ src/app/qml/KeyboardRows/jsonParser.js2015-07-13 17:22:19 +
@@
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/delete-copy-paste-fix into
lp:ubuntu-calculator-app.
Commit message:
Implement proper copy/paste functionality (fixes the delete/backspace issue by
removing the previous implementation)
Requested reviews:
Ubuntu Calculator
Review: Approve
@Alan: Yes, I've seen Sam create icons since the very first days when I got in
touch with Ubuntu on my Nexus 4. I've always admired them! (By the way, thank
you for your fast answer.)
Since there do not seem to be any issues with regards to the design team, we
should get this
Review: Needs Information
Thanks, Sam!
While I think that the updated icon looks really good, I'd like to hear an
official opinion from some Canonical guys here. The latest batch of icons was
created by Canonical designers and I don't know what their plans are regarding
the terminal icon.
--
Review: Approve
Looks good, thanks Alan!
Just one thing, we might want to put manglasape's full name here. (See
launchpad.net/~manglasape: Andrés Manglano)
--
https://code.launchpad.net/~popey/ubuntu-terminal-app/add-authors/+merge/263926
Your team Ubuntu Terminal Developers is subscribed to
The proposal to merge lp:~snwh/ubuntu-terminal-app/updated-icon into
lp:ubuntu-terminal-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~snwh/ubuntu-terminal-app/updated-icon/+merge/264633
--
Your team Ubuntu Terminal Developers is
Thanks for approving. Can we merge it yet?
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Review: Needs Fixing
Works really good now and it took like forever till I found an issue. ;)
1) Type in 8*8=
2) Type in .
What happens:
The new input is 64..
However, if we want to handle typing . as 0., we need to apply the same
behaviour we apply to numbers here, i.e. clearing the input
Review: Needs Fixing
Sadly, this doesn't solve the problem for me. Here's how you can still
reproduce the issue:
Hit one key (e.g. 3 or 6) multiple times (e.g. 3 times) with as short time gaps
between the presses as possible and while hitting it for the last time move
your finger slightly to
The issue here is that the chroot used for testing does not have the UI Toolkit
patch. I think one should update those chroots as the patch was added around
the second RTM release!
--
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/remove-popover-workaround/+merge/261909
Your team
Thank you for merging it, Filippo. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/scrolling-improvements-2/+merge/262503
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/autopilot-test-equals-doesnt-change-numbers
into lp:ubuntu-calculator-app.
Commit message:
Improve test_equals_doesnt_change_numbers according to LP: #1400890
Requested reviews:
Ubuntu Calculator Developers (ubuntu
Failed because two lines are a bit too long...
I'll fix that as soon as possible.
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/autopilot-test-equals-doesnt-change-numbers/+merge/262794
Your team Ubuntu Calculator Developers is requested to review the proposed
merge of
Bartosz, I filed the issue and thanks for adding the comment. ;)
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-comma-without-number/+merge/262273
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-terminal-app/scrolling-improvements-2 into
lp:ubuntu-terminal-app.
Commit message:
Detect whether the swipe is a swipe in x or y direction by comparing the length
of the swipe in each direction instead of simply preferring y over x swipes
Review: Approve
Thanks. Let's try it again. ;)
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-translation-template-fix/+merge/262064
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Suggestion from David Planella: Another shortcut that I find quite useful is
the one to switch between tabs: Ctrl+PgUp or Ctrl+PgDown.
I'll add these.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to
Review: Needs Fixing
Thanks. This is one of the features I always missed!
I have a few minor complaints though. ;)
There is an issue related to the removed code from couldAddDot() now. Typing in
'4!.2' results in '4!0.2' while in my opinion it should be '4!*0.2'. The same
applies to 'pi.2'.
Review: Needs Fixing
There's something broken here as it also contains parts of your
ubuntu-calculator-app-comma-without-number MP. Please fix that but thanks for
working on this.
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-swipe-fix/+merge/262275
Review: Approve
Works fine, thanks. :)
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-display-fix/+merge/262268
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Merge conflict...
Retrieving
'bzr+ssh://ubuntu-phone-apps-jenkins-...@bazaar.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-translation-template-fix'
to put at 'work'.
Merging 'lp:ubuntu-calculator-app' in to 'work'.
Not attempting to fix packaging branch ancestry, missing
The proposal to merge lp:~nikwen/ubuntu-terminal-app/keyboard-shortcuts into
lp:ubuntu-terminal-app has been updated.
Description changed to:
Added keyboard shortcuts which are known to users from gnome-terminal.
As this uses a function for tab closing which I introduced in the MP for proper
The proposal to merge lp:~nikwen/ubuntu-terminal-app/keyboard-shortcuts into
lp:ubuntu-terminal-app has been updated.
Commit Message changed to:
Added keyboard shortcuts for desktop use.
Available commands:
Open Tab: Shift+Ctrl+T
Close Tab: Shift+Ctrl+W
Close Window: Shift+Ctrl+Q
Previous
Here you go. Should be ready for merging now. :)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list:
** Branch linked: lp:~nikwen/ubuntu-filemanager-app/remove-popover-
workaround
** Changed in: ubuntu-filemanager-app
Status: New = In Progress
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Here you go. ;)
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Thank you for reviewing this, Alan.
Are you using the British keyboard layout? I'll test it with that one.
--
https://code.launchpad.net/~nikwen/ubuntu-terminal-app/keyboard-shortcuts/+merge/261787
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing
I found the issue why the test failed once. I filed it as LP: #1464571 and will
take care of it as soon as possible.
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/fix-desktop-shortcuts/+merge/261747
Your team Ubuntu Calculator Developers is subscribed to branch
@rpadovani: Thanks for approving again and merging this.
@gang65: I think there are some serious problems with running autopilot tests
here.
Just compare which tests were run the first time (when it passed) and which
ones were run the second time (when it failed):
The proposal to merge
lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into
lp:ubuntu-calculator-app has been updated.
Description changed to:
Use longer swipe in autopilot tests for revealing the scientific keyboard. If
the bug appears again, the reason lies in the QML code.
Niklas Wenzel has proposed merging
lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into
lp:ubuntu-calculator-app.
Commit message:
Use longer swipe in autopilot tests for revealing the scientific keyboard
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev
The proposal to merge
lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into
lp:ubuntu-calculator-app has been updated.
Commit Message changed to:
Use longer swipe in autopilot tests for revealing the scientific keyboard
For more details, see:
1 - 100 of 120 matches
Mail list logo
