Review: Needs Fixing
Hi Bartosz,
thanks for the branch, I like it.
Anyway, I don't think we want to add the "networking" policy to the release in
production, while is useful in debug - so please drop it :)
--
Review: Needs Fixing
Works good, but I left an inline comment.
Also, there isn't a way to use a single component editing proprierties instead
of having two different Rows?
Diff comments:
>
> === modified file 'app/ui/Screen.qml'
> --- app/ui/Screen.qml 2015-11-24 13:43:38 +
> +++
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/tempResultOnlyInParenthesis into
lp:ubuntu-calculator-app.
Commit message:
Remove * from operators with priority
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
https
Hi Bartosz,
thanks for working on this.
Unfortunately, I don't think this is the right way to fix the problem:
Qt.labs.settings writes on a file the setting, so you add a very big overhead:
every time user presses a button there is an I/O operation, that is very
expensive.
IMO the right
Review: Approve
Yeah, great :-)
--
https://code.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/ubuntu-calculator-convergance/+merge/278880
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-profiling-doc-update
into lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
Review: Needs Fixing
Seems the merge of my branch with trunk went wrong :/
Please see [0].
You need to drop your comments and replace iconName with
iconName: visualModel.selectedItems.count < visualModel.items.count ?
"select" : "select-none"
See the
Lovely bzr.
Fixed :-)
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/dropCustomIcons/+merge/278452
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/dropCustomIcons into
lp:ubuntu-calculator-app.
Commit message:
Use sdk's icons
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
https://code.launchpad.net/~rpadovani
Thanks Bartosz, I fixed conflicts.
The bug upstream is
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1518002
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
Your team Ubuntu Calculator Developers is subscribed to branch
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
--
Your team Ubuntu Calculator
Okay, I found a workaround until the bug is fixed upstream.
It introduces a bug in the desktop mode (when you resize the window, the app
scrolls down) but I think is way less important that this one
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
Your
Review: Approve
lgtm, thanks!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-power-withnegative-number/+merge/278082
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-long-complex-numbers-fix
into lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
Investigating more, it is related to the header. If I don't hide the header it
doesn't happen.
I think is related to
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1518002, need
to investigate further to find a workaround
--
So, some progress on this.
It seems that when the app is loaded the pagestack changes its height a lot of
times:
if you add onHeightChanged: console.log('pagestack ' + height) on line 254 of
ubuntu-calculator-app.qml when you start the app you have something like this:
qml: pagestack
Review: Needs Fixing
Hi Bartosz,
thanks for working on this - unfortunately doesn't work as expected :(
Try, for example, to do 3^-2^-2. When you press equal it blinks, instead on
trunk it correctly calculate the operation.
So it seems that now for some reason it calculate wrong when the
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2.4.2-upgrade
into lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM, thanks!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-display-cursor/+merge/277359
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2.4.2-upgrade/+merge/277509
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
I'm quite puzzled about the bug, it happens randomly, not all the time,
probably 1 on 3. I have no idea of which is the root case, and I tried a lot of
different things.
I'm sure we've already seen something like this, but I don't remember how we
fixed it.
If you have any suggestions, please
I fixed all the warnings, I'm still investigating about the virtual keyboard
position
--
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/bumpToolkit/+merge/277012
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into lp:ubuntu-calculator-app.
Commit message:
Update QtQuick and ubuntu-ui-toolkit
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Calculator Developers
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/bumpToolkit into
lp:ubuntu-calculator-app has been updated.
Description changed to:
- Update all QtQuick to 2.4 and toolkit to 1.3
- Drop custom header in favour of standard one
- Fix bug #1413789
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-bracket-push-fix into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2.4.1 into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-bracket-push-fix into
lp:ubuntu-calculator-app has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
Works as a charm, thanks!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-bracket-push-fix/+merge/276055
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Bartosz, there is a conflict in debian/changelog, could you please fix it?
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-bracket-push-fix/+merge/276055
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Riccardo Padovani has proposed merging
lp:~rpadovani/reminders-app/remove-unused-components into lp:reminders-app.
Commit message:
Remove unused files
Requested reviews:
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot):
continuous-integration
Ubuntu Notes app developers (notes
Riccardo Padovani has proposed merging lp:~rpadovani/reminders-app/integration
into lp:reminders-app.
Commit message:
Extend ability to create new notes from other apps
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
Related bugs:
Bug #1445107 in Ubuntu Notes app: "E
Review: Approve
Thanks, looks better
--
https://code.launchpad.net/~popey/reminders-app/fix-1452924/+merge/271845
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~popey/reminders-app/fix-1452924 into lp:reminders-app
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~popey/reminders-app/fix-1452924/+merge/271845
--
Your team Ubuntu Notes app developers is subscribed to
Riccardo Padovani has proposed merging
lp:~rpadovani/reminders-app/update-pot-sep15 into lp:reminders-app.
Commit message:
Update pot file
Requested reviews:
Ubuntu Notes app developers (notes-app-dev)
Related bugs:
Bug #1487160 in Ubuntu Notes app: "Untranslated strings&quo
The proposal to merge lp:~mzanetti/reminders-app/align-imports into
lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/align-imports/+merge/271139
--
Your team Ubuntu Notes app developers is
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-textfields/+merge/270760
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve
Lgtm, thanks
--
https://code.launchpad.net/~mzanetti/reminders-app/improve-edit-focus/+merge/270755
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~mzanetti/reminders-app/improve-edit-focus into
lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/improve-edit-focus/+merge/270755
--
Your team Ubuntu Notes app developers
The proposal to merge lp:~mzanetti/reminders-app/workaround-oxide-race into
lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/workaround-oxide-race/+merge/270745
--
Your team Ubuntu Notes app
Review: Needs Fixing
Please remove the unused file.
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-missing-checkbox/+merge/270750
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
The proposal to merge lp:~mzanetti/reminders-app/fix-missing-checkbox into
lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-missing-checkbox/+merge/270750
--
Your team Ubuntu Notes app
Review: Approve
lgtm now, thanks!
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-missing-checkbox/+merge/270750
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~mzanetti/reminders-app/fix-writeback-issue into
lp:reminders-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-writeback-issue/+merge/263848
--
Your team Ubuntu Notes app developers
Review: Approve
lgtm, thanks!
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-writeback-issue/+merge/263848
Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve
lgtm, thanks!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2-upgrade/+merge/268046
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-mathjs-2-upgrade into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Needs Information
Thanks for working on this :-)
I left some comments inline - nothing wrong, but I'm not sure about some choices
Diff comments:
=== modified file 'src/app/qml/components/NotebooksDelegate.qml'
--- src/app/qml/components/NotebooksDelegate.qml 2015-03-04
Review: Approve
Works like a charm, thanks :-)
Diff comments:
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml 2015-06-22 10:53:02 +
+++ src/app/qml/reminders.qml 2015-07-25 03:01:57 +
@@ -501,7 +490,7 @@
Column {
id: statusBar
-
Review: Needs Information
Looks good to me, just a couple of comments inline (clarification, nothing
wrong)
Diff comments:
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt2015-06-14 23:34:29 +
+++ CMakeLists.txt2015-07-05 19:26:31 +
@@ -20,7 +20,7 @@
Riccardo Padovani has proposed merging
lp:~rpadovani/reminders-app/predictiveTextTagInsertion into lp:reminders-app.
Commit message:
Fix bug about tag insertion when user is still typing the tag name
Requested reviews:
Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
Bug
Review: Approve
lgtm
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-label-wrapping/+merge/265887
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Riccardo Padovani has proposed merging
lp:~rpadovani/ubuntu-calculator-app/fix-new-jenkins-build into
lp:ubuntu-calculator-app.
Commit message:
Fix new jenkins build
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
https://code.launchpad.net
I need an holiday.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-volume-preview/+merge/264783
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Information
Indeed, sorry for the wrong review.
+alarmSettings.volume = value
+previewAlarmVolume.volume = value/100
Why you set the volume of the preview at 1/100 of the actual volume?
Also, why did you drop the call to
The proposal to merge
lp:~gang65/ubuntu-clock-app/ubuntu-clock-update-debug-documentation into
lp:ubuntu-clock-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
lgtm
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-update-debug-documentation/+merge/264969
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Fixing
48 +previewAlarmVolume.source =
/usr/share/sounds/ubuntu/ringtones/Suru arpeggio.ogg
The preview should be with the actual ringtone, now with an hardcoded one
--
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-test into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-test/+merge/264458
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-snooze-time-extend/+merge/263846
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-store-name-fix into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
Good idea, thanks!
--
https://code.launchpad.net/~popey/reminders-app/add-authors/+merge/263919
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-error-message-fix into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-error-message-fix/+merge/263601
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-swipe-lock into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge lp:~mzanetti/reminders-app/improve-viewer into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/improve-viewer/+merge/262162
--
Your team Ubuntu Reminders app developers is
The proposal to merge lp:~mzanetti/reminders-app/fix-enable-push into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-enable-push/+merge/262541
--
Your team Ubuntu Reminders app developers is
Review: Approve
lgtm
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-enable-push/+merge/262541
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Fixing
Now it's ready, thanks :-)
Just a last little fix, see inline comment
Diff comments:
=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml 2015-06-11 22:45:32 +
+++ src/app/qml/components/EditTagsDialog.qml
Review: Approve
Ok, you were fastest than me, ready to go :-)
--
https://code.launchpad.net/~mzanetti/reminders-app/improve-viewer/+merge/262162
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list:
Review: Approve
Thanks!
--
https://code.launchpad.net/~mzanetti/reminders-app/contenthub-import/+merge/261919
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~mzanetti/reminders-app/contenthub-import into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/contenthub-import/+merge/261919
--
Your team Ubuntu Reminders app developers
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-swipe-lock/+merge/262551
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Review: Needs Fixing
Easy and clean solution, thanks!
Please see my inline comment and then is ready to go!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-swipe-fix2/+merge/262393
Your team Ubuntu Calculator Developers is subscribed to branch
Review: Needs Fixing
Looks good (just three little things to change if you don't mind).
Diff comments:
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt2015-02-16 22:01:20 +
+++ CMakeLists.txt2015-06-15 00:00:45 +
@@ -74,6 +74,7 @@
reminders.url-dispatcher
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-shortcut-fix
into lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
Review: Approve
Good catch, thanks!
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-keyboard-shortcut-fix/+merge/262517
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
Review: Needs Fixing
Doesn't work always.
Try to do 9+6*3+.3, 0 isn't added.
Please, also add a test case for this bug, and I agree with Niklas' inline
comment, you shold add a comment to explain the code you added :-)
--
Review: Needs Fixing
[Tablet mode] Choose a note, then choose another note, the note preview goes
over the header.
You forgot to remove a reference to a componenent you delete:
src/app/qml/ui/EditNoteView.qml:35: ReferenceError: notebookSelector is not
defined
[Tablet mode] Cannot create a
See it didn't published my inline comment, sorry!
Diff comments:
=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml 2015-06-17 20:11:29 +
+++ app/ubuntu-calculator-app.qml 2015-06-18 21:38:28 +
@@ -167,7 +167,7 @@
try {
Review: Needs Fixing
You forgot reminders page, apart from that, good work!
--
https://code.launchpad.net/~mzanetti/reminders-app/animated-delete/+merge/261904
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list:
Well, then with popey's blessing I land this :-)
--
https://code.launchpad.net/~mzanetti/reminders-app/improve-edit-tags/+merge/261779
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
The proposal to merge lp:~mzanetti/reminders-app/improve-edit-tags into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/improve-edit-tags/+merge/261779
--
Your team Ubuntu Reminders app developers
Review: Approve
lgtm, thanks :-)
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square/+merge/261829
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/fix-autopilot-empty-square/+merge/261829
--
Review: Needs Fixing
There are a lot of warnings due your changes: http://paste.ubuntu.com/11698283/
Also, there is a strange warning in qml when you delete a tag which has notes
attached: it says
`Sync: Save tag job finished, but tag can't be found any more`
This is really a minor issue, but
We have a problem with autopilot since ages, it randomly failes on phone
--
https://code.launchpad.net/~nikwen/ubuntu-calculator-app/fix-desktop-shortcuts/+merge/261747
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge lp:~mzanetti/reminders-app/fix-count-when-sorting into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-count-when-sorting/+merge/261785
--
Your team Ubuntu Reminders app
Review: Approve
Tested deeply, looks all good to me now, thanks!
--
https://code.launchpad.net/~mzanetti/reminders-app/enable-deleting-notebooks-and-tags/+merge/261774
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list:
The proposal to merge
lp:~mzanetti/reminders-app/enable-deleting-notebooks-and-tags into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/enable-deleting-notebooks-and-tags/+merge/261774
--
Your
Review: Approve
Hmm... I tried with a Popover at first, but in this context it didn't feel
right. Just having an
UbuntuShape without the arrow pointing to the input seems odd too. IMO the
rectangle fits best here
but not sure... Maybe we can ask popey for a thirst opinion.
Well, I didn't
The proposal to merge
lp:~mzanetti/reminders-app/store-local-resources-in-infofile into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/store-local-resources-in-infofile/+merge/260990
--
Your team
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~mzanetti/reminders-app/fix-empty-title/+merge/260381
Your team Ubuntu Reminders app developers is subscribed to branch
lp:reminders-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve
Makes sense, thanks
Diff comments:
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml 2015-04-13 21:32:13 +
+++ src/app/qml/reminders.qml 2015-05-27 22:47:24 +
@@ -96,17 +96,10 @@
backgroundColor: #dd
-property var
Review: Approve
Thanks for the MR Nik, it is definitely a cool improvement :-)
--
https://code.launchpad.net/~nik90/ubuntu-calculator-app/improve-ui/+merge/260404
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge lp:~nik90/ubuntu-calculator-app/improve-ui into
lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-calculator-app/improve-ui/+merge/260404
--
Your team Ubuntu Calculator Developers
Review: Approve
lgtm, thanks
--
https://code.launchpad.net/~gang65/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-warning/+merge/257859
Your team Ubuntu Calculator Developers is subscribed to branch
lp:ubuntu-calculator-app.
--
Mailing list:
The proposal to merge
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-warning
into lp:ubuntu-calculator-app has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge lp:~mzanetti/reminders-app/cleanup-pages into
lp:reminders-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/cleanup-pages/+merge/260395
--
Your team Ubuntu Reminders app developers is
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into
lp:ubuntu-clock-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-warnings/+merge/260173
--
Your team Ubuntu Clock
1 - 100 of 169 matches
Mail list logo
