Review: Approve
Looks good, if we do start running into issues where 1.0 is not installable we
can find another solution.
--
https://code.launchpad.net/~ahayzen/music-app/fix-1599902/+merge/301964
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
The proposal to merge lp:~ahayzen/music-app/fix-1599902 into lp:music-app has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1599902/+merge/301964
--
Your team Music App Developers is subscribed to branch
The proposal to merge lp:~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api
into lp:ubuntu-weather-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api/+merge/289584
--
Your team
Review: Approve
Ok, this looks good now. Approve!
--
https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api/+merge/289584
Your team Ubuntu Weather Developers is subscribed to branch
lp:~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api.
--
Mailing list:
Actually, maybe it's not a bug. Weather.com seems to do the same. Maybe that's
their way of indicating that the temp won't rise?
--
https://code.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api/+merge/289584
Your team Ubuntu Weather Developers is subscribed to branch
Review: Needs Information
This isn't a regression, as I've noticed it before--TWC always displays the
high temp as the current temp as soon as the high has been reached. Maybe we're
using the API incorrectly to determine today's high? Since it's not a
regression, I'm fine leaving it as-is...
Victor Thompson has proposed merging
lp:~ubuntu-weather-dev/ubuntu-weather-app/new-weather-api into
lp:ubuntu-weather-app.
Commit message:
* Update to use new weather API
* Change the trimAPIKey function so it only trims the API Key
Requested reviews:
Ubuntu Weather Developers (ubuntu
** Changed in: music-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
The proposal to merge lp:~ahayzen/music-app/convergence-tabs-with-sidebar-01
into lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/convergence-tabs-with-sidebar-01/+merge/286127
--
Your team Music App
Review: Approve
Ok, the additional changes look good and fix the issue. Sometimes when I change
orientations the header hides but can be re-shown. lgtm!
(but we should still try to track down what's going on)
--
Victor Thompson has proposed merging
lp:~vthompson/music-app/fix-search-field-white-text into lp:music-app.
Commit message:
* Fix the Search TextField component color so the text is not invisible when
field is not in focus
Requested reviews:
Music App Developers (music-app-dev)
Related bugs
Also, it seems like maybe the bug occurs more often when you have a large queue.
--
https://code.launchpad.net/~ahayzen/music-app/convergence-tabs-with-sidebar-01/+merge/286127
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
Furthermore, I think the statement--as worded--is difficult to
understand and therefore hard to translate.
Some regions/countries (e.g. China) may block Google's services. If
you're living there or plan to go there, we suggest turning off the
built-in Google RSS service from the Settings page.
** Description changed:
- It would be super awesome to have syncing feature for short.
+ It would be super awesome to have syncing feature for Shorts.
So it can not only achieve convergence when user case change but also on
multiple devices.
It's a bit general for this feature request,
Figuring out why issue #12 is happening should be a priority so we can provide
these features to early users of the tablet device.
--
https://code.launchpad.net/~ahayzen/music-app/convergence-tabs-with-sidebar-01/+merge/286127
Your team Music App Developers is subscribed to branch lp:music-app.
The proposal to merge lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update
into lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363
--
Your team Music App
Public bug reported:
I think this is due to the new palette in the SDK landing in rc-
proposed. The app background is white, which defeats the purpose of
night mode. Also, articles are impossible to read for this reason.
** Affects: ubuntu-rssreader-app
Importance: Undecided
Items #4 and #6 still need to be fixed. Item #6 could be argued as fine as-is,
however (maybe it's the way it is per design).
4. Disabled header actions are not greyed out.
6. The leadingActions for Remove are no longer red with a white icon.
--
Victor Thompson has proposed merging
lp:~music-app-dev/music-app/fix-1550096-ota10-sdk-update into lp:music-app.
Commit message:
* Resolve issues related to SDK changes in OTA10
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1550096 in Ubuntu Music App
I can still reproduce #12 while on the new silo #50.
--
https://code.launchpad.net/~ahayzen/music-app/convergence-tabs-with-sidebar-01/+merge/286127
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
I fixed #4 by making the icons invisible when not enabled. This matched the
behavior in the Contacts app. I also added and fixed another issue (#7) with
the Dialog views.
This should be ready for review. We can file another bug/issue for #6 if it is
seen as an issue.
--
** Summary changed:
- Renameing folders won't work
+ Renaming folders doesn't work
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1549557 into
lp:music-app.
Commit message:
* Fix fallback art when the it is linked to the Player's currentMeta
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1549557 in Ubuntu Music App: "Fal
** Changed in: ubuntu-weather-app
Milestone: None => backlog
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching subscriptions: File Manager App Bugmail, Ubuntu RSS Reader Bugmail
** Changed in: music-app
Milestone: None => refactor.backlog
** Changed in: ubuntu-weather-app
Milestone: None => backlog
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu File Manager App.
Matching
The proposal to merge lp:~vthompson/music-app/fix-1538829-no-playlists-label
into lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1538829-no-playlists-label/+merge/287415
--
Your team Music App
The proposal to merge lp:~vthompson/music-app/fix-1538829-no-playlists-label
into lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1538829-no-playlists-label/+merge/287415
--
Your team Music App
I should have done a "bzr mv" for the SliderStyle change. It is verbatim the
same as the silo, save the CUSTOM tags added.
--
https://code.launchpad.net/~music-app-dev/music-app/fix-1550096-ota10-sdk-update/+merge/287363
Your team Music App Developers is requested to review the proposed merge of
Victor Thompson has proposed merging
lp:~vthompson/music-app/fix-1538829-no-playlists-label into lp:music-app.
Commit message:
* Fix topMargin of the Playlists empty state so title is not obscurred
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1538829 in Ubuntu
Victor Thompson has proposed merging
lp:~vthompson/music-app/ix-1538832-gridview-offset into lp:music-app.
Commit message:
* Remove offset from the top of AddToPlaylist.qml
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1538832 in Ubuntu Music App: "The &q
Victor Thompson has proposed merging
lp:~vthompson/music-app/fix-1550832-plural-track-count into lp:music-app.
Commit message:
* Fix regression where AddToPlaylist.qml no long supports plural track counts
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1550832
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1549580 into
lp:music-app.
Commit message:
* Fix fallback image path in MusicListItem
Requested reviews:
Music App Developers (music-app-dev)
Related bugs:
Bug #1549580 in Ubuntu Music App: "Fallback art is NOT disp
The proposal to merge lp:~vthompson/music-app/lighter-now-playing-toolbar into
lp:music-app has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~vthompson/music-app/lighter-now-playing-toolbar/+merge/279654
--
Your team Music App
Fixed.
--
https://code.launchpad.net/~vthompson/music-app/fix-1378143/+merge/284380
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
I'd like to avoid doing any large rename internally to avoid any regressions.
This is simply to get the translatable strings in place so the app has time to
get translate (hence why it was the first MP proposed).
--
https://code.launchpad.net/~vthompson/music-app/fix-1378143/+merge/284380
Your
Review: Needs Information
Michi, can you confirm if that silo has landed in rc-proposed or not? I assume
it has.
--
https://code.launchpad.net/~vthompson/music-app/fix-1515067/+merge/277306
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
Testing against rc-proposed seems to work as intended.
--
https://code.launchpad.net/~vthompson/music-app/fix-1515067/+merge/277306
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Needs Information
This change also isn't as nice on the desktop. Is there a way we could show the
blurred bg and still support this animation?
--
https://code.launchpad.net/~ahayzen/music-app/fix-1482545-swipe-in-now-playing/+merge/281045
Your team Music App Developers is subscribed to
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1538863 into
lp:music-app with lp:~vthompson/music-app/fix-1378143 as a prerequisite.
Commit message:
Ensure that only one ContentHubExport page is open
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous
Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1378143 into
lp:music-app with lp:~vthompson/music-app/release-2.3 as a prerequisite.
Commit message:
Change translation strings to use the word track, rather than song.
Requested reviews:
Music App Developers (music-app-dev
Victor Thompson has proposed merging lp:~vthompson/music-app/release-2.3 into
lp:music-app.
Commit message:
* Release 2.3 and start 2.4
Requested reviews:
Music App Developers (music-app-dev)
For more details, see:
https://code.launchpad.net/~vthompson/music-app/release-2.3/+merge/284198
Public bug reported:
Currently the export song feature in the File Manager allows the user
export any file type to the Clock app to be used as an Alarm tone.
To reproduce:
1. Open the clock app and create a new alarm
2. Click the Sound item
3. Click the "Add sound" button
4. Select the File
Review: Approve
Thanks for your patience with this MP. The code looks good, hands-on testing
looks good, and with the only remaining issue being the keyboard issues with
AP, I say let's land this. Thanks!
--
The proposal to merge lp:~music-app-dev/music-app/media-hub-bg-playlists-rework
into lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
--
Your team Music App
Review: Needs Information
Did something change in rc-proposed for this to break? Currently, loading the
app shows a blank header and no data. I see the following in the log:
file:///opt/click.ubuntu.com/com.ubuntu.music/2.3.939/app/logic/meta-database.js:162:
TypeError: Cannot call method
Review: Needs Fixing
Code updates look good.
However, on Xenial the tests fail--I think the date picker was working, however:
Ran 5 tests in 327.505s
FAILED (failures=5)
Full log: http://paste.ubuntu.com/14573180/
Please add update the README.autopilot to include the following prereq:
Review: Needs Information
I'm not sure this "toggleable" key is as usable as it should be. So far as I
can tell the other keys are more or less complete actions. Since just executing
"CTRL" is a partial action, maybe it should stay highlighted until another key
is selected?
Also, why wasn't
Review: Needs Fixing
This looks good now. We should figure out the Jenkins failure before landing,
however.
--
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
Review: Needs Fixing
Both the "Shuffle" and "Queue all" buttons now do not work for a playlist.
--
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list:
Review: Needs Information
URL handler actions worked as they did previously.
One thing I noticed is that we do not go to the Now Playing page when just a
track is played, whereas when an album is played we do go to the Now Playing
page. The current app does this too--did we consciously do
Review: Needs Fixing
Recent changes look good and fix the Export song issue.
Do we need to add anything to the debian/control file for the in interface?
Also, please update the copyright years where applicable.
--
Review: Needs Fixing
Clicking "shuffle" or "play all" on an empty playlist brings the user to the
Now Playing page. It shouldn't do so and didn't do so before.
--
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
Your team Music App Developers is
The proposal to merge lp:~ahayzen/music-app/cards-use-gridview into
lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
--
Your team Music App Developers is subscribed to
Review: Approve
lgtm! Thanks! :)
--
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
gt; === added file 'app/components/Player.qml'
> --- app/components/Player.qml 1970-01-01 00:00:00 +
> +++ app/components/Player.qml 2016-01-12 01:08:02 +
> @@ -0,0 +1,355 @@
> +/*
> + * Copyright (C) 2015
> + * Andrew Hayzen <ahay...@gmail.com>
> + *
Re-approving to determine if AP failure is repeatable.
--
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into
lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
--
Your team Music App Developers is
The proposal to merge lp:~ahayzen/music-app/fix-1526274-use-layouts into
lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ahayzen/music-app/fix-1526274-use-layouts/+merge/281757
--
Your team Music App Developers is
Review: Needs Fixing
We should raise bug #1386605 as an SDK bug. I don't think it should block this
mp though.
The ArtistView component has some extra margin spacing for the BlurredHeader.
Can that be fixed?
--
https://code.launchpad.net/~ahayzen/music-app/cards-use-gridview/+merge/279700
Review: Needs Fixing
Please see inline comments.
Diff comments:
> === modified file 'app/components/Delegates/MusicListItem.qml'
> --- app/components/Delegates/MusicListItem.qml2015-10-29 23:02:17
> +
> +++ app/components/Delegates/MusicListItem.qml2016-01-06 16:34:44
>
The proposal to merge lp:~nskaggs/music-app/manual-tests into lp:music-app has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nskaggs/music-app/manual-tests/+merge/280777
--
Your team Music App Developers is subscribed to branch
Review: Approve
Lgtm!
--
https://code.launchpad.net/~nskaggs/music-app/manual-tests/+merge/280777
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~fazerlicourice/music-app/test-empty-library into
lp:music-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~fazerlicourice/music-app/test-empty-library/+merge/280794
--
Your team Music App Developers is
Review: Approve
Running from the deksopt:
Tests running...
Ran 20 tests in 392.937s
OK
We can try to fix the flakiness of the tests at a later time--as it wouldn't
have been introduced under this change.
Thanks! lgtm!
--
Review: Needs Fixing
The code for this looks good! I'm not sure however, that we'll want to merge
this into the app. The Ubuntu SDK will be introducing scrollbars sometime soon
and I think it'd be better to use that feature/component as we'll also want to
use it in the Queue and other
Review: Needs Fixing
* What is a "rat condition"? Could you clarify please and fix the applicable
commit/change logs as applicable?
* Please remove the extra asterisk in the changelog.
* Could you add specific steps to reproduce to the bug report?
--
Review: Needs Fixing
Vamshi,
The test still does not work. Here's the log output--I believe you need to ad
"_page" to the method call.
test-log: {{{
18:34:56.811 INFO logging:45 - TestEmptyLibrary: launch_test_local. Arguments
(). Keyword arguments: {}.
18:34:56.811 WARNING base:52 - This
Also, you'll need to resolve the merge conflict in the debian/changelog file.
We get such conflicts frequently as multiple people work to propose merges.
To fix, do the following:
$ bzr merge lp:music-app
Then, fix the conflict in the debian/changelog and save it. Then run:
$ bzr resolve
Review: Needs Fixing
Vamshi,
It seems that the test you added is failing: http://paste.ubuntu.com/14134202/
Should "get_LibraryEmptyState" actually be "get_library_empty_state_page" or
something else perhaps?
--
Review: Approve
LGTM! Thanks! Don't forget to add a commit message.
--
https://code.launchpad.net/~emailgirishrawat/music-app/READMEs/+merge/280920
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post
The proposal to merge lp:~vamrocks602/music-app/test-empty-library into
lp:music-app has been updated.
Commit Message changed to:
* Add test to make sure that the LibraryEmptyState page is visible when no
music is detected on the device.
For more details, see:
Review: Approve
This lgtm and behaves as expected. Thanks for the additional fixes Bartosz!
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
The proposal to merge lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix
into lp:ubuntu-clock-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
--
Your team Ubuntu
Review: Needs Fixing
When I run these tests on the device or when run on the desktop, each test
produces the "No music found" view. Here is the output on the desktop:
http://paste.ubuntu.com/14123722/
--
https://code.launchpad.net/~vamrocks602/music-app/test-empty-library/+merge/280794
Your
I believe the issue with the app crashing is bug #1527737, and is not related
to your fix here.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
Review: Needs Fixing
I don't think we should be setting the schema version of mediascanner2 back to
version 9. If it is perhaps an issue for developers/testers not running the
development release, then we need to add instructions on how to install the
newest release of mediascanner2 that is on
Review: Needs Fixing
Hi Girish! Thanks again. I have a few inline comments for you.
Diff comments:
> === added file 'README-Autopilot.md'
> --- README-Autopilot.md 1970-01-01 00:00:00 +
> +++ README-Autopilot.md 2015-12-18 00:47:41 +
> @@ -0,0 +1,99 @@
> +Running Autopilot
I have two comments, the first should be fixed, the second can wait as I assume
the slider popover will be removed by the fix for bug #1362078.
1. There should be a divider under the alarm volume slider
2. Could we temporarily fix the top margin so the Slider popover doesn't get
obscured by the
Review: Needs Fixing
If you choose to fix the first issue by using the other slider component that
is fine.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
I've added Facundo Batista to the review.
--
https://code.launchpad.net/~vthompson/music-app/fix-1515067/+merge/277306
Your team Music App Developers is requested to review the proposed merge of
lp:~vthompson/music-app/fix-1515067 into lp:music-app.
--
Mailing list:
The proposal to merge
lp:~ycheng-twn/ubuntu-weather-app/ubuntu-weather-app_1432503 into
lp:ubuntu-weather-app/obsolete.trunk has been updated.
Status: Needs review => Rejected
For more details, see:
The Weather app had and has the same issue--we were unable to resolve it. We
(popey, ahayzen, and myself) determined it to be sufficient for now in that
case.
--
https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-uitk1.3/+merge/276650
Your team Ubuntu Clock
Review: Needs Information
Can we not use the existing SDK Slider? Right now we get the following in the
logs:
file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Settings/Menus/SliderMenu.qml:145:13:
QML Slider: Mixing of Ubuntu.Components module versions 1.3 and 1.2 detected!
Also, when I
Review: Needs Fixing
This is looking good so far!
1. I think some of the titles should allow 2 lines of text.
2. We should fix/workaround whatever issue with the header is causing scrolling
to suddenly stop.
3. This change causes bug #1386605 to now plague the ArtistView. Could we fix
that?
--
** Summary changed:
- Certain apps are not being built in the core apps PPA for Trusty
+ Certain apps are not being built in the core apps PPA for Trusty/Vivid/Wily
--
You received this bug notification because you are a member of Ubuntu
File Manager Developers, which is subscribed to Ubuntu
Victor Thompson has proposed merging
lp:~vthompson/ubuntu-weather-app/fix-1521701 into lp:ubuntu-weather-app.
Commit message:
* Change translatable string from "rain" to "precipitation"
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
Related bugs:
Bu
Also, this doesn't appear to fix the actual issue.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
Review: Needs Fixing
Bartosz, you'll need to update the changelog.
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-slider-fix/+merge/280119
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
Review: Approve
Bartosz, I've fixed all the issues I had and updated the changelog.
--
https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/ubuntu-clock-app-uitk1.3/+merge/276650
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
Review: Approve
Thanks Ken. lgtm!
--
https://code.launchpad.net/~ken-vandine/music-app/content-hub-desktop/+merge/279515
Your team Music App Developers is subscribed to branch lp:music-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Victor Thompson has proposed merging
lp:~vthompson/music-app/lighter-now-playing-toolbar into lp:music-app.
Commit message:
* Lighten the Full View and Queue toolbars to match current design
* Lighten the app header
Requested reviews:
Music App Developers (music-app-dev)
For more details
Review: Needs Information
There don't appear to be any regressions on the device. However, I still can't
get this to work on the desktop (unity7). In order to have the content hub hook
on my system, I had to manually install the content-hub package/service. Should
this be added to the app's
Review: Needs Information
Ken, is there an easy way to test this? I'm building the deb (dpkg-buildpackage
-uc -us), installing it, then installing ubuntu-filemanager-app via my ppa [1].
The filemanager doesn't see the music app (or any app on my desktop) as a
content importer.
1 -
Any updated progress on this MP?
--
https://code.launchpad.net/~gang65/ubuntu-clock-app/ubuntu-clock-app-uitk1.3/+merge/276650
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Another small notable thing to mention is that the applicable debian/control
packages should be updated such that the prereq media-hub packages are
installed.
--
https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework/+merge/275912
Your team Music App Developers is
Andrew Hayzen <ahay...@gmail.com>
> + * Victor Thompson <victor.thomp...@gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; v
The proposal to merge
lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into
lp:ubuntu-weather-app has been updated.
Status: Needs review => Superseded
For more details, see:
Victor Thompson has proposed merging
lp:~ubuntu-weather-dev/ubuntu-weather-app/reboot-finish-listitem-migration into
lp:ubuntu-weather-app with lp:~ahayzen/ubuntu-weather-app/reboot-uc1.3-bump as
a prerequisite.
Commit message:
* Finish the migration to the new SDK list items
* Lock weather
Blueprint changed by Victor Thompson:
Work items changed:
Work items:
[vthompson] Create bugs for #needs-autopilot-tests: DONE
[ahayzen] create initial AP framework: DONE
[vthompson] Look at clock app's location detection and start enabling in
weather: DONE
[vthompson] Create list
** Changed in: music-app
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Shorts Developers, which is subscribed to Ubuntu Shorts App.
Matching subscriptions: Ubuntu RSS Reader Bugmail
https://bugs.launchpad.net/bugs/1508363
1 - 100 of 374 matches
Mail list logo
