The proposal to merge lp:~carla-sella/ubuntu-docviewer-app/test-toc into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
--
Your team Ubuntu Document Viewer
Review: Approve
+1 from me, but do change the logger.warn to something else before top
approving.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-06 20:12:16 +
Review: Approve continuous-integration
PASSED: Continuous integration, rev:146
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/216/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2730
deb:
Fixed the part of the while loop.
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:145
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/215/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2716
deb:
Review: Needs Fixing
A few more comments :-)
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-06 19:01:20 +
@@ -8,7 +8,7 @@
msgstr
Project-Id-Version: \n
Forgot to ask: should I wait for balloons' review, before top-approve it?
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
I am not sure if Nicholas has to approve it too, maybe just ask him :), I
usually always ask him to reiview,but maybe it is not necessary.
--
Carla Sella
email: carla.se...@gmail.com
http://about.me/carla.sella
On Tue, May 5, 2015 at 3:02 PM, Stefano Verzegnassi stefano92@gmail.com
wrote:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:143
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713
deb:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:143
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/213/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2713
deb:
Thanks Stefano.
Your fixes worked so your knowledge of Autopilot is good :-).
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
Carla Sella has proposed merging lp:~carla-sella/ubuntu-docviewer-app/test-toc
into lp:ubuntu-docviewer-app.
Commit message:
First test for testing Docviewer app TOC.
Requested reviews:
Nicholas Skaggs (nskaggs)
Stefano Verzegnassi (verzegnassi-stefano)
Related bugs:
Bug #1418652 in
Review: Approve continuous-integration
PASSED: Continuous integration, rev:140
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/210/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2694
deb:
\o/ passed :).
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve continuous-integration
PASSED: Continuous integration, rev:141
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/211/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2695
deb:
Review: Needs Fixing
Hi Carla,
thanks for the MP!
There is an issue that makes tests fail on my PC.
I've added two in-line comment (at lines 56 and 168).
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++
Hi Stefano,
I left replies to your comments.
I will find a fix for your problem and let you know so you can test it.
Diff comments:
=== modified file 'po/com.ubuntu.docviewer.pot'
--- po/com.ubuntu.docviewer.pot 2015-04-27 16:02:40 +
+++ po/com.ubuntu.docviewer.pot 2015-05-02
By the way, Stefano, can you send me the error output you get on your computer
as this does not occur on my Desktop. The strange thing for me is that
self.bottomEdgePageLoaded.wait_for(True) (line 112 of __init__.py) should
work but looks like it's not for you.
Diff comments:
=== modified
Another thing, you are using autopilot3 run -vv test-name to launch the
tests, right?
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:142
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/212/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2700
deb:
Carla Sella has proposed merging lp:~carla-sella/ubuntu-docviewer-app/test-toc
into lp:ubuntu-docviewer-app.
Commit message:
First test for testing Docviewer app TOC.
Requested reviews:
Stefano Verzegnassi (verzegnassi-stefano)
Related bugs:
Bug #1418652 in Ubuntu Document Viewer App:
Still have to fix scrolling.
--
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
Your team Ubuntu Document Viewer Developers is subscribed to branch
lp:ubuntu-docviewer-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
The proposal to merge lp:~carla-sella/ubuntu-docviewer-app/test-toc into
lp:ubuntu-docviewer-app has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~carla-sella/ubuntu-docviewer-app/test-toc/+merge/258082
--
Your team Ubuntu Document
23 matches
Mail list logo
