The proposal to merge lp:~flscogna/ubuntu-terminal-app/profile-selection into
lp:ubuntu-terminal-app has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
--
Your team Ubuntu Terminal Deve
The proposal to merge lp:~flscogna/ubuntu-terminal-app/profile-selection into
lp:ubuntu-terminal-app has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
--
Your team Ubuntu Termina
Review: Approve
That fixed it!
--
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to :
Review: Approve continuous-integration
PASSED: Continuous integration, rev:77
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/149/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2871
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic
Ok, there was an issue when the last profile was active and unselected from the
settings. This should work fine now.
--
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
-
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:76
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/148/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2870/console
FAILURE:
http://91.189.93.70:8080/job/ubuntu-termi
Review: Needs Fixing
There seems to be a breakage in some use cases.
Add a few layouts
Go back to the main terminal screen
Select one as the current one
Go back to layout settings, de-select the one set as current
Expected behaviour:- Switch to another layout (next in list for example), or
un-s
Alan, when you have some time give this a go. The colour might be tweaked a
bit, but I think the result is decent.
--
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Review: Approve continuous-integration
PASSED: Continuous integration, rev:75
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/146/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2797
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic
Sorry, I completely forgot about this merge proposal. I'll work on it in
the next two days.
2015-05-19 11:22 GMT+02:00 Alan Pope :
> Are you planning to add the grey icon in this merge? If so, when can we
> expect that?
> --
>
> https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-s
Are you planning to add the grey icon in this merge? If so, when can we expect
that?
--
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchp
Ok, you make a good argument. Let's go with your plan.
--
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
Your team Ubuntu Terminal Developers is subscribed to branch
lp:ubuntu-terminal-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-r
We already have a setting to completely disable the keyboard bar (in the main
page).
The state which might be confusing here is: "Show Keyboard Bar" is turned on,
but all profiles are disabled.
I'd personally not mix profiles selection with bar visibility. I'm thinking
some day we'll have a key
I prefer 2).
If someone doesn't want to 'waste' the screen real-estate used by the layout,
so switches them all off, they'll be disappointed that they don't gain space
IMO.
If we force a profile to be active, we're forcing that 'waste' of space for
users who don't need it.
I would default to
Alan, we can theoretically hide the keyboard button, but what about the row? If
we hide only the button, we would basically have a black useless rectangle at
the bottom.
Let's discuss some options:
1) Leave the current situation, with a useless bar and a useless button. (quite
bad but predictab
Review: Needs Fixing
I set no profiles active, but still see the keyboard button. Can we hide that
when all keyboard layouts are disabled?
http://people.canonical.com/~alan/screenshots/device-2015-04-13-120147.png
Other than that, looks great.
--
https://code.launchpad.net/~flscogna/ubuntu-te
Review: Approve continuous-integration
PASSED: Continuous integration, rev:73
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/144/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2481
deb:
http://91.189.93.70:8080/job/generic-mediumtests-utopic
Filippo Scognamiglio has proposed merging
lp:~flscogna/ubuntu-terminal-app/profile-selection into lp:ubuntu-terminal-app.
Commit message:
Custom profile visibility in settings
Requested reviews:
Alan Pope (popey)
For more details, see:
https://code.launchpad.net/~flscogna/ubuntu-terminal-ap
18 matches
Mail list logo
