Review: Approve
I believe we don't need GETTEXT_LOCALEDIR unless we're explicitly using it
somewhere.
IIRC we use LOCALEDIR to install the .mo files in the right locations in clock,
which is probably defined here:
Ack. Thnx for the review dpm, mzanetti.
--
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.
--
Mailing list:
The proposal to merge
lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into
lp:ubuntu-clock-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
--
Your
Review: Needs Information
As per the discussion on IRC, I changed the tr() calls to _() calls to make it
compatible with gettext(). The only one thing I am not sure about is in
Review: Approve continuous-integration
PASSED: Continuous integration, rev:215
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/620/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2166
deb:
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into
lp:ubuntu-clock-app.
Commit message:
Fixes predefined local city and countries list not being translatable in the
timezone selection page.
Requested reviews:
Ubuntu Clock
Review: Approve continuous-integration
PASSED: Continuous integration, rev:210
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/617/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2145
deb:
7 matches
Mail list logo
