The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:630
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1161/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2732/console
FAILURE:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:631
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1163/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2735
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:629
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1159/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2720
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:628
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1158/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2719
deb:
Kunal, ideally we should have a test that covers tapping to create an event.
Since event creation is well covered, this test could be written easily enough
by opening the dayview and tapping under a few scenarios (on an event, on a
blank timeslot, between slots), ensuring the proper response
Review: Needs Fixing
Some suggested changes.
Diff comments:
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2015-03-18 23:56:25 +
+++ NewEvent.qml 2015-04-19 01:45:37 +
@@ -215,6 +215,12 @@
event.setDetail(audibleReminder);
}
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/493/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2633
deb:
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:624
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1150/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2627/console
FAILURE:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:622
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1146/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2616
deb:
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent
into lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent/+merge/254175
--
Your team Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:619
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1129/
Executed test runs:
FAILURE:
http://91.189.93.70:8080/job/generic-mediumtests-utopic/2499/console
FAILURE:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:621
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1132/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2503
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:618
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1116/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2444
deb:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:617
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1114/
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2442
deb:
Tapping created an event at 21:26, I think it should create an event which
locks to the nearest 30 minutes.
As per current implementation we are truncating minutes and creating event for
currently touched hour.
It should have created event rounding to hour, for your case it should have
Tapping created an event at 21:26, I think it should create an event which
locks to the nearest 30 minutes.
The event is created, and then two more button presses are required (tap event,
tap edit) to edit the event to change the title from Untitled. Would it make
more sense to go directly to
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:616
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci//
Executed test runs:
UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2427
deb:
Kunal Parmar has proposed merging
lp:~pkunal-parmar/ubuntu-calendar-app/TapToCreateEvent into
lp:ubuntu-calendar-app.
Commit message:
Resolves Bug #1378380
Add event on tap
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1378380 in Ubuntu Calendar
22 matches
Mail list logo
