Review: Needs Fixing
Thanks for the fix! Looks good to me, I'd just suggest to add a translator
comment here. (See inline comment)
Diff comments:
=== modified file 'TimeLineHeader.qml'
--- TimeLineHeader.qml2015-02-26 16:44:43 +
+++ TimeLineHeader.qml2015-03-05 08:07:05
So what david wanted was something like,
// TRANSLATORS: W refers to Week, followed by the actual week number (%1)
text: i18n.tr(W%1).arg(root.weekNumber)
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is
@Richard, just before the i18n.tr() line, you add a comment,
// TRANSLATORS: Some random translator comment
When you build and run the app, the pot file should be updated to include the
TRANSLATORS comment.
--
And how can I add a translator comment?
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
The proposal to merge lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501
into lp:ubuntu-calendar-app has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
--
Your team
Review: Approve
Looks good to me, thanks!
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
Review: Approve continuous-integration
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
The proposal to merge lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501
into lp:ubuntu-calendar-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
--
Your team Ubuntu
Review: Needs Fixing
Thanks Richard, that's all that needs to be done. I.e. applying the fix,
committing and pushing it. Then when everything is fine, a core app dev will
approve the merge proposal, automated tests will be run against it and when
they pass it will be merged to trunk.
That
Richard Somlói has proposed merging
lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into
lp:ubuntu-calendar-app.
Requested reviews:
Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
Bug #1428501 in Ubuntu Calendar App: Translatable string change suggestion
Review: Approve code review
Code wise patch seems good
--
https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878
Your team Ubuntu Calendar Developers is subscribed to branch
lp:ubuntu-calendar-app.
--
Mailing list:
11 matches
Mail list logo
