Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Martin Borho
The requests to the API where originally in a WorkerScript, but a former Qt upgrade (5.2?!) broke it terribly. So I've removed it. Don't know if would work again now in a WorkerScript, some time gone by since then. Should be easy to reimplement again, the revision it was changed:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Martin Borho
I've readded the worker, seems to work again https://code.launchpad.net/~martin-borho/ubuntu-weather-app/reboot-worker Try out, if this would work out for us? -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage/+merge/252962 Your team Ubuntu Weather

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Victor Thompson
It doesn't seem to unblock the UI. I still get a blank screen with no settings icon. OWM still seems to be down, so you can test against that if you want. Here's an example URL: http://api.openweathermap.org/data/2.5/forecast/daily?id=5037649cnt=10units=metric I wonder if in the future we

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Martin Borho
Perfect! :) -- https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage/+merge/252962 Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Victor Thompson
Ok, one last thought on this. I tried your MP with the solution below and it works well. Could you propose your reboot-worker mp with the following change? 12 -Component.onCompleted: refreshData(); 13 +Component.onCompleted: { 14 +storage.getLocations(fillPages);

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-14 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:22 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/47/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/17 SUCCESS:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-13 Thread Victor Thompson
Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot. Commit message: Get initial data from storage to not block the UI thread. Requested reviews: Ubuntu Weather Developers (ubuntu-weather-dev) For more

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-13 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:20 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/15 SUCCESS: