Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-calendar-app/current-day-month-year-selected into lp:ubuntu-calendar-app

2015-03-05 Thread Carla Sella
This mp should be complete now. -- https://code.launchpad.net/~carla-sella/ubuntu-calendar-app/current-day-month-year-selected/+merge/251387 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carla-sella/ubuntu-calendar-app/current-day-month-year-selected into lp:ubuntu-calendar-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:601 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1105/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2258 deb:

[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot

2015-03-05 Thread Andrew Hayzen
Blueprint changed by Andrew Hayzen: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): TODO [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones: TODO

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/cleanup-debug into lp:reminders-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:376 http://91.189.93.70:8080/job/reminders-app-ci/700/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2261 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-clock-app/sound-and-repeat-on-click into lp:ubuntu-clock-app

2015-03-05 Thread Victor Thompson
I agree, ensuring that the other CheckBox components are not checked is no longer necessary. -- https://code.launchpad.net/~vthompson/ubuntu-clock-app/sound-and-repeat-on-click/+merge/250546 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-fix-1428913 into lp:music-app/refactor

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:843 http://91.189.93.70:8080/job/music-app-refactor-ci/45/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2267 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-fix-1428913 into lp:music-app/refactor

2015-03-05 Thread Victor Thompson
Victor Thompson has proposed merging lp:~vthompson/music-app/refactor-fix-1428913 into lp:music-app/refactor. Commit message: Trigger list reset animation when the index did not change. Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1428913 in Ubuntu Music App:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-split-now-playing-queue-full-view into lp:music-app/refactor

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:843 http://91.189.93.70:8080/job/music-app-refactor-ci/43/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2259 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/fix-1428913 into lp:music-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:845 http://91.189.93.70:8080/job/music-app-ci/1280/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2266 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/music-app/refactor-music-app-startup-model-console-warning-and-translations into lp:music-app/refactor

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:843 http://91.189.93.70:8080/job/music-app-refactor-ci/46/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2268 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread Niklas Wenzel
Thanks again. :) -- https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread noreply
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-wrap/+merge/251924 -- Your team Ubuntu Clock Developers is

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app

2015-03-05 Thread noreply
The proposal to merge lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985 -- Your team Ubuntu Reminders app

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

2015-03-05 Thread Richard Somlói
Richard Somlói has proposed merging lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app. Requested reviews: Ubuntu Calendar Developers (ubuntu-calendar-dev) Related bugs: Bug #1428501 in Ubuntu Calendar App: Translatable string change suggestion

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread Nekhelesh Ramananthan
Looks fine to me. I just have one suggestion which I've added to the diff. That being said, I'll happily approve this if you apply that small change. :) Thanks for the review. Originally I chose not to put wrapMode for title since it is supposed to be short and discourage 3rd party devs from

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:209 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/622/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2253 deb:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app

2015-03-05 Thread Alan Pope 
Review: Approve LGTM -- https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985 Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to :

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app

2015-03-05 Thread David Planella
Review: Approve I believe we don't need GETTEXT_LOCALEDIR unless we're explicitly using it somewhere. IIRC we use LOCALEDIR to install the .mo files in the right locations in clock, which is probably defined here:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-image-widths into lp:reminders-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:374 http://91.189.93.70:8080/job/reminders-app-ci/698/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2256 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~mzanetti/reminders-app/fix-image-widths into lp:reminders-app

2015-03-05 Thread Michael Zanetti
Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-image-widths into lp:reminders-app. Commit message: Always override image's widths to make it look good on our screen Requested reviews: Ubuntu Reminders app developers (reminders-app-dev) For more details, see:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into lp:ubuntu-calendar-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:580 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1102/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2249 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/bug_1413462 into lp:ubuntu-calendar-app

2015-03-05 Thread Kunal Parmar
Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/bug_1413462 into lp:ubuntu-calendar-app. Commit message: Resolves Bug #1413462 Resetting seconds to 0 before setting the date Requested reviews: Ubuntu Calendar Developers (ubuntu-calendar-dev) For more details, see:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread Nekhelesh Ramananthan
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app. Commit message: Fixed the empty state message not wrapping correctly. Requested reviews: Ubuntu Clock Developers (ubuntu-clock-dev) Related bugs: Bug #1428165 in Ubuntu Clock

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into lp:ubuntu-calendar-app

2015-03-05 Thread Alan Pope 
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into lp:ubuntu-calendar-app has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/LiveEventModification/+merge/247711 -- Your

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app

2015-03-05 Thread Nekhelesh Ramananthan
Ack. Thnx for the review dpm, mzanetti. -- https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app

2015-03-05 Thread noreply
The proposal to merge lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180 -- Your

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501 into lp:ubuntu-calendar-app

2015-03-05 Thread Kunal Parmar
Review: Approve code review Code wise patch seems good -- https://code.launchpad.net/~ricsipontaz/ubuntu-calendar-app/fix-for-bug-1428501/+merge/251878 Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/bug_1413462 into lp:ubuntu-calendar-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:600 http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1103/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2251 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into lp:ubuntu-calendar-app

2015-03-05 Thread noreply
The proposal to merge lp:~pkunal-parmar/ubuntu-calendar-app/LiveEventModification into lp:ubuntu-calendar-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/LiveEventModification/+merge/247711 -- Your team

[Ubuntu-touch-coreapps-reviewers] [Bug 1377638] Re: [All Apps] Core apps should use the new splash screen features

2015-03-05 Thread Stefano Verzegnassi
** Changed in: ubuntu-docviewer-app Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu File Manager Developers, which is subscribed to Ubuntu File Manager App. Matching subscriptions: File Manager App Bugmail, Ubuntu RSS Reader

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-wrap into lp:ubuntu-clock-app

2015-03-05 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:208 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/621/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2252 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into lp:music-app/refactor

2015-03-05 Thread Andrew Hayzen
Andrew Hayzen has proposed merging lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into lp:music-app/refactor. Commit message: * Destroy dialog before popping page Requested reviews: Music App Developers (music-app-dev) Related bugs: Bug #1428450 in Ubuntu Music App: