Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-13 Thread Riccardo Padovani
Should be ok now, sorry again -- https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app/reboot. -- Mailing list:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-13 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:128 http://91.189.93.70:8080/job/ubuntu-calculator-app-reboot-ci/125/ Executed test runs: UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2341 deb:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-13 Thread Bartosz Kosiorek
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot

2015-03-13 Thread Bartosz Kosiorek
The proposal to merge lp:~rpadovani/ubuntu-calculator-app/favouritesScreenBlank into lp:ubuntu-calculator-app/reboot has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/favouritesScreenBlank/+merge/252155 --

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-13 Thread Victor Thompson
Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot. Commit message: Get initial data from storage to not block the UI thread. Requested reviews: Ubuntu Weather Developers (ubuntu-weather-dev) For more

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app/reboot

2015-03-13 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:20 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/15 SUCCESS:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app

2015-03-13 Thread noreply
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838 -- Your team Ubuntu Clock

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into lp:ubuntu-clock-app

2015-03-13 Thread David Planella
Review: Approve Looks good to me, just added two notes. Diff comments: === modified file 'app/alarm/AlarmSettingsPage.qml' --- app/alarm/AlarmSettingsPage.qml 2014-10-16 19:03:51 + +++ app/alarm/AlarmSettingsPage.qml 2015-03-12 23:25:02 + @@ -50,10 +50,10 @@

[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot

2015-03-13 Thread Victor Thompson
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones:

[Ubuntu-touch-coreapps-reviewers] [Blueprint weather-reboot] Weather App Reboot

2015-03-13 Thread Victor Thompson
Blueprint changed by Victor Thompson: Work items changed: Work items: [popey] ping mail out to arrange next meeting time/day (wed evening?): DONE [nik90] Move all the design documents to one common google drive folder: DONE [popey] Create new blueprint and add work items / milestones:

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~vthompson/ubuntu-weather-app/reboot-add-temp-to-locations into lp:ubuntu-weather-app/reboot

2015-03-13 Thread Ubuntu Phone Apps Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:19 http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/41/ Executed test runs: SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/11 SUCCESS:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app

2015-03-13 Thread Nekhelesh Ramananthan
Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app. Commit message: Made the expandable list item used in AlarmSettings.qml into a generic component to avoid code duplication and also polished its visual style (related to

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~nik90/ubuntu-clock-app/improve-setting-listitem into lp:ubuntu-clock-app

2015-03-13 Thread Ubuntu Phone Apps Jenkins Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:221 http://91.189.93.70:8080/job/ubuntu-clock-app-ci/627/ Executed test runs: FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2340/console Click here to trigger a rebuild: