Sorry to interject in this code review, but the Widelands team is currently
investigating using test bots on Launchpad that check pull requests. Your team
seem to have managed to do that, could you share some insights/configuration
hints/documentation about the process? Are you using a
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-translation-plural-forms/+merge/252838
--
Your team Ubuntu Clock
Review: Approve
Looks good to me, just added two notes.
Diff comments:
=== modified file 'app/alarm/AlarmSettingsPage.qml'
--- app/alarm/AlarmSettingsPage.qml 2014-10-16 19:03:51 +
+++ app/alarm/AlarmSettingsPage.qml 2015-03-12 23:25:02 +
@@ -50,10 +50,10 @@
Nekhelesh Ramananthan has proposed merging
lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms into
lp:ubuntu-clock-app.
Commit message:
Added plural translation forms to strings in the AlarmSettings.qml file.
Requested reviews:
Ubuntu Clock Developers (ubuntu-clock-dev)
Related bugs:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:219
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/626/
Executed test runs:
SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2338
deb:
The proposal to merge lp:~nik90/ubuntu-clock-app/fix-translation-plural-forms
into lp:ubuntu-clock-app has been updated.
Description changed to:
- Added plural translation forms to strings in the AlarmSettings.qml file.
- Updated pot file to also include the corrected city name Simferopol that
6 matches
Mail list logo
