[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

2016-09-15 Thread noreply
The proposal to merge lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206 -- Your team Ubuntu Terminal

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

2016-09-15 Thread Jenkins Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:209 https://core-apps-jenkins.ubuntu.com/job/terminal-app-ci/58/ Executed test runs: None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/974/console Click here to trigger a rebuild:

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

2016-09-15 Thread David Planella
The proposal to merge lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~popey/ubuntu-terminal-app/add-snapcraft-config/+merge/305206 -- Your team Ubuntu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

2016-09-15 Thread David Planella
Review: Approve Looks good to me, thanks! I think we can merge it as it is. CLICK_MODE=on is not necessary and installs extra files [1], but it seems the snap works, so we might as well leave it as it is for a first pass. [1]