Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~popey/ubuntu-terminal-app/add-snapcraft-config into lp:ubuntu-terminal-app

2016-09-15 Thread Alan Pope 🍺🐧🐱
Thanks for the comments - fixing! Diff comments: > === added file 'snapcraft.yaml' > --- snapcraft.yaml1970-01-01 00:00:00 + > +++ snapcraft.yaml2016-09-08 11:44:05 + > @@ -0,0 +1,40 @@ > +name: ubuntu-terminal-app > +version: 0.7.207 > +summary: Ubuntu Terminal app > +description

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app

2016-09-19 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~themuso/ubuntu-terminal-app/yakkety-packaging-updates/+merge/306050 -- Your team

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~themuso/ubuntu-terminal-app/yakkety-packaging-updates into lp:ubuntu-terminal-app

2016-09-19 Thread Alan Pope 🍺🐧🐱
Review: Approve Many thanks Luke! -- https://code.launchpad.net/~themuso/ubuntu-terminal-app/yakkety-packaging-updates/+merge/306050 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app

2016-09-19 Thread Alan Pope 🍺🐧🐱
Review: Disapprove Thanks Larry. Apologies for the lengthy delay in responding. As discussed on irc, this merge has been superseded. -- https://code.launchpad.net/~larryprice/ubuntu-terminal-app/fix-cmake-xenial/+merge/297394 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubunt

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app

2016-09-19 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~larryprice/ubuntu-terminal-app/fix-cmake-xenial into lp:ubuntu-terminal-app has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/fix-cmake-xenial/+merge/297394 -- Your team Ubuntu Termi

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/update-qmltermwidget into lp:ubuntu-terminal-app

2016-09-20 Thread Alan Pope 🍺🐧🐱
Review: Approve LGTM - thanks Larry! -- https://code.launchpad.net/~larryprice/ubuntu-terminal-app/update-qmltermwidget/+merge/306107 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Pos

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/update-qmltermwidget into lp:ubuntu-terminal-app

2016-09-20 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~larryprice/ubuntu-terminal-app/update-qmltermwidget into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/update-qmltermwidget/+merge/306107 -- Your team Ubun

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app

2016-09-20 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~larryprice/ubuntu-terminal-app/missing-settings-dep/+merge/306111 -- Your team Ubun

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~larryprice/ubuntu-terminal-app/missing-settings-dep into lp:ubuntu-terminal-app

2016-09-20 Thread Alan Pope 🍺🐧🐱
Review: Approve Good spot, thanks Larry. -- https://code.launchpad.net/~larryprice/ubuntu-terminal-app/missing-settings-dep/+merge/306111 Your team Ubuntu Terminal Developers is subscribed to branch lp:ubuntu-terminal-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app

2016-09-21 Thread Alan Pope 🍺🐧🐱
Review: Approve Terribly sorry this languished for so long. -- https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async/+merge/294122 Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app. -- Mailing list: https://l

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app

2016-09-21 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-async into lp:ubuntu-docviewer-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/content-hub-dont-load-as

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~laney/ubuntu-terminal-app/notshowin-unity into lp:ubuntu-terminal-app

2016-09-27 Thread Alan Pope 🍺🐧🐱
Interestingly this fails click-review, if built as a click (which we do for the phone, although armhf, not amd64 as in the example below)... Now executing: click-review ./com.ubuntu.terminal_0.7.217_amd64.click Errors -- - desktop:validates:terminal did not validate: (ValidationError

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app

2016-10-10 Thread Alan Pope 🍺🐧🐱
Running snapcraft on this branch in xenial results in:- Error downloading stage packages for part 'ubuntu-filemanager-app': no such package 'qtdeclarative5-nemo-qml-plugin-folderlistmodel' Is this only intended to work on yakkety? -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-ap

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app

2016-10-11 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snappy/+merge/308050 -- Your team Ubuntu File Manager D

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-filemanager-app/snappy into lp:ubuntu-filemanager-app

2016-10-11 Thread Alan Pope 🍺🐧🐱
Review: Approve LGTM! -- https://code.launchpad.net/~renatofilho/ubuntu-filemanager-app/snappy/+merge/308050 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/new-snappy into lp:ubuntu-calculator-app

2016-11-11 Thread Alan Pope 🍺🐧🐱
Review: Approve LGTM! Tested on Ubuntu desktop. -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/new-snappy/+merge/310663 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-revie

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/new-snappy into lp:ubuntu-calculator-app

2016-11-11 Thread Alan Pope 🍺🐧🐱
The proposal to merge lp:~renatofilho/ubuntu-calculator-app/new-snappy into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/new-snappy/+merge/310663 -- Your team Ubuntu Calculato

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app

2016-11-16 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Approve LGTM! -- https://code.launchpad.net/~renatofilho/ubuntu-clock-app/new-snappy/+merge/310585 Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-r

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app

2016-11-16 Thread Alan Pope 🍺🐧🐱 πŸ¦„
The proposal to merge lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-clock-app/new-snappy/+merge/310585 -- Your team Ubuntu Clock Developers is subs

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app

2016-11-16 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Approve -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/all-arch/+merge/311011 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-c

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app

2016-11-16 Thread Alan Pope 🍺🐧🐱 πŸ¦„
The proposal to merge lp:~renatofilho/ubuntu-calculator-app/all-arch into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/all-arch/+merge/311011 -- Your team Ubuntu Calculator De

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app

2016-11-22 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Needs Fixing The Icon path should really be:- Icon=${SNAP}/meta/gui/icon.png Rather than hard wiring the /snap path, as there is no guarantee that /snap is valid on all platforms. -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401 Your team Ubu

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app

2016-11-22 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Approve LGTM -- https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401 Your team Ubuntu Calculator Developers is subscribed to branch lp:ubuntu-calculator-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubunt

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app

2016-11-22 Thread Alan Pope 🍺🐧🐱 πŸ¦„
The proposal to merge lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/ubuntu-calculator-app/fix-icon-snap/+merge/311401 -- Your team Ubuntu Cal

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app

2016-12-05 Thread Alan Pope 🍺🐧🐱 πŸ¦„
The proposal to merge lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~renatofilho/reminders-app/snappy-unity8/+merge/312393 -- Your team Ubuntu Notes app developers is sub

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~renatofilho/reminders-app/snappy-unity8 into lp:reminders-app

2016-12-05 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Approve LGTM -- https://code.launchpad.net/~renatofilho/reminders-app/snappy-unity8/+merge/312393 Your team Ubuntu Notes app developers is subscribed to branch lp:reminders-app. -- Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers Post to : ubuntu-touch-coreapps-r

[Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app

2017-01-27 Thread Alan Pope 🍺🐧🐱 πŸ¦„
The proposal to merge lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051/+mer

Re: [Ubuntu-touch-coreapps-reviewers] [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp:ubuntu-filemanager-app

2017-01-27 Thread Alan Pope 🍺🐧🐱 πŸ¦„
Review: Approve Tested on up to date M10, that fixed the crasher. Many thanks. -- https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051/+merge/315772 Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app. -- Mailing lis