[Ubuntu-webapps-bugs] [Bug 1503639] Re: Stop reference counting BrowserContext
** Changed in: oxide/1.18 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu WebApps bug tracking, which is subscribed to Oxide. https://bugs.launchpad.net/bugs/1503639 Title: Stop reference counting BrowserContext Status in Oxide: Fix Released Status in Oxide 1.18 series: Fix Released Bug description: BrowserContext is currently reference counted, with WebContext holding a reference and WebViewContentsHelper holding a reference for each WebContents. We currently use base::RefCountedThreadSafe in order to customize the delete behaviour (BrowserContext is deleted via BrowserContextDestroyer, to ensure it outlives any RenderProcessHosts), but this is confusing because the class isn't thread safe (it also uses base::NonThreadSafe and we assert on most entry points that they are called on the UI thread). We should stop reference counting it and have WebContext own it exclusively. BrowserContextDestroyer should then ensure it outlives any WebContents. Any classes that want to reference a BrowserContext should either implement BrowserContextObserver (which provides a notification when it's deleted) or use BrowserContextID (and we could provide a helper to map between BrowserContextID and BrowserContext) To manage notifications about this bug go to: https://bugs.launchpad.net/oxide/+bug/1503639/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-webapps-bugs Post to : ubuntu-webapps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-webapps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-webapps-bugs] [Bug 1503639] Re: Stop reference counting BrowserContext
** Also affects: oxide/1.18 Importance: Undecided Status: New ** Changed in: oxide/1.18 Importance: Undecided => Low ** Changed in: oxide/1.18 Status: New => Fix Committed ** Changed in: oxide/1.18 Milestone: None => 1.18.2 ** Changed in: oxide/1.18 Assignee: (unassigned) => Chris Coulson (chrisccoulson) -- You received this bug notification because you are a member of Ubuntu WebApps bug tracking, which is subscribed to Oxide. https://bugs.launchpad.net/bugs/1503639 Title: Stop reference counting BrowserContext Status in Oxide: Fix Released Status in Oxide 1.18 series: Fix Committed Bug description: BrowserContext is currently reference counted, with WebContext holding a reference and WebViewContentsHelper holding a reference for each WebContents. We currently use base::RefCountedThreadSafe in order to customize the delete behaviour (BrowserContext is deleted via BrowserContextDestroyer, to ensure it outlives any RenderProcessHosts), but this is confusing because the class isn't thread safe (it also uses base::NonThreadSafe and we assert on most entry points that they are called on the UI thread). We should stop reference counting it and have WebContext own it exclusively. BrowserContextDestroyer should then ensure it outlives any WebContents. Any classes that want to reference a BrowserContext should either implement BrowserContextObserver (which provides a notification when it's deleted) or use BrowserContextID (and we could provide a helper to map between BrowserContextID and BrowserContext) To manage notifications about this bug go to: https://bugs.launchpad.net/oxide/+bug/1503639/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-webapps-bugs Post to : ubuntu-webapps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-webapps-bugs More help : https://help.launchpad.net/ListHelp
[Ubuntu-webapps-bugs] [Bug 1503639] Re: Stop reference counting BrowserContext
** Changed in: oxide Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu WebApps bug tracking, which is subscribed to Oxide. https://bugs.launchpad.net/bugs/1503639 Title: Stop reference counting BrowserContext Status in Oxide: Fix Released Bug description: BrowserContext is currently reference counted, with WebContext holding a reference and WebViewContentsHelper holding a reference for each WebContents. We currently use base::RefCountedThreadSafe in order to customize the delete behaviour (BrowserContext is deleted via BrowserContextDestroyer, to ensure it outlives any RenderProcessHosts), but this is confusing because the class isn't thread safe (it also uses base::NonThreadSafe and we assert on most entry points that they are called on the UI thread). We should stop reference counting it and have WebContext own it exclusively. BrowserContextDestroyer should then ensure it outlives any WebContents. Any classes that want to reference a BrowserContext should either implement BrowserContextObserver (which provides a notification when it's deleted) or use BrowserContextID (and we could provide a helper to map between BrowserContextID and BrowserContext) To manage notifications about this bug go to: https://bugs.launchpad.net/oxide/+bug/1503639/+subscriptions -- Mailing list: https://launchpad.net/~ubuntu-webapps-bugs Post to : ubuntu-webapps-bugs@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-webapps-bugs More help : https://help.launchpad.net/ListHelp
