Public bug reported:
The "is_guest" parameter has been removed, so our implementation is
never called. This doesn't break popup blocking though because we also
set a preferences on the renderer side to reject them. This is really an
extra layer of safety.
This was picked up with a build against canary, which seems to enable
C++11 (so we get final and override keywords)
** Affects: oxide
Importance: Medium
Status: Triaged
** Affects: oxide/1.1
Importance: Medium
Status: Triaged
** Also affects: oxide/1.1
Importance: Undecided
Status: New
** Changed in: oxide/1.1
Importance: Undecided => Medium
** Changed in: oxide/1.1
Status: New => Triaged
** Changed in: oxide
Status: New => Invalid
** Changed in: oxide/1.1
Milestone: None => 1.1.0
** Changed in: oxide
Status: Invalid => Triaged
** Changed in: oxide
Importance: Undecided => Medium
** Changed in: oxide
Milestone: None => branch-1.2
--
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1337389
Title:
The prototype to ContentBrowserClient::CanCreateWindow() has changed
Status in Oxide Webview:
Triaged
Status in Oxide 1.1 series:
Triaged
Bug description:
The "is_guest" parameter has been removed, so our implementation is
never called. This doesn't break popup blocking though because we also
set a preferences on the renderer side to reject them. This is really
an extra layer of safety.
This was picked up with a build against canary, which seems to enable
C++11 (so we get final and override keywords)
To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1337389/+subscriptions
--
Mailing list: https://launchpad.net/~ubuntu-webapps-bugs
Post to : ubuntu-webapps-bugs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-webapps-bugs
More help : https://help.launchpad.net/ListHelp
