[Ubuntustudio-bugs] [Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Erich Eickmeyer
** Changed in: ubuntustudio Status: In Progress => Fix Committed ** Changed in: dpf-plugins Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Studio Bugs, which is subscribed to the bug report.

[Ubuntustudio-bugs] [Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Erich Eickmeyer
Fix for control file pushed. ** Changed in: ubuntu Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Studio Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging]

[Ubuntustudio-bugs] [Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
NOTE: This was fixed by Eickmeyer in the code as well as the invalid changelog target. https://git.launchpad.net/dpf- plugins/commit/?id=db45f68223a5461d2de4ebe1efdde418d76ee4fd fixes the description concerns. >From my perspective this package *looks* clean, so I'll sponsor it into NEW. It will

[Ubuntustudio-bugs] [Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
Looks like some lines got blended togehter, the individual formats are defined in the first lines, and that ended up being missed. I blame myself for that. Digging further, I've made revisions to my assessment. dpf-plugins-common says: " Collection of DPF-based plugins in LADSPA, DSSI, LV2 and

[Ubuntustudio-bugs] [Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
FOR THE RECORD: I've been taking my time working on this review for about a week now, so as not to overwork vs. the other work I do outside Ubuntu. Static Code Analysis Tools Results (CodeWarrior) Static code analysis of the C/C++ driven files present shows some TOCTOU risk and potential command