Re: Alignment fixups for gethostbyname_r

2008-01-07 Thread Daniel Jacobowitz
On Sun, Jan 06, 2008 at 01:35:53AM -0500, Mike Frysinger wrote: On Wednesday 19 December 2007, Daniel Jacobowitz wrote: --- libc/inet/resolv.c  (revision 189757) +++ libc/inet/resolv.c  (local) @@ -1534,6 +1534,15 @@ int attribute_hidden __read_etc_hosts_r( char *cp, **alias;    

Re: Alignment fixups for gethostbyname_r

2008-01-07 Thread Mike Frysinger
On Monday 07 January 2008, Daniel Jacobowitz wrote: On Sun, Jan 06, 2008 at 01:35:53AM -0500, Mike Frysinger wrote: On Wednesday 19 December 2007, Daniel Jacobowitz wrote: --- libc/inet/resolv.c  (revision 189757) +++ libc/inet/resolv.c  (local) @@ -1534,6 +1534,15 @@ int

Re: Alignment fixups for gethostbyname_r

2008-01-07 Thread Daniel Jacobowitz
On Mon, Jan 07, 2008 at 11:39:39AM -0500, Mike Frysinger wrote: i misunderstood the purpose of the second assignment. i'll put together a test case and commit a fix ... Thank you! - buflen -= i, not plus i pointed this typo out already ... Sorry, stray list filters. -- Daniel

Re: Alignment fixups for gethostbyname_r

2008-01-06 Thread Carmelo Amoroso
Mike Frysinger wrote: On Saturday 22 December 2007, Carmelo Amoroso wrote: Daniel Jacobowitz wrote: MontaVista noticed that when their kernels were configured to trap on unaligned access gethostbyname_r could mysteriously crash. I tracked this down to an unaligned buffer being passed to

Re: Alignment fixups for gethostbyname_r

2008-01-05 Thread Mike Frysinger
On Sunday 06 January 2008, Mike Frysinger wrote: buflen += i; err, that should be -= of course ... but you get the gist of where i'm trying to take the changes ;) -mike signature.asc Description: This is a digitally signed message part. ___ uClibc

Re: Alignment fixups for gethostbyname_r

2007-12-31 Thread Rob Landley
On Monday 31 December 2007 02:05:01 Carmelo Amoroso wrote: Rob Landley wrote: On Sunday 30 December 2007 14:02:22 Carmelo Amoroso wrote: Sorry for the misunderstanding, I meant the nptl port for sh4 in ST (actually included into svn nptl branch). No a new branch at all. The merge status

Re: Alignment fixups for gethostbyname_r

2007-12-30 Thread Carmelo Amoroso
Rob Landley wrote: On Saturday 22 December 2007 00:35:10 Carmelo Amoroso wrote: Hi Daniel, I've merged it into my sh4-nptl branch to do some tests, How many nptl branches are there currently, and what's the merge status thereof? I've lost track again... Rob Sorry for the

Re: Alignment fixups for gethostbyname_r

2007-12-30 Thread Carmelo Amoroso
Rob Landley wrote: On Sunday 30 December 2007 14:02:22 Carmelo Amoroso wrote: Sorry for the misunderstanding, I meant the nptl port for sh4 in ST (actually included into svn nptl branch). No a new branch at all. The merge status is that sh4 nptl code has been merged into the branch. Steve is

Re: Alignment fixups for gethostbyname_r

2007-12-28 Thread Rob Landley
On Saturday 22 December 2007 00:35:10 Carmelo Amoroso wrote: Hi Daniel, I've merged it into my sh4-nptl branch to do some tests, How many nptl branches are there currently, and what's the merge status thereof? I've lost track again... Rob -- One of my most productive days was throwing away

Re: Alignment fixups for gethostbyname_r

2007-12-21 Thread Bernhard Fischer
On Wed, Dec 19, 2007 at 11:57:28AM -0500, Daniel Jacobowitz wrote: MontaVista noticed that when their kernels were configured to trap Since i just today stumbled across a python-frontend imposed funnyness WRT entries in /etc/hosts that read like: 1.1.1.1 $(seq -w 1 | tr \n ) (or rather

Re: Alignment fixups for gethostbyname_r

2007-12-21 Thread Bernhard Fischer
On Fri, Dec 21, 2007 at 09:12:52PM +0100, Bernhard Fischer wrote: On Wed, Dec 19, 2007 at 11:57:28AM -0500, Daniel Jacobowitz wrote: MontaVista noticed that when their kernels were configured to trap on unaligned access gethostbyname_r could mysteriously crash. I tracked this down to an unaligned

Re: Alignment fixups for gethostbyname_r

2007-12-21 Thread Bernhard Fischer
On Wed, Dec 19, 2007 at 11:57:28AM -0500, Daniel Jacobowitz wrote: MontaVista noticed that when their kernels were configured to trap on unaligned access gethostbyname_r could mysteriously crash. I tracked this down to an unaligned buffer being passed to gethostbyname_r from some other part of

Re: Alignment fixups for gethostbyname_r

2007-12-21 Thread Daniel Jacobowitz
On Fri, Dec 21, 2007 at 09:12:52PM +0100, Bernhard Fischer wrote: This sounds OK to me. Please install it along a testcase if you tested it and found it to be good on all platforms in most common configurations with no regressions. I don't have write access. I tested ARM with no regressions,

Re: Alignment fixups for gethostbyname_r

2007-12-21 Thread Carmelo Amoroso
Daniel Jacobowitz wrote: MontaVista noticed that when their kernels were configured to trap on unaligned access gethostbyname_r could mysteriously crash. I tracked this down to an unaligned buffer being passed to gethostbyname_r from some other part of uClibc (afraid I don't remember where

Alignment fixups for gethostbyname_r

2007-12-19 Thread Daniel Jacobowitz
MontaVista noticed that when their kernels were configured to trap on unaligned access gethostbyname_r could mysteriously crash. I tracked this down to an unaligned buffer being passed to gethostbyname_r from some other part of uClibc (afraid I don't remember where from any more). We have to pad