Re: [PATCH] Fix dladdr return value when cannot find symbol

On Fri, Feb 08, 2008 at 10:24:40AM +0100, Carmelo AMOROSO wrote: Bernd Schmidt wrote: Carmelo AMOROSO wrote: based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. With the current implementation, the invocation of dladdr((void *) 1, dlinfo)

Re: [PATCH] Fix dladdr return value when cannot find symbol

Bernhard Fischer wrote: On Fri, Feb 08, 2008 at 10:24:40AM +0100, Carmelo AMOROSO wrote: Bernd Schmidt wrote: Carmelo AMOROSO wrote: based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. With the current implementation, the invocation of

Re: [PATCH] Fix dladdr return value when cannot find symbol

Carmelo AMOROSO wrote: based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. With the current implementation, the invocation of dladdr((void *) 1, dlinfo) will fill dlinfo.dli_fname with the name of the application itself and dlinfo.dli_fbase

Re: [PATCH] Fix dladdr return value when cannot find symbol

Carmelo AMOROSO wrote: based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. With the current implementation, the invocation of dladdr((void *) 1, dlinfo) will fill dlinfo.dli_fname with the name of the application itself and dlinfo.dli_fbase

Re: [PATCH] Fix dladdr return value when cannot find symbol

Bernd Schmidt wrote: Carmelo AMOROSO wrote: based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. With the current implementation, the invocation of dladdr((void *) 1, dlinfo) will fill dlinfo.dli_fname with the name of the application

Re: [PATCH] Fix dladdr return value when cannot find symbol

On Jan 18, 2008 2:48 AM, Joakim Tjernlund [EMAIL PROTECTED] wrote: On Fri, 2008-01-18 at 09:08 +0100, Carmelo AMOROSO wrote: Carmelo AMOROSO wrote: Carmelo AMOROSO wrote: Hello, based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function.

Re: [PATCH] Fix dladdr return value when cannot find symbol

Carmelo AMOROSO wrote: Hello, based on the patch from Nickolai, here you can find a comprehensive patch to fix dladdr function. Sorry, I missed a fix into dl-hash.c too. Find the missing change into the attached patch. Carmelo Index: ldso/ldso/dl-hash.c

Re: [PATCH] Fix dladdr return value when cannot find symbol

On Wednesday 12 December 2007, Carmelo AMOROSO wrote: while running more tests on this (indeed never used dladdr in the past), which tests ? our dl tests certainly dont have the coverage anywhere close to what i wish they did ... -mike signature.asc Description: This is a digitally signed

Re: [PATCH] Fix dladdr return value when cannot find symbol

Carmelo AMOROSO wrote: Nickolai Zeldovich wrote: On Dec 9, 2007 11:26 AM, Carmelo Amoroso [EMAIL PROTECTED] wrote: Attached patch tries to fix it. The GNU_HASH part needs to be fixed accordingly. Any comments ? I think that should work. Minor point:

Re: [PATCH] Fix dladdr return value when cannot find symbol

Nickolai Zeldovich wrote: On Dec 9, 2007 11:26 AM, Carmelo Amoroso [EMAIL PROTECTED] wrote: Attached patch tries to fix it. The GNU_HASH part needs to be fixed accordingly. Any comments ? I think that should work. Minor point: --- ldso/libdl/libdl.c (revision 20633) +++

Re: [PATCH] Fix dladdr return value when cannot find symbol

Nickolai Zeldovich wrote: The attached patch makes dladdr() return 0 when it cannot find a matching symbol. The current behavior of returning 1 makes it impossible for callers to know whether the supplied Dl_info buffer has been filled in with meaningful data. Nickolai. Hi Nickolai, I

Re: [PATCH] Fix dladdr return value when cannot find symbol

Nickolai Zeldovich wrote: The attached patch makes dladdr() return 0 when it cannot find a matching symbol. The current behavior of returning 1 makes it impossible for callers to know whether the supplied Dl_info buffer has been filled in with meaningful data. Nickolai. I'll have a