On Tue, May 25, 2010 at 12:20:47AM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 06:26:08PM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De Muyter p...@macqel.be wrote:
Hi Greg,
On Tue, May 25, 2010 at 11:19:43AM +1000, Greg Ungerer wrote:
Hi Philippe,
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
[...]
+#else
+#define TASK_SIZE (0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned
On Sunday 23 May 2010 21:29:50 Greg Ungerer wrote:
David Howells wrote:
Geert Uytterhoeven ge...@linux-m68k.org wrote:
Are these also problematic?
None of these are problematic for NOMMU FRV because there I set:
#define TASK_SIZE __UL(0xUL)
I
Philippe De Muyter wrote:
On Tue, May 25, 2010 at 12:20:47AM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 06:26:08PM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De
On Tuesday 25 May 2010 04:40:01 Philippe De Muyter wrote:
On Tue, May 25, 2010 at 11:19:43AM +1000, Greg Ungerer wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
[...]
+#else
+#define TASK_SIZE(0xUL)
+#endif
Because
Hi Philippe,
Philippe De Muyter wrote:
Hi Greg,
On Tue, May 25, 2010 at 11:19:43AM +1000, Greg Ungerer wrote:
Hi Philippe,
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
[...]
+#else
+#define TASK_SIZE (0xUL)
+#endif
Because of
Greg Ungerer g...@snapgear.com wrote:
+#define TASK_SIZE(0xUL)
You might want to use ULONG_MAX instead of coding the number directly.
David
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
[...]
+#else
+#define TASK_SIZE(0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned long) filename;
we should rather have
#define TASK_SIZE (0x1ull)
Philippe
--
Philippe De
Philippe De Muyter p...@macqel.be wrote:
+#else
+#define TASK_SIZE (0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned long) filename;
we should rather have
#define TASK_SIZE (0x1ull)
Do you guarantee that will work everywhere on a
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De Muyter p...@macqel.be wrote:
+#else
+#define TASK_SIZE(0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned long) filename;
we should rather have
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De Muyter p...@macqel.be wrote:
+#else
+#define TASK_SIZE (0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned long) filename;
we
On Mon, May 24, 2010 at 06:26:08PM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De Muyter p...@macqel.be wrote:
+#else
+#define TASK_SIZE(0xUL)
+#endif
Because of
Jamie Lokier ja...@shareable.org wrote:
TASK_SIZE is the wrong kind of check on no-MMU: A better check is that
the address is within the userspace mappable address range, whatever
that is, which may start at some value and end at some other value,
and may have holes.
I don't really think a
David Howells wrote:
Jamie Lokier ja...@shareable.org wrote:
TASK_SIZE is the wrong kind of check on no-MMU: A better check is that
the address is within the userspace mappable address range, whatever
that is, which may start at some value and end at some other value,
and may have
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 06:26:08PM +0100, Jamie Lokier wrote:
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 04:59:18PM +0100, David Howells wrote:
Philippe De Muyter p...@macqel.be wrote:
+#else
+#define TASK_SIZE (0xUL)
Hi Philippe,
Philippe De Muyter wrote:
On Mon, May 24, 2010 at 11:29:50AM +1000, Greg Ungerer wrote:
[...]
+#else
+#define TASK_SIZE (0xUL)
+#endif
Because of do_getname() :
len = TASK_SIZE - (unsigned long) filename;
we should rather have
#define TASK_SIZE
David Howells wrote:
Geert Uytterhoeven ge...@linux-m68k.org wrote:
Are these also problematic?
None of these are problematic for NOMMU FRV because there I set:
#define TASK_SIZE __UL(0xUL)
I would set it lower, but the flash is right at the top end of
Geert Uytterhoeven ge...@linux-m68k.org wrote:
Are these also problematic?
None of these are problematic for NOMMU FRV because there I set:
#define TASK_SIZE __UL(0xUL)
I would set it lower, but the flash is right at the top end of the address
space, and
Hi Greg,
--
Avoid filename TASK_SIZE test in do_getname() when no MMU.
Without MMU, filenames can be anywhere in memory. It is thus wrong to
check that filename is before TASK_SIZE in do_getname().
Signed-off-by: Philippe De Muyter p...@macqel.be
---
fs/namei.c |2 ++
1 files changed, 2
dont know if David subscribes to this list ...
On Thursday 20 May 2010 04:14:45 Philippe De Muyter wrote:
Hi Greg,
--
Avoid filename TASK_SIZE test in do_getname() when no MMU.
Without MMU, filenames can be anywhere in memory. It is thus wrong to
check that filename is before TASK_SIZE
20 matches
Mail list logo
