Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Sam Ravnborg
Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ +defined(__mc68040__) || defined(__mc68060__) Why use these to decide if this is MMU or not? This code is not exposed to user-space so we can rely on CONFIG_* symbols. IMO the CONIFG_* symbols is easier to read/maintain.

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Geert Uytterhoeven
On Wed, Apr 20, 2011 at 10:06, Sam Ravnborg s...@ravnborg.org wrote: Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ +    defined(__mc68040__) || defined(__mc68060__) Why use these to decide if this is MMU or not? This code is not exposed to user-space so we can rely on

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Philippe De Muyter
On Wed, Apr 20, 2011 at 10:06:09AM +0200, Sam Ravnborg wrote: Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ +defined(__mc68040__) || defined(__mc68060__) Why use these to decide if this is MMU or not? This code is not exposed to user-space so we can rely on

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Greg Ungerer
Hi Sam, On 20/04/11 18:06, Sam Ravnborg wrote: Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ +defined(__mc68040__) || defined(__mc68060__) Why use these to decide if this is MMU or not? The asm code that is enclosed by this is not about having an MMU or not. It is

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Philippe De Muyter
On Wed, Apr 20, 2011 at 10:55:15AM +0200, Geert Uytterhoeven wrote: On Wed, Apr 20, 2011 at 10:06, Sam Ravnborg s...@ravnborg.org wrote: Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ +    defined(__mc68040__) || defined(__mc68060__) Why use these to decide if

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Greg Ungerer
On 20/04/11 19:12, Philippe De Muyter wrote: On Wed, Apr 20, 2011 at 10:55:15AM +0200, Geert Uytterhoeven wrote: On Wed, Apr 20, 2011 at 10:06, Sam Ravnborgs...@ravnborg.org wrote: Hi Greg. + +#if defined(__mc68020__) || defined(__mc68030__) || \ + á ádefined(__mc68040__) ||

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Philippe De Muyter
On Wed, Apr 20, 2011 at 07:31:33PM +1000, Greg Ungerer wrote: On 20/04/11 19:12, Philippe De Muyter wrote: On Wed, Apr 20, 2011 at 10:55:15AM +0200, Geert Uytterhoeven wrote: On Wed, Apr 20, 2011 at 10:06, Sam Ravnborgs...@ravnborg.org wrote: Hi Greg. + +#if defined(__mc68020__) ||

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Greg Ungerer
Hi Philippe, On 20/04/11 20:38, Philippe De Muyter wrote: Hi Greg, On Wed, Apr 20, 2011 at 08:18:09PM +1000, Greg Ungerer wrote: The 68340 has it also. (And I have an old linux port for this processor) That is just a SoC that contains a 68020 though, so __mc68020__ would be defined for

Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-20 Thread Philippe De Muyter
Hi Greg, On Wed, Apr 20, 2011 at 09:01:39PM +1000, Greg Ungerer wrote: Hi Philippe, On 20/04/11 20:38, Philippe De Muyter wrote: Hi Greg, On Wed, Apr 20, 2011 at 08:18:09PM +1000, Greg Ungerer wrote: The 68340 has it also. (And I have an old linux port for this processor) That is just a

[uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

2011-04-19 Thread gerg
From: Greg Ungerer g...@uclinux.org The implementation of gcc's muldi3 support function differs only in the use of the machine's 64 bit sized mul or not. (It isn't based on using an MMU or not). Merge the current mmu and non-mmu versions of arc/m68k/lib/muldi3 and use the appropriate