Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-25 Thread Junio C Hamano
"John Stoffel" writes: >> git commit -a > > # Put in a simple message of a line or two. > > ratelimit parity error reporting, which helps alot on bootup over serial > console when you get 10,000+ lines of this message. Doesn't this violate the accepted standard format for commit messages

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread Linus Torvalds
On Mon, 22 Jun 2009, John Stoffel wrote: > > Linus> Then, just edit the files, and use "git diff". That, along with > Linus> "git pull" would be the _only_ command you'd ever use - and you > Linus> now have a nice anoncvs-like environment to get used to git > Linus> with, without having to actua

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread John Stoffel
Linus> On Mon, 22 Jun 2009, John Stoffel wrote: >> >> I just recently submitted a patch, and it took me a while to figure >> out a git flow for stupid, simple patches so that I, a moron, could >> understand it. Linus> Well, your documented flow is pretty advanced, actually. In Linus> fact, much

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread John Stoffel
> "Linus" == Linus Torvalds writes: Linus> On Mon, 22 Jun 2009, Bernd Schmidt wrote: >> >> This fixes a crash in 2.6.30 with shared flat binaries. prepare_binfmt now >> requires a cred pointer to be set up, which isn't done in binfmt_flat.c. Linus> This has so many bugs in patch submission

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread Linus Torvalds
On Mon, 22 Jun 2009, John Stoffel wrote: > > I just recently submitted a patch, and it took me a while to figure > out a git flow for stupid, simple patches so that I, a moron, could > understand it. Well, your documented flow is pretty advanced, actually. In fact, much more advanced than what

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread Linus Torvalds
On Mon, 22 Jun 2009, Linus Torvalds wrote: > > I applied this patch, but I want to just vent my frustration with it. Actually, I take that back. I applied it by hand, but then unapplied it, because the patch also had res = load_flat_file(&bprm, libs, id, NULL, NULL); when my

Re: [Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread Linus Torvalds
On Mon, 22 Jun 2009, Bernd Schmidt wrote: > > This fixes a crash in 2.6.30 with shared flat binaries. prepare_binfmt now > requires a cred pointer to be set up, which isn't done in binfmt_flat.c. This has so many bugs in patch submission that I literally almost gave up despite it being a trivi

[Uclinux-dist-devel] Fix for shared flat binary format in 2.6.30

2009-06-22 Thread Bernd Schmidt
This fixes a crash in 2.6.30 with shared flat binaries. prepare_binfmt now requires a cred pointer to be set up, which isn't done in binfmt_flat.c. Signed-off-by: Bernd Schmidt Acked-by: David Howells -- This footer brought to you by insane German lawmakers. Analog Devices GmbH Wilhelm-W