Re: [umit-devel] Communication interface between different units in ICM

2011-05-30 Thread Diogo Pinheiro
message WebsiteReportDetail { required string websiteURL = 2; required int32 statusCode = 3; optional double responseTime = 7; optional double bandwidth = 8; } Why the responseTime is a double ? Shouldn't be an integer ? I think we will not need anything more precise than miliseconds. And abou

Re: [umit-devel] Communication interface between different units in ICM

2011-05-30 Thread Zubair Nabi
You're correct about the ICMReport message. It's perfectly fine. And +1 for the hostname and IP fields. 2011/5/30 Adriano Monteiro Marques > Hi Zubair, > > On May 30, 2011, at 11:04 AM, Zubair Nabi wrote: > > Guys, > > 2 things: > > 1. ICMReport message is not being used anywhere. Because we h

Re: [umit-devel] Communication interface between different units in ICM

2011-05-30 Thread Adriano Monteiro Marques
Hi Zubair, On May 30, 2011, at 11:04 AM, Zubair Nabi wrote: > Guys, > > 2 things: > > 1. ICMReport message is not being used anywhere. Because we have two separate > SendWebsiteReport and SendServiceReport messages. > Any thoughts on this this? ICMReport is the header for WebsiteReport and Se

Re: [umit-devel] Communication interface between different units in ICM

2011-05-30 Thread Zubair Nabi
Guys, 2 things: 1. ICMReport message is not being used anywhere. Because we have two separate SendWebsiteReport and SendServiceReport messages. Any thoughts on this this? 2. Secondly, I'm going to add two messages for Website and Service Suggestion message WebsiteSuggestion { required RequestHea