Re: env reuse and hijack

2017-12-04 Thread Eric Wong
Eric Wong wrote: > Totally untested; but maybe the patch below works for you > by replacing the buf and env objects in the hijacked cases. > > Can you try it and report back? Thanks. Btw, did you get a chance to look at my patch? (I haven't :x) -- unsubscribe:

env reuse and hijack

2017-11-28 Thread Sam Saffron
I was reading through unicorn today and noticed that it uses `HttpParser_clear` to clear up env between requests as opposed to allocating a new `env` object. This is generally fine, but if you hijack a request you may want to still look at env after this is done leading to situations where you