Re: [UrJTAG-dev] p1020.c

2020-09-21 Thread Geert Stappers
On Mon, Sep 21, 2020 at 06:57:10PM +1000, Damien Mascord wrote:
> Hi guys,
> 
> To make it clearer, please see attached two commits, one for the necessary
> generic updates to allow for the BSDL to be parsed, and another to add the
> draft p1020 device support.
> 
> Please note that bus support is very draft as explained previously.
> 
> Cheers,
> 
> Damien
> 

> commit a3e6200bc6673601febc11afc08e50d94e3e4fbd
> Author: Damien Mascord 
> Date:   Mon Sep 21 18:50:21 2020 +1000
> 
> Add draft support for Freescale QorIQ P1020
>  - Adds PART detection for CPU
>  - Adds initbus support for p1020
> 
> diff --git a/urjtag/configure.ac b/urjtag/configure.ac
> index 95d1d743..e1a5ae8a 100644
> --- a/urjtag/configure.ac
> +++ b/urjtag/configure.ac
> @@ -637,6 +637,7 @@ URJ_DRIVER_SET([bus], [
>   mpc824x
>   mpc8313
>   mpc837x
> + p1020
>   ppc405ep
>   ppc440gx_ebc8
>   prototype
> diff --git a/urjtag/data/Makefile.am b/urjtag/data/Makefile.am
> index 7fb82f0f..62e916d7 100644
> --- a/urjtag/data/Makefile.am
> +++ b/urjtag/data/Makefile.am
> @@ -126,6 +126,8 @@ nobase_dist_pkgdata_DATA = \
>   freescale/mpc8378/mpc8378 \
>   freescale/mpc8379/STEPPINGS \
>   freescale/mpc8379/mpc8379 \
> + freescale/p1020/STEPPINGS \
> + freescale/p1020/p1020 \
>   ibm/PARTS \
>   ibm/ppc440gx/STEPPINGS \
>   ibm/ppc440gx/ppc440gx \
> diff --git a/urjtag/data/freescale/PARTS b/urjtag/data/freescale/PARTS
> index 2f5adc77..eeb7f690 100644
> --- a/urjtag/data/freescale/PARTS
> +++ b/urjtag/data/freescale/PARTS
> @@ -27,5 +27,6 @@
>  0001100011100100 mpc8378 mpc8378e
>  0001100011100011 mpc8379 mpc8379
>  0001100011100010 mpc8379 mpc8379e
> +0110100011100010 p1020   p1020
>  
>  
> diff --git a/urjtag/data/freescale/p1020/STEPPINGS 
> b/urjtag/data/freescale/p1020/STEPPINGS
> new file mode 100644
> index ..3d84fc65
> --- /dev/null
> +++ b/urjtag/data/freescale/p1020/STEPPINGS
> @@ -0,0 +1,24 @@
> +#
> +# $Id: STEPPINGS
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License
> +# as published by the Free Software Foundation; either version 2
> +# of the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
> +# 02111-1307, USA.
> +#
> +# Documentation:
> +# [1] Freescale, "Freescale MPC837x Users Guide"

???


> +#
> +
> +# bits 31-28 of the Device Identification Register
> + p1020   0
> diff --git a/urjtag/data/freescale/p1020/p1020 
> b/urjtag/data/freescale/p1020/p1020
> new file mode 100644
> index ..9d893d86
> --- /dev/null
> +++ b/urjtag/data/freescale/p1020/p1020
> @@ -0,0 +1,1232 @@

 ...

> diff --git a/urjtag/src/bus/Makefile.am b/urjtag/src/bus/Makefile.am
> index 3a082439..3fc9c265 100644
> --- a/urjtag/src/bus/Makefile.am
> +++ b/urjtag/src/bus/Makefile.am
> @@ -122,6 +122,10 @@ if ENABLE_BUS_MPC837X
>  libbus_la_SOURCES += mpc837x.c
>  endif
>  
> +if ENABLE_BUS_P1020
> +libbus_la_SOURCES += p1020.c
> +endif
> +
>  if ENABLE_BUS_PPC405EP
>  libbus_la_SOURCES += ppc405ep.c
>  endif
> diff --git a/urjtag/src/bus/buses_list.h b/urjtag/src/bus/buses_list.h
> index cc91..87728ef9 100644
> --- a/urjtag/src/bus/buses_list.h
> +++ b/urjtag/src/bus/buses_list.h
> @@ -98,6 +98,9 @@ _URJ_BUS(mpc8313)
>  #ifdef ENABLE_BUS_MPC837X
>  _URJ_BUS(mpc837x)
>  #endif
> +#ifdef ENABLE_BUS_P1020
> +_URJ_BUS(p1020)
> +#endif
>  #ifdef ENABLE_BUS_PPC405EP
>  _URJ_BUS(ppc405ep)
>  #endif
> diff --git a/urjtag/src/bus/p1020.c b/urjtag/src/bus/p1020.c
> new file mode 100644
> index ..fcf4564d
> --- /dev/null
> +++ b/urjtag/src/bus/p1020.c
> @@ -0,0 +1,515 @@
> +/*
> + * Freescale P1020 compatible bus driver via BSR
> + * Copyright (C) 2010 Andrzej Jalowiecki, Damien Mascord

Seen that before, provided feedback.
Stopping with reviewing.
Rejecting the patch.


Regards
Geert Stappers

P.S.
I'm aware that other patch was in the same email.


___
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development


Re: [UrJTAG-dev] p1020.c

2020-09-21 Thread Damien Mascord

Hi guys,

To make it clearer, please see attached two commits, one for the 
necessary generic updates to allow for the BSDL to be parsed, and 
another to add the draft p1020 device support.


Please note that bus support is very draft as explained previously.

Cheers,

Damien

commit a3e6200bc6673601febc11afc08e50d94e3e4fbd
Author: Damien Mascord 
Date:   Mon Sep 21 18:50:21 2020 +1000

Add draft support for Freescale QorIQ P1020
 - Adds PART detection for CPU
 - Adds initbus support for p1020

diff --git a/urjtag/configure.ac b/urjtag/configure.ac
index 95d1d743..e1a5ae8a 100644
--- a/urjtag/configure.ac
+++ b/urjtag/configure.ac
@@ -637,6 +637,7 @@ URJ_DRIVER_SET([bus], [
 	mpc824x
 	mpc8313
 	mpc837x
+	p1020
 	ppc405ep
 	ppc440gx_ebc8
 	prototype
diff --git a/urjtag/data/Makefile.am b/urjtag/data/Makefile.am
index 7fb82f0f..62e916d7 100644
--- a/urjtag/data/Makefile.am
+++ b/urjtag/data/Makefile.am
@@ -126,6 +126,8 @@ nobase_dist_pkgdata_DATA = \
 	freescale/mpc8378/mpc8378 \
 	freescale/mpc8379/STEPPINGS \
 	freescale/mpc8379/mpc8379 \
+	freescale/p1020/STEPPINGS \
+	freescale/p1020/p1020 \
 	ibm/PARTS \
 	ibm/ppc440gx/STEPPINGS \
 	ibm/ppc440gx/ppc440gx \
diff --git a/urjtag/data/freescale/PARTS b/urjtag/data/freescale/PARTS
index 2f5adc77..eeb7f690 100644
--- a/urjtag/data/freescale/PARTS
+++ b/urjtag/data/freescale/PARTS
@@ -27,5 +27,6 @@
 0001100011100100 mpc8378	mpc8378e
 0001100011100011 mpc8379	mpc8379
 0001100011100010 mpc8379	mpc8379e
+0110100011100010 p1020		p1020
 
 
diff --git a/urjtag/data/freescale/p1020/STEPPINGS b/urjtag/data/freescale/p1020/STEPPINGS
new file mode 100644
index ..3d84fc65
--- /dev/null
+++ b/urjtag/data/freescale/p1020/STEPPINGS
@@ -0,0 +1,24 @@
+#
+# $Id: STEPPINGS
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
+# 02111-1307, USA.
+#
+# Documentation:
+# [1] Freescale, "Freescale MPC837x Users Guide"
+#
+
+# bits 31-28 of the Device Identification Register
+	p1020		0
diff --git a/urjtag/data/freescale/p1020/p1020 b/urjtag/data/freescale/p1020/p1020
new file mode 100644
index ..9d893d86
--- /dev/null
+++ b/urjtag/data/freescale/p1020/p1020
@@ -0,0 +1,1232 @@
+signal XVSS(0)
+signal XVSS(1)
+signal XVSS(2)
+signal XVSS(3)
+signal XVSS(4)
+signal XVSS(5)
+signal XVSS(6)
+signal XVSS(7)
+signal XVDD(0)
+signal XVDD(1)
+signal XVDD(2)
+signal XVDD(3)
+signal XVDD(4)
+signal XVDD(5)
+signal VSS(0)
+signal VSS(1)
+signal VSS(2)
+signal VSS(3)
+signal VSS(4)
+signal VSS(5)
+signal VSS(6)
+signal VSS(7)
+signal VSS(8)
+signal VSS(9)
+signal VSS(10)
+signal VSS(11)
+signal VSS(12)
+signal VSS(13)
+signal VSS(14)
+signal VSS(15)
+signal VSS(16)
+signal VSS(17)
+signal VSS(18)
+signal VSS(19)
+signal VSS(20)
+signal VSS(21)
+signal VSS(22)
+signal VSS(23)
+signal VSS(24)
+signal VSS(25)
+signal VSS(26)
+signal VSS(27)
+signal VSS(28)
+signal VSS(29)
+signal VSS(30)
+signal VSS(31)
+signal VSS(32)
+signal VSS(33)
+signal VSS(34)
+signal VSS(35)
+signal VSS(36)
+signal VSS(37)
+signal VSS(38)
+signal VSS(39)
+signal VSS(40)
+signal VSS(41)
+signal VSS(42)
+signal VSS(43)
+signal VSS(44)
+signal VSS(45)
+signal VSS(46)
+signal VSS(47)
+signal VSS(48)
+signal VSS(49)
+signal VSS(50)
+signal VSS(51)
+signal VSS(52)
+signal VSS(53)
+signal VSS(54)
+signal VSS(55)
+signal VSS(56)
+signal VSS(57)
+signal VSS(58)
+signal VSS(59)
+signal VSS(60)
+signal VSS(61)
+signal VSS(62)
+signal VSS(63)
+signal VSS(64)
+signal VSS(65)
+signal VSS(66)
+signal VSS(67)
+signal VSS(68)
+signal VSS(69)
+signal VSS(70)
+signal VSS(71)
+signal VSS(72)
+signal VSS(73)
+signal VSS(74)
+signal VSS(75)
+signal VSS(76)
+signal VSS(77)
+signal VSS(78)
+signal VSS(79)
+signal VSS(80)
+signal VSS(81)
+signal VSS(82)
+signal VSS(83)
+signal VSS(84)
+signal VSS(85)
+signal VSS(86)
+signal VSS(87)
+signal VSS(88)
+signal VSS(89)
+signal VSS(90)
+signal VSS(91)
+signal VSS(92)
+signal VSS(93)
+signal VSS(94)
+signal VSS(95)
+signal VSS(96)
+signal VSS(97)
+signal VSS(98)
+signal VSS(99)
+signal VSS(100)
+signal VSS(101)
+signal VSS(102)
+signal VSS(103)
+signal VSS(104)
+signal VSS(105)
+signal VSS(106)
+signal VSS(107)
+signal VSS(108)
+signal VSS(109)
+signal VSS(110)
+signal VSS(111)
+signal VSS(112)
+signal VSS(113)
+signal VSS(114)
+signal VSS(115)
+signal VSS(116)
+signal VSS(117)
+signal VSS(118)
+signal VSS(119)
+signal VSS(120)
+signal 

Re: [UrJTAG-dev] p1020.c

2020-09-21 Thread Damien Mascord

On 21/09/2020 18:18, Geert Stappers wrote:

Please express it all in a git commit.


Hi Geert,

Please see attached.

Cheers,

Damien

diff --git a/urjtag/configure.ac b/urjtag/configure.ac
index 95d1d743..e1a5ae8a 100644
--- a/urjtag/configure.ac
+++ b/urjtag/configure.ac
@@ -637,6 +637,7 @@ URJ_DRIVER_SET([bus], [
 	mpc824x
 	mpc8313
 	mpc837x
+	p1020
 	ppc405ep
 	ppc440gx_ebc8
 	prototype
diff --git a/urjtag/data/Makefile.am b/urjtag/data/Makefile.am
index 7fb82f0f..62e916d7 100644
--- a/urjtag/data/Makefile.am
+++ b/urjtag/data/Makefile.am
@@ -126,6 +126,8 @@ nobase_dist_pkgdata_DATA = \
 	freescale/mpc8378/mpc8378 \
 	freescale/mpc8379/STEPPINGS \
 	freescale/mpc8379/mpc8379 \
+	freescale/p1020/STEPPINGS \
+	freescale/p1020/p1020 \
 	ibm/PARTS \
 	ibm/ppc440gx/STEPPINGS \
 	ibm/ppc440gx/ppc440gx \
diff --git a/urjtag/data/bsdl/STD_1149_1_2001 b/urjtag/data/bsdl/STD_1149_1_2001
index a0e1c3e0..21a82f18 100644
--- a/urjtag/data/bsdl/STD_1149_1_2001
+++ b/urjtag/data/bsdl/STD_1149_1_2001
@@ -1,259 +1,173 @@
---
--- $Id$
---
--- Email header accompanying the original Yacc code:
---   http://www.eda.org/vug_bbs/bsdl.parser
--- 
--- ---8<--
--- 
--- Hello All,
--- 
--- This is this first mailing of the BSDL* Version 0.0 parser specifications
--- we are sending to people who request it from our publicized E-Mail address;
--- 
---  bsdl%hpm...@hplabs.hp.com
--- 
--- You are free to redistribute this at will, but we feel that it would be
--- better if respondents asked for it directly so that their addresses can
--- be entered into our list for future mailings and updates.
--- 
--- It would be helpful if you could confirm receipt of this transmission.
--- We also would be very interested to hear about your experiences with this
--- information and what you are planning to do with BSDL.
--- 
--- Regards,
--- 
--- Ken Parker
--- Hewlett-Packard Company
--- 
--- 
--- *Boundary-Scan Description Language - as documented in:
--- 
--- "A Language for Describing Boundary-Scan Devices", K.P. Parker
--- and S. Oresjo, Proceedings 1990 International Test Conference,
--- Washington DC, pp 222-234
--- 
--- 
--- - -cut here---
--- 
--- 
--- 901004.0721  Hewlett-Packard Company
--- 901016.1049  Manufacturing Test Division
---  P.O. Box 301
---  Loveland, Colorado  80537
---  USA
--- 
---  October 1990
--- Hello BSDL Parser Requestor,
--- 
---This Electronic Mail reply contains the computer specifications for
--- Hewlett-Packard's Version 0.0 BSDL parser.  This section of the reply
--- explains the contents of the rest of this file.
--- 
--- This file is composed of seven (7) parts:
--- 
---1) How to use this file
--- 
---2) UNIX* Lex source  (lexicographical tokenizing rules)
--- 
---3) UNIX* Yacc source (BNF-like syntax description)
--- 
---4) A sample main program to recognize BSDL.
--- 
---5) A BSDL description of the Texas Instruments 74bct8374 that is
---   recognized by the parser, for testing purposes.
--- 
---6) The VHDL package STD_1149_1_1990 needed by this parser.
--- 
---7) [added 901016] Porting experiences to other systems.
--- 
--- 
--- RECOMMENDATION: Save a copy of this file in archival storage before
--- processing it via the instructions below.  This will
--- allow you to recover from errors, and allow you to
--- compare subsequently released data for changes.
--- 
--- DISCLAIMERS:
--- 
--- 1.  The IEEE 1149.1 Working Group has not endorsed BSDL Version 0.0 and
--- therefore no person may represent it as an IEEE standard or imply that
--- a resulting IEEE standard will be identical to it.
--- 
--- 2.  The IEEE 1149.1 Working Group recognizes that BSDL Version 0.0 is a
--- well-conceived initiative that is likely to excelerate the creation
--- of tools that support the 1149.1 standard.  As such, changes and
--- enhancements will be carefully considered so as not to needlessly
--- disrupt these development efforts.  The overriding goal is the
--- ultimate success of the 1149.1 standard.
--- 
--- LEGAL NOTICES:
--- 
--- Hewlett-Packard Company makes no warranty of any kind with regard to
--- this information, including, but not limited to, the implied
--- waranties of merchantability and fitness for a particular purpose.
--- 
--- Hewlett-Packard Company shall not be liable for errors contained
--- herein or direct, indirect, special, incidental, or consequential
--- damages in connection with the furnishing, performance, or use of
--- this material.
--- 
--- 
--- *UNIX is a 

Re: [UrJTAG-dev] p1020.c

2020-09-21 Thread Geert Stappers
On Mon, Sep 21, 2020 at 06:07:29PM +1000, Damien Mascord wrote:
> On 21/09/2020 18:04, Geert Stappers wrote:
> 
> > On Mon, Sep 21, 2020 at 05:50:10PM +1000, Damien Mascord wrote:
> > > On 21/09/2020 17:17, Geert Stappers wrote:
> > > > Where is the p1020.c  ?
> > > Apologies for not including the p1020.c in the diff, I must've missed it
> > > with the git add.   Please see attached.
> > 
> > The attachment:
> > > /*
> > >   * Freescale P1020 compatible bus driver via BSR
> > >   * Copyright (C) 2010 Andrzej Jalowiecki, Damien Mascord
> >  ???
> > 
> > What was create ten years ago?   What was created in 2020?
> I took the mpc837x.c as an example, and modified it based on debugging the
> p1020.
> > 
> > 
> > >   *
> > >   * This program is free software; you can redistribute it and/or
> > >   * modify it under the terms of the GNU General Public License
> > >   * as published by the Free Software Foundation; either version 2
> > >   * of the License, or (at your option) any later version.
> > >   *
> > > 
> > 
> > At which location should p1020.c be?
> in urjtag/src/bus


Please express it all in a git commit.


Groeten
Geert Stappers
-- 
Silence is hard to parse


___
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development


Re: [UrJTAG-dev] p1020.c Was: Adding support for Freescale QorIQ P1020 (help needed)

2020-09-21 Thread Damien Mascord

On 21/09/2020 18:04, Geert Stappers wrote:


On Mon, Sep 21, 2020 at 05:50:10PM +1000, Damien Mascord wrote:

On 21/09/2020 17:17, Geert Stappers wrote:

Where is the p1020.c  ?

Apologies for not including the p1020.c in the diff, I must've missed it
with the git add.   Please see attached.


The attachment:

/*
  * Freescale P1020 compatible bus driver via BSR
  * Copyright (C) 2010 Andrzej Jalowiecki, Damien Mascord

 ???

What was create ten years ago?   What was created in 2020?
I took the mpc837x.c as an example, and modified it based on debugging 
the p1020.




  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
  * as published by the Free Software Foundation; either version 2
  * of the License, or (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
  * 02111-1307, USA.
  *
  *
  * Documentation:
  * [1] Freescale, "Freescale P1020 Reference Manual"
  *
  */



At which location should p1020.c be?

in urjtag/src/bus



___
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development



___
UrJTAG-development mailing list
UrJTAG-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/urjtag-development