Re: Unexpected aliasing from RFile getTopValue()

2015-04-15 Thread Keith Turner
On Tue, Apr 14, 2015 at 9:43 PM, Christopher ctubb...@apache.org wrote: Well, it depends on the behavior of the iterator beneath it. Most iterators would probably not want to copy, for performance reasons, but an iterator could choose to break that convention (or may need to). It is kind of

Re: Unexpected aliasing from RFile getTopValue()

2015-04-15 Thread Keith Turner
On Wed, Apr 15, 2015 at 11:06 AM, Adam Fuchs afu...@apache.org wrote: On Wed, Apr 15, 2015 at 10:20 AM, Keith Turner ke...@deenlo.com wrote: Random thought on revamp. Immutable key values with enough primitives to make most operations efficient (avoid constant alloc/copy) might be

Re: Unexpected aliasing from RFile getTopValue()

2015-04-15 Thread Adam Fuchs
On Wed, Apr 15, 2015 at 10:20 AM, Keith Turner ke...@deenlo.com wrote: Random thought on revamp. Immutable key values with enough primitives to make most operations efficient (avoid constant alloc/copy) might be something to consider for the iterator API So, is this a tradeoff in the

Re: Unexpected aliasing from RFile getTopValue()

2015-04-15 Thread Josh Elser
Keith Turner wrote: On Wed, Apr 15, 2015 at 11:06 AM, Adam Fuchs afu...@apache.org mailto:afu...@apache.org wrote: On Wed, Apr 15, 2015 at 10:20 AM, Keith Turner ke...@deenlo.com mailto:ke...@deenlo.com wrote: Random thought on revamp. Immutable key values with enough