Re: reverting logback dependency update

2017-11-20 Thread Mohit Jaggi
thanks :) On Mon, Nov 20, 2017 at 7:18 PM, Bill Farner wrote: > Aha. Yes, i suspect you will be fine to revert these locally. > > On Mon, Nov 20, 2017 at 7:11 PM, Mohit Jaggi wrote: > >> I should have been clear. I meant if I change it in my fork,

Re: reverting logback dependency update

2017-11-20 Thread Bill Farner
Aha. Yes, i suspect you will be fine to revert these locally. On Mon, Nov 20, 2017 at 7:11 PM, Mohit Jaggi wrote: > I should have been clear. I meant if I change it in my fork, should I > expect it to work? Or is there a change later in 0.18.1 that relies on the > version

Re: reverting logback dependency update

2017-11-20 Thread Mohit Jaggi
I should have been clear. I meant if I change it in my fork, should I expect it to work? Or is there a change later in 0.18.1 that relies on the version being new? Sent from my iPhone > On Nov 20, 2017, at 6:42 PM, Bill Farner wrote: > > I don't think it is fair to the

Re: reverting logback dependency update

2017-11-20 Thread Bill Farner
I don't think it is fair to the community or practical to hold back library versions because of conflicts in proprietary custom builds of Aurora. So in general, i am -1 on the precedent this would set. On Mon, Nov 20, 2017 at 5:53 PM, Mohit Jaggi wrote: > Folks, > Due to

reverting logback dependency update

2017-11-20 Thread Mohit Jaggi
Folks, Due to a conflict with another tool we use, I can't use logback 1.2.3 and slf4j 1.7.25 yet. Is it safe to change them to the previous values? Ref: https://github.com/apache/aurora/commit/d7425aa56d3fba98f4a16cb93bff8f9ce7ce0e67 Mohit.