Re: Should a Schema be serializable in Java?

Thanks again Ryan, I've merged to master and the 1.9 branch, so it should be in Avro 1.9.1. Cheers, Fokko Driesprong Op do 18 jul. 2019 om 15:18 schreef Zoltan Farkas : > LGTM > > On Jul 18, 2019, at 8:24 AM, Driesprong, Fokko > wrote: > > Thank you Ryan, I have a few comments on Github. Look

Re: Should a Schema be serializable in Java?

LGTM > On Jul 18, 2019, at 8:24 AM, Driesprong, Fokko wrote: > > Thank you Ryan, I have a few comments on Github. Looks good to me. > > Cheers, Fokko > > Op do 18 jul. 2019 om 11:58 schreef Ryan Skraba >: > Hello! I'm motivated to see this happen :D > > +Zoltan, the

Re: Should a Schema be serializable in Java?

Thank you Ryan, I have a few comments on Github. Looks good to me. Cheers, Fokko Op do 18 jul. 2019 om 11:58 schreef Ryan Skraba : > Hello! I'm motivated to see this happen :D > > +Zoltan, the original author. I created a PR against apache/avro master > here: https://github.com/apache/avro/pul

Re: Should a Schema be serializable in Java?

Hello! I'm motivated to see this happen :D +Zoltan, the original author. I created a PR against apache/avro master here: https://github.com/apache/avro/pull/589 I cherry-picked the commit from your fork, and reapplied spotless/checkstyle. I hope this is the correct way to preserve authorship a

Re: Should a Schema be serializable in Java?

Yes probably it is overkill to warn given the examples you mention. Also your argument towards reusing the mature (and battle tested) combination of Schema.Parser + String serialization makes sense. Adding this to 1.9.1 will be an extra selling point for projects wanting to migrate to the latest v

Re: Should a Schema be serializable in Java?

Hello! Thanks to the reference to AVRO-1852. It's exactly what I was looking for. I agree that Java serialization shouldn't be used for anything cross-platform, or (in my opinion) used for any *data* persistence at all. Especially not for an Avro container file or sending binary data through a me

Re: Should a Schema be serializable in Java?

This is a good idea even if it may have some issues that we should probably document and warn users about: 1. Java based serialization is really practical for JVM based systems, but we should probably add a warning or documentation because Java serialization is not deterministic between JVMs so th

Re: Should a Schema be serializable in Java?

Correct me if I'm wrong here. But as far as I understood the way of serializing the schema is using Avro, as it is part of the file. To avoid confusion there should be one way of serializing. However, I'm not sure if this is worth the hassle of not simply implementing serializable. Also Flink ther

Re: Should a Schema be serializable in Java?

I can't think of a reason Schema should not implement Serializable. There's actually already an issue & patch for this: https://issues.apache.org/jira/browse/AVRO-1852 Doug On Mon, Jul 15, 2019 at 6:49 AM Ismaël Mejía wrote: > +d...@avro.apache.org > > On Mon, Jul 15, 2019 at 3:30 PM Ryan Skr

Re: Should a Schema be serializable in Java?

+d...@avro.apache.org On Mon, Jul 15, 2019 at 3:30 PM Ryan Skraba wrote: > > Hello! > > I'm looking for any discussion or reference why the Schema object isn't > serializable -- I'm pretty sure this must have already been discussed (but > the keywords +avro +serializable +schema have MANY resul

Should a Schema be serializable in Java?

Hello! I'm looking for any discussion or reference why the Schema object isn't serializable -- I'm pretty sure this must have already been discussed (but the keywords +avro +serializable +schema have MANY results in all the searches I did: JIRA, stack overflow, mailing list, web) In particular, I