Re: Upgrading from 2.15 to 2.19 makes compilation fail on trigger

2020-05-05 Thread Kyle Weaver
> Maybe we should add a statement like "did you mean to wrap it in Repeatedly.forever?" to the error message +1. IMO the less indirection between the user and the fix, the better. On Tue, May 5, 2020 at 12:08 PM Luke Cwik wrote: > Pointing users to the website with additional details in the

Re: Upgrading from 2.15 to 2.19 makes compilation fail on trigger

2020-05-05 Thread Luke Cwik
Pointing users to the website with additional details in the error messages would likely help as well. On Tue, May 5, 2020 at 8:45 AM Brian Hulette wrote: > In both SDKs this is an unsafe trigger because it will only fire once for > the first window (per key), and any subsequent data on the

Re: Upgrading from 2.15 to 2.19 makes compilation fail on trigger

2020-05-05 Thread Brian Hulette
In both SDKs this is an unsafe trigger because it will only fire once for the first window (per key), and any subsequent data on the same key will be dropped. In 2.18, we closed BEAM-3288 with PR https://github.com/apache/beam/pull/9960, which detects these cases and fails early. Probably the fix

Re: Flink Runner with RequiresStableInput fails after a certain number of checkpoints

2020-05-05 Thread Eleanore Jin
Hi Max, Thanks for the info! Eleanore On Tue, May 5, 2020 at 4:01 AM Maximilian Michels wrote: > Hey Eleanore, > > The change will be part of the 2.21.0 release. > > -Max > > On 04.05.20 19:14, Eleanore Jin wrote: > > Hi Max, > > > > Thanks for the information and I saw this PR is already

Upgrading from 2.15 to 2.19 makes compilation fail on trigger

2020-05-05 Thread Eddy G
Hey all! Recently been updating Beam pipelines up to 2.19, and the following trigger which previously worked with 2.15 flawlessly has stopped doing so and the project doesn't even compile now. .apply("15min Window", Window.into(FixedWindows.of(Duration.standardMinutes(15)))

Re: Flink Runner with RequiresStableInput fails after a certain number of checkpoints

2020-05-05 Thread Maximilian Michels
Hey Eleanore, The change will be part of the 2.21.0 release. -Max On 04.05.20 19:14, Eleanore Jin wrote: > Hi Max,  > > Thanks for the information and I saw this PR is already merged, just > wonder is it backported to the affected versions already > (i.e. 2.14.0, 2.15.0, 2.16.0, 2.17.0,