Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-04-03 Thread Sijie Guo
On Mon, Apr 3, 2017 at 7:33 AM, Enrico Olivelli wrote: > 2017-03-31 19:10 GMT+02:00 Matteo Merli : > > > In this commit from the Yahoo branch we did a similar thing > > https://github.com/yahoo/bookkeeper/commit/ > 92e2f906f83d997b5cf5ffd2bcfcdb > >

Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-04-03 Thread Enrico Olivelli
2017-03-31 19:10 GMT+02:00 Matteo Merli : > In this commit from the Yahoo branch we did a similar thing > https://github.com/yahoo/bookkeeper/commit/92e2f906f83d997b5cf5ffd2bcfcdb > e53ca3bd04 > > The idea there was to have a CLI tool to dump the content of a ledger, >

Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-03-31 Thread Matteo Merli
In this commit from the Yahoo branch we did a similar thing https://github.com/yahoo/bookkeeper/commit/92e2f906f83d997b5cf5ffd2bcfcdbe53ca3bd04 The idea there was to have a CLI tool to dump the content of a ledger, reading all the entries (or a subset of them) without triggering the ledger

Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-03-31 Thread Sijie Guo
After taking a look at the proposal, I am not sure if making it a configuration setting is the right approach. However, I would suggest adding a method called #readUncommittedEntries - it would skip the lac checking. so application can decide whether to use readEntries (to read committed entries)

Re: New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-03-30 Thread Sijie Guo
+ dev@ and moved user@ to cc On Thu, Mar 30, 2017 at 8:26 AM, Enrico Olivelli wrote: > I would like to share with the community this BookKeeper proposal > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > BP-5+Allow+reads+outside+the+LAC+Protocol > > I will submit

New BookKeeper Proposal "Allow Reads outside the LAC Protocol"

2017-03-30 Thread Enrico Olivelli
I would like to share with the community this BookKeeper proposal https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-5+Allow+reads+outside+the+LAC+Protocol I will submit a Pull Request to explain the modifications and provide test cases All comments are welcome -- Enrico