On Sun, Nov 29, 2015 at 5:56 PM, Danny Leshem <dles...@gmail.com> wrote:
> Accept this as what? It's not a pull request, just an FYI. > Ah, my mistake, I didn't read carefully enough. Assumed you were proposing this for commons, rather than just doing publicity. Niall > > Either way, as far as I know the JavaScript code that was removed in 1.5.0 > did not handle email / domain validation. > On Nov 29, 2015 7:20 PM, "Niall Pemberton" <niall.pember...@gmail.com> > wrote: > > > On Sat, Nov 28, 2015 at 2:11 PM, Danny Leshem <dles...@gmail.com> wrote: > > > > > *TL;DR-* > > > commons-validator-js <https://github.com/wix/commons-validator-js> is > a > > > partial JavaScript port of commons-validator (currently EmailValidator > > and > > > DomainValidator). > > > > > > > I think its unlikely the current people working on validator will accept > > this as validator used to have javascript validation and its just been > > removed from the latest (1.5.0) release: > > > > https://issues.apache.org/jira/browse/VALIDATOR-371 > > > > > https://commons.apache.org/proper/commons-validator/changes-report.html#a1.5.0 > > > > Niall > > > > > > > > > > > > *Long version-* > > > commons-validator's EmailValidator is by far the best and most > > > comprehensive email validator out there. > > > > > > Unfortunately, there's no equivalent JavaScript implementation. > > > Specifically, I couldn't find a JavaScript email validation library > that > > A) > > > works offline, and B) validates top level domains (e.g. fails > > > "chuck.nor...@gmail.con"). > > > > > > Introducing: commons-validator-js, a JavaScript version of > EmailValidator > > > and DomainValidator, each accompanied by a complete test case. > > > > > > The only challenge was working around some issues with JavaScript's > > regexp > > > implementation, e.g. no support for lookbehind or "\p{...}". > Eventually I > > > commented-out 2-3 tests that still fail, but these were edge cases that > > > didn't really bother me. > > > > > >
