Re: [CSV] Record Separator query

2017-08-26 Thread Gary Gregory 
Hi Bruno,

I think it is fine to proceed with a release for 1.5. The code seems stable
to me now. The mutable record issue does not sound settled and fully baked
to me. I like RERO and since you've kindly volunteered to RM this release,
I'd rather not break your stride.

Gary

On Sat, Aug 26, 2017 at 6:34 AM, Bruno P. Kinoshita <
brunodepau...@yahoo.com.br> wrote:

> Ok, so uploaded my keys, followed the steps at https://commons.apache.org/
> releases/prepare.html, used the commit logs in other commons repositories
> to see what was done for a new release.
>
> I stopped just before the step to Tag the Release Candidate.
>
> Should I proceed and give it a try at my first attempt at releasing a
> commons component and prepare the vote for CSV 1.5 RC1?
>
> Or should we wait for the mutable record ongoing discussion in the mailing
> list?
>
> If anyone would like to take a peek and check if I missed anything before
> I call the vote, any feedback would be welcome :)
> https://github.com/apache/commons-csv/compare/release...
> kinow:release?expand=1
>
> Cheers
> Bruno
>
>
> 
> From: Gary Gregory 
> To: Commons Users List ; Bruno P. Kinoshita <
> brunodepau...@yahoo.com.br>
> Sent: Sunday, 13 August 2017, 4:24:34 PM NZST
> Subject: Re: [CSV] Record Separator query
>
> On Sat, Aug 12, 2017 at 8:48 PM, Bruno P. Kinoshita <
> brunodepau...@yahoo.com.br.invalid> wrote:
> > Hmmm, for a while I have been considering learning how to release
> Commons components. Maybe I could start with Commons CSV, though I could do
> with some help :) I will start reading the docs at
> https://commons.apache.org/ releases/index.html. Is there anything else I
> need to know to act as RM?
>
> Patience :-) there are lots of details.
>
> Gary
>
> >  CheersBruno
> >
> >
> > On Sunday, 13 August 2017, 4:08:36 AM NZST, Gary Gregory <
> garydgreg...@gmail.com> wrote:
> >
> > There is no one currently slated to volunteer to RM the release. Good
> time
> > to ask though!
> >
> > Do have a committer here willing to volunteer to release Commons CSV 1.5?
> >
> > Thank you,
> > Gary
> >
> > On Fri, Aug 11, 2017 at 3:27 PM, nitin mahendru <
> nitin.mahendr...@gmail.com>
> > wrote:
> >
> >> Thanks for accepting the pull request.
> >> Any pointers on when the version 1.5 will be released ?
> >>
> >>
> >>
> >>
> >> On Thu, Aug 10, 2017 at 2:19 PM nitin mahendru <
> nitin.mahendr...@gmail.com
> >> >
> >> wrote:
> >>
> >> > Thanks Greg.
> >> > Well the problem actually was that I am behind a proxy.  So my
> mistake.
> >> > Sorry for that.
> >> >
> >> > I have raised a pull request and a JIRA item CSV-214. Looking forward
> to
> >> > your feedback.
> >> >
> >> > Thanks
> >> >
> >> > Nitin
> >> >
> >> >
> >> >
> >> >
> >> > On Thu, Aug 10, 2017 at 1:08 PM Gary Gregory 
> >> > wrote:
> >> >
> >> >> Use the button provided by GitHub to copy the repo URL to the
> clipboard,
> >> >> then you can just use "git clone "
> >> >>
> >> >> On Thu, Aug 10, 2017 at 1:05 PM, nitin mahendru <
> >> >> nitin.mahendr...@gmail.com>
> >> >> wrote:
> >> >>
> >> >> > Hello All,
> >> >> >
> >> >> > I raised a JIRA ticket(CSV-214) to make some changes to the code
> for
> >> >> what I
> >> >> > a trying to do. The description on the ticket might help explain
> >> things
> >> >> > better. Now I am trying to clone the repo to make a pull request
> but I
> >> >> am
> >> >> > just stuck at this:
> >> >> >
> >> >> > git -c http.sslVerify=false clone https://github.com/apache/
> >> >> > commons-csv.git
> >> >> > Cloning into 'commons-csv'...
> >> >> > fatal: https://github.com/apache/ commons-csv.git/info/refs not
> valid:
> >> >> is
> >> >> > this a git repository?
> >> >> >
> >> >> >
> >> >> > Any Idea about this ?
> >> >> >
> >> >> > Thanks
> >> >> >
> >> >> > Nitin
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> > On Wed, Aug 9, 2017 at 5:17 PM Gary Gregory <
> garydgreg...@gmail.com>
> >> >> > wrote:
> >> >> >
> >> >> > > On Wed, Aug 9, 2017 at 5:04 PM, Guang Chao <
> >> guang.chao.1...@gmail.com
> >> >> >
> >> >> > > wrote:
> >> >> > >
> >> >> > > > On Wed, Aug 9, 2017 at 6:12 AM, nitin mahendru <
> >> >> > > nitin.mahendr...@gmail.com
> >> >> > > > >
> >> >> > > > wrote:
> >> >> > > >
> >> >> > > > > Hello All,
> >> >> > > > >
> >> >> > > > > I am trying to read in a csv file which may be 'crlf' or 'lf'
> >> >> > > seperated.
> >> >> > > > > Then I want to change a particular column, say encrypt it and
> >> then
> >> >> > > write
> >> >> > > > > back a new csv with that updated column. I want to use the
> same
> >> >> > record
> >> >> > > > > separator as was in the input file.
> >> >> > > > >
> >> >> > > > > Is there a way to get the record separator back from the
> >> CSVParser
> >> >> > > > object ?
> >> >> > > > > I am planning to use the below method to get the writer.
> >> >> > > > > CSVFormat.RFC4180. withRecordSeparator( >> >> > > > > separator).print()
>

Re: [CSV] Record Separator query

2017-08-26 Thread Bruno P. Kinoshita 
Ok, so uploaded my keys, followed the steps at 
https://commons.apache.org/releases/prepare.html, used the commit logs in other 
commons repositories to see what was done for a new release.

I stopped just before the step to Tag the Release Candidate.

Should I proceed and give it a try at my first attempt at releasing a commons 
component and prepare the vote for CSV 1.5 RC1?

Or should we wait for the mutable record ongoing discussion in the mailing list?

If anyone would like to take a peek and check if I missed anything before I 
call the vote, any feedback would be welcome :) 
https://github.com/apache/commons-csv/compare/release...kinow:release?expand=1

Cheers
Bruno



From: Gary Gregory 
To: Commons Users List ; Bruno P. Kinoshita 

Sent: Sunday, 13 August 2017, 4:24:34 PM NZST
Subject: Re: [CSV] Record Separator query

On Sat, Aug 12, 2017 at 8:48 PM, Bruno P. Kinoshita 
 wrote:
> Hmmm, for a while I have been considering learning how to release Commons 
> components. Maybe I could start with Commons CSV, though I could do with some 
> help :) I will start reading the docs at https://commons.apache.org/ 
> releases/index.html. Is there anything else I need to know to act as RM?

Patience :-) there are lots of details.

Gary
 
>  CheersBruno
> 
> 
> On Sunday, 13 August 2017, 4:08:36 AM NZST, Gary Gregory 
>  wrote:
> 
> There is no one currently slated to volunteer to RM the release. Good time
> to ask though!
> 
> Do have a committer here willing to volunteer to release Commons CSV 1.5?
> 
> Thank you,
> Gary
> 
> On Fri, Aug 11, 2017 at 3:27 PM, nitin mahendru 
> wrote:
> 
>> Thanks for accepting the pull request.
>> Any pointers on when the version 1.5 will be released ?
>>
>>
>>
>>
>> On Thu, Aug 10, 2017 at 2:19 PM nitin mahendru > >
>> wrote:
>>
>> > Thanks Greg.
>> > Well the problem actually was that I am behind a proxy.  So my mistake.
>> > Sorry for that.
>> >
>> > I have raised a pull request and a JIRA item CSV-214. Looking forward to
>> > your feedback.
>> >
>> > Thanks
>> >
>> > Nitin
>> >
>> >
>> >
>> >
>> > On Thu, Aug 10, 2017 at 1:08 PM Gary Gregory 
>> > wrote:
>> >
>> >> Use the button provided by GitHub to copy the repo URL to the clipboard,
>> >> then you can just use "git clone "
>> >>
>> >> On Thu, Aug 10, 2017 at 1:05 PM, nitin mahendru <
>> >> nitin.mahendr...@gmail.com>
>> >> wrote:
>> >>
>> >> > Hello All,
>> >> >
>> >> > I raised a JIRA ticket(CSV-214) to make some changes to the code for
>> >> what I
>> >> > a trying to do. The description on the ticket might help explain
>> things
>> >> > better. Now I am trying to clone the repo to make a pull request but I
>> >> am
>> >> > just stuck at this:
>> >> >
>> >> > git -c http.sslVerify=false clone https://github.com/apache/
>> >> > commons-csv.git
>> >> > Cloning into 'commons-csv'...
>> >> > fatal: https://github.com/apache/ commons-csv.git/info/refs not valid:
>> >> is
>> >> > this a git repository?
>> >> >
>> >> >
>> >> > Any Idea about this ?
>> >> >
>> >> > Thanks
>> >> >
>> >> > Nitin
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >> > On Wed, Aug 9, 2017 at 5:17 PM Gary Gregory 
>> >> > wrote:
>> >> >
>> >> > > On Wed, Aug 9, 2017 at 5:04 PM, Guang Chao <
>> guang.chao.1...@gmail.com
>> >> >
>> >> > > wrote:
>> >> > >
>> >> > > > On Wed, Aug 9, 2017 at 6:12 AM, nitin mahendru <
>> >> > > nitin.mahendr...@gmail.com
>> >> > > > >
>> >> > > > wrote:
>> >> > > >
>> >> > > > > Hello All,
>> >> > > > >
>> >> > > > > I am trying to read in a csv file which may be 'crlf' or 'lf'
>> >> > > seperated.
>> >> > > > > Then I want to change a particular column, say encrypt it and
>> then
>> >> > > write
>> >> > > > > back a new csv with that updated column. I want to use the same
>> >> > record
>> >> > > > > separator as was in the input file.
>> >> > > > >
>> >> > > > > Is there a way to get the record separator back from the
>> CSVParser
>> >> > > > object ?
>> >> > > > > I am planning to use the below method to get the writer.
>> >> > > > > CSVFormat.RFC4180. withRecordSeparator(> >> > > > > separator).print()
>> >> > > > >
>> >> > > > > For using the above I need to know the record separator upfront
>> >> > which I
>> >> > > > > have no clue about as the Parser object does not expose that
>> >> detail.
>> >> > > > >
>> >> > > > > thanks
>> >> > > > >
>> >> > > > > Nitin
>> >> > > > >
>> >> > > >
>> >> > > > I think CSVParser is strict and may not work for both LF and CRLF.
>> >> > Maybe
>> >> > > > try to scan the file first and see if line ending is lf or crlf,
>> and
>> >> > then
>> >> > > > use a corresponding CSVParser instance that can handle each case.
>> >> > > >
>> >> > >
>> >> > > That's not how it works now but feel free to provide a PR on GitHub