Re: [commons-lang3] potential bug in CharSequenceUtils?

2020-04-29 Thread Xeno Amess
yes it is really a bug. I created a fix pr (with test codes) at https://github.com/apache/commons-lang/pull/529 check in it when you guys have time. Xeno Amess 于2020年4月29日周三 上午5:04写道: > well when I look at StringUtil I found something like this. > > final char c1 = cs.charAt(index1++); > final

[commons-lang3] potential bug in CharSequenceUtils?

2020-04-28 Thread Xeno Amess
well when I look at StringUtil I found something like this. final char c1 = cs.charAt(index1++); final char c2 = substring.charAt(index2++); if (c1 == c2) { continue; } if (!ignoreCase) { return false; } // The same check as in String.regionMatches(): if (Character.toUpperCase(c1) !=